Skip to content

Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍

Task/enable strict null checks in libs/ui (#6637)

Kenrick Tandrian6cd5e3762ef2
diff --git a/libs/ui/src/lib/historical-market-data-editor/historical-market-data-editor-dialog/historical-market-data-editor-dialog.component.ts b/libs/ui/src/lib/historical-market-data-editor/historical-market-data-editor-dialog/historical-market-data-editor-dialog.component.ts
index 3e5e3b2e9b..1b7b99fa21 100644
--- a/libs/ui/src/lib/historical-market-data-editor/historical-market-data-editor-dialog/historical-market-data-editor-dialog.component.ts
+++ b/libs/ui/src/lib/historical-market-data-editor/historical-market-data-editor-dialog/historical-market-data-editor-dialog.component.ts
@@ -25,6 +25,7 @@ import { MatInputModule } from '@angular/material/input';
import { IonIcon } from '@ionic/angular/standalone';
import { addIcons } from 'ionicons';
import { calendarClearOutline, refreshOutline } from 'ionicons/icons';
+import { isNil } from 'lodash';
import { HistoricalMarketDataEditorDialogParams } from './interfaces/interfaces';
@@ -90,7 +91,9 @@ export class GfHistoricalMarketDataEditorDialogComponent implements OnInit {
}
public onUpdate() {
- if (this.marketPrice() === undefined) {
+ const marketPrice = this.marketPrice();
+
+ if (isNil(marketPrice)) {
return;
}
@@ -100,8 +103,8 @@ export class GfHistoricalMarketDataEditorDialogComponent implements OnInit {
marketData: {
marketData: [
{
- date: this.data.dateString,
- marketPrice: this.marketPrice()
+ marketPrice,
+ date: this.data.dateString
}
]
},
diff --git a/libs/ui/src/lib/no-transactions-info/no-transactions-info.component.ts b/libs/ui/src/lib/no-transactions-info/no-transactions-info.component.ts
index 8691dc998d..9ca91d1114 100644
--- a/libs/ui/src/lib/no-transactions-info/no-transactions-info.component.ts
+++ b/libs/ui/src/lib/no-transactions-info/no-transactions-info.component.ts
@@ -24,5 +24,5 @@ export class GfNoTransactionsInfoComponent {
@HostBinding('class.has-border') @Input() hasBorder = true;
public routerLinkPortfolioActivities =
- internalRoutes.portfolio.subRoutes.activities.routerLink;
+ internalRoutes.portfolio.subRoutes?.activities.routerLink;
}
diff --git a/libs/ui/src/lib/shared/abstract-mat-form-field.ts b/libs/ui/src/lib/shared/abstract-mat-form-field.ts
index 628f0a659d..0d547af4ef 100644
--- a/libs/ui/src/lib/shared/abstract-mat-form-field.ts
+++ b/libs/ui/src/lib/shared/abstract-mat-form-field.ts
@@ -37,7 +37,7 @@ export abstract class AbstractMatFormField<T>
private static nextId = 0;
protected constructor(
- protected _elementRef: ElementRef,
+ protected _elementRef: ElementRef<HTMLElement>,
protected _focusMonitor: FocusMonitor,
public readonly ngControl: NgControl
) {
@@ -137,7 +137,7 @@ export abstract class AbstractMatFormField<T>
public ngDoCheck() {
if (this.ngControl) {
- this.errorState = this.ngControl.invalid && this.ngControl.touched;
+ this.errorState = !!(this.ngControl.invalid && this.ngControl.touched);
this.stateChanges.next();
}
}
diff --git a/libs/ui/tsconfig.json b/libs/ui/tsconfig.json
index 04f4630bc7..51348a52a0 100644
--- a/libs/ui/tsconfig.json
+++ b/libs/ui/tsconfig.json
@@ -19,6 +19,7 @@
"target": "es2020",
// TODO: Remove once solved in tsconfig.base.json
"strict": false,
+ "strictNullChecks": true,
"noImplicitReturns": true,
"noFallthroughCasesInSwitch": true
},