Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍
TypeScript angularetffinancefintechghostfoliohacktoberfestinvestingnestjsosspersonal-financeportfolioprismasoftwarestocktrackertradingtypescriptwealth-managementweb
Bugfix/fix cryptocurrency symbols with less than 3 characters (#1325)
Thomas Kaul6e1935899f4f
diff --git a/CHANGELOG.md b/CHANGELOG.mdindex 8d922bd952..37357865eb 100644--- a/CHANGELOG.md+++ b/CHANGELOG.md@@ -11,6 +11,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0- Improved the caching of the benchmarks in the markets overview (only cache if fetching was successful)+### Fixed++- Fixed the support for cryptocurrencies having a symbol with less than 3 characters (e.g. `SC-USD`)+## 1.201.0 - 01.10.2022### Addeddiff --git a/apps/api/src/services/data-provider/yahoo-finance/yahoo-finance.service.ts b/apps/api/src/services/data-provider/yahoo-finance/yahoo-finance.service.tsindex bc408ca4da..64d318ac8d 100644--- a/apps/api/src/services/data-provider/yahoo-finance/yahoo-finance.service.ts+++ b/apps/api/src/services/data-provider/yahoo-finance/yahoo-finance.service.ts@@ -58,8 +58,15 @@ export class YahooFinanceService implements DataProviderInterface {* DOGEUSD -> DOGE-USD*/public convertToYahooFinanceSymbol(aSymbol: string) {- if (aSymbol.includes(this.baseCurrency) && aSymbol.length >= 6) {- if (isCurrency(aSymbol.substring(0, aSymbol.length - 3))) {+ if (+ aSymbol.includes(this.baseCurrency) &&+ aSymbol.length > this.baseCurrency.length+ ) {+ if (+ isCurrency(+ aSymbol.substring(0, aSymbol.length - this.baseCurrency.length)+ )+ ) {return `${aSymbol}=X`;} else if (this.cryptocurrencyService.isCryptocurrency(