Skip to content

Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍

Task/set change detection strategy to OnPush in portfolio page (#7241)

ylink6f2db3e649ae
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 9f776ccc3f..73ebdf56cb 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -17,6 +17,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Set the change detection strategy to `OnPush` in the confirmation dialog component
- Set the change detection strategy to `OnPush` in the prompt dialog component
- Set the change detection strategy to `OnPush` in the overview of the admin control panel
+- Set the change detection strategy to `OnPush` in the portfolio page
- Upgraded `envalid` from version `8.1.1` to `8.2.0`
- Upgraded `stripe` from version `21.0.1` to `22.2.3`
diff --git a/apps/client/src/app/pages/portfolio/portfolio-page.component.ts b/apps/client/src/app/pages/portfolio/portfolio-page.component.ts
index 7f60edae88..f921654878 100644
--- a/apps/client/src/app/pages/portfolio/portfolio-page.component.ts
+++ b/apps/client/src/app/pages/portfolio/portfolio-page.component.ts
@@ -6,7 +6,12 @@ import {
TabConfiguration
} from '@ghostfolio/ui/page-tabs';
-import { ChangeDetectorRef, Component, DestroyRef } from '@angular/core';
+import {
+ ChangeDetectionStrategy,
+ ChangeDetectorRef,
+ Component,
+ DestroyRef
+} from '@angular/core';
import { takeUntilDestroyed } from '@angular/core/rxjs-interop';
import { addIcons } from 'ionicons';
import {
@@ -18,6 +23,7 @@ import {
} from 'ionicons/icons';
@Component({
+ changeDetection: ChangeDetectionStrategy.OnPush,
host: { class: 'page' },
imports: [GfPageTabsComponent],
selector: 'gf-portfolio-page',
@@ -67,9 +73,9 @@ export class PortfolioPageComponent {
}
];
this.user = state.user;
-
- this.changeDetectorRef.markForCheck();
}
+
+ this.changeDetectorRef.markForCheck();
});
addIcons({