Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍
TypeScript angularetffinancefintechghostfoliohacktoberfestinvestingnestjsosspersonal-financeportfolioprismasoftwarestocktrackertradingtypescriptwealth-managementweb
Task/refactor BenchmarkMarketDataDetails to BenchmarkMarketDataDetailsResponse (#5771)
Google71b375ea9270
diff --git a/apps/api/src/app/endpoints/benchmarks/benchmarks.controller.ts b/apps/api/src/app/endpoints/benchmarks/benchmarks.controller.tsindex 69383a30d4..629d909280 100644--- a/apps/api/src/app/endpoints/benchmarks/benchmarks.controller.ts+++ b/apps/api/src/app/endpoints/benchmarks/benchmarks.controller.ts@@ -8,7 +8,7 @@ import { getIntervalFromDateRange } from '@ghostfolio/common/calculation-helper'import { HEADER_KEY_IMPERSONATION } from '@ghostfolio/common/config';import type {AssetProfileIdentifier,- BenchmarkMarketDataDetails,+ BenchmarkMarketDataDetailsResponse,BenchmarkResponse} from '@ghostfolio/common/interfaces';import { permissions } from '@ghostfolio/common/permissions';@@ -125,7 +125,7 @@ export class BenchmarksController {@Query('symbol') filterBySymbol?: string,@Query('tags') filterByTags?: string,@Query('withExcludedAccounts') withExcludedAccountsParam = 'false'- ): Promise<BenchmarkMarketDataDetails> {+ ): Promise<BenchmarkMarketDataDetailsResponse> {const { endDate, startDate } = getIntervalFromDateRange(dateRange,new Date(startDateString)diff --git a/apps/api/src/app/endpoints/benchmarks/benchmarks.service.ts b/apps/api/src/app/endpoints/benchmarks/benchmarks.service.tsindex aa53564b70..03ff32c21f 100644--- a/apps/api/src/app/endpoints/benchmarks/benchmarks.service.ts+++ b/apps/api/src/app/endpoints/benchmarks/benchmarks.service.ts@@ -6,7 +6,7 @@ import { MarketDataService } from '@ghostfolio/api/services/market-data/market-dimport { DATE_FORMAT, parseDate, resetHours } from '@ghostfolio/common/helper';import {AssetProfileIdentifier,- BenchmarkMarketDataDetails,+ BenchmarkMarketDataDetailsResponse,Filter} from '@ghostfolio/common/interfaces';import { DateRange, UserWithSettings } from '@ghostfolio/common/types';@@ -43,7 +43,7 @@ export class BenchmarksService {startDate: Date;user: UserWithSettings;withExcludedAccounts?: boolean;- } & AssetProfileIdentifier): Promise<BenchmarkMarketDataDetails> {+ } & AssetProfileIdentifier): Promise<BenchmarkMarketDataDetailsResponse> {const marketData: { date: string; value: number }[] = [];const userCurrency = user.settings.settings.baseCurrency;const userId = user.id;diff --git a/apps/client/src/app/services/data.service.ts b/apps/client/src/app/services/data.service.tsindex b5f6d9e012..3cb5a8c75f 100644--- a/apps/client/src/app/services/data.service.ts+++ b/apps/client/src/app/services/data.service.ts@@ -30,7 +30,7 @@ import {AiPromptResponse,ApiKeyResponse,AssetProfileIdentifier,- BenchmarkMarketDataDetails,+ BenchmarkMarketDataDetailsResponse,BenchmarkResponse,DataProviderHealthResponse,Export,@@ -368,7 +368,7 @@ export class DataService {range: DateRange;startDate: Date;withExcludedAccounts?: boolean;- } & AssetProfileIdentifier): Observable<BenchmarkMarketDataDetails> {+ } & AssetProfileIdentifier) {let params = this.buildFiltersAsQueryParams({ filters });params = params.append('range', range);@@ -377,7 +377,7 @@ export class DataService {params = params.append('withExcludedAccounts', withExcludedAccounts);}- return this.http.get<BenchmarkMarketDataDetails>(+ return this.http.get<BenchmarkMarketDataDetailsResponse>(`/api/v1/benchmarks/${dataSource}/${symbol}/${format(startDate, DATE_FORMAT, { in: utc })}`,{ params });diff --git a/libs/common/src/lib/interfaces/index.ts b/libs/common/src/lib/interfaces/index.tsindex 8a7ef85440..578d9cec8f 100644--- a/libs/common/src/lib/interfaces/index.ts+++ b/libs/common/src/lib/interfaces/index.ts@@ -10,7 +10,6 @@ import type {import type { AdminUsers } from './admin-users.interface';import type { AssetClassSelectorOption } from './asset-class-selector-option.interface';import type { AssetProfileIdentifier } from './asset-profile-identifier.interface';-import type { BenchmarkMarketDataDetails } from './benchmark-market-data-details.interface';import type { BenchmarkProperty } from './benchmark-property.interface';import type { Benchmark } from './benchmark.interface';import type { Coupon } from './coupon.interface';@@ -41,6 +40,7 @@ import type { AccountBalancesResponse } from './responses/account-balances-respoimport type { AccountsResponse } from './responses/accounts-response.interface';import type { AiPromptResponse } from './responses/ai-prompt-response.interface';import type { ApiKeyResponse } from './responses/api-key-response.interface';+import type { BenchmarkMarketDataDetailsResponse } from './responses/benchmark-market-data-details-response.interface';import type { BenchmarkResponse } from './responses/benchmark-response.interface';import type { DataEnhancerHealthResponse } from './responses/data-enhancer-health-response.interface';import type { DataProviderGhostfolioAssetProfileResponse } from './responses/data-provider-ghostfolio-asset-profile-response.interface';@@ -91,7 +91,7 @@ export {AssetClassSelectorOption,AssetProfileIdentifier,Benchmark,- BenchmarkMarketDataDetails,+ BenchmarkMarketDataDetailsResponse,BenchmarkProperty,BenchmarkResponse,Coupon,diff --git a/libs/common/src/lib/interfaces/benchmark-market-data-details.interface.ts b/libs/common/src/lib/interfaces/responses/benchmark-market-data-details-response.interface.tssimilarity index 64%rename from libs/common/src/lib/interfaces/benchmark-market-data-details.interface.tsrename to libs/common/src/lib/interfaces/responses/benchmark-market-data-details-response.interface.tsindex ed693b9af4..cdd63ff793 100644--- a/libs/common/src/lib/interfaces/benchmark-market-data-details.interface.ts+++ b/libs/common/src/lib/interfaces/responses/benchmark-market-data-details-response.interface.ts@@ -1,5 +1,5 @@import { LineChartItem } from '@ghostfolio/common/interfaces';-export interface BenchmarkMarketDataDetails {+export interface BenchmarkMarketDataDetailsResponse {marketData: LineChartItem[];}