Skip to content

Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍

Add test case: sell partially with huge gain (#1380)

Thomas Kaul71c5412dd5e7
diff --git a/apps/api/src/app/portfolio/current-rate.service.mock.ts b/apps/api/src/app/portfolio/current-rate.service.mock.ts
index 9246ffc73e..004f642bfb 100644
--- a/apps/api/src/app/portfolio/current-rate.service.mock.ts
+++ b/apps/api/src/app/portfolio/current-rate.service.mock.ts
@@ -21,6 +21,17 @@ function mockGetValue(symbol: string, date: Date) {
return { marketPrice: 0 };
+ case 'BTCUSD':
+ if (isSameDay(parseDate('2015-01-01'), date)) {
+ return { marketPrice: 314.25 };
+ } else if (isSameDay(parseDate('2017-12-31'), date)) {
+ return { marketPrice: 14156.4 };
+ } else if (isSameDay(parseDate('2018-01-01'), date)) {
+ return { marketPrice: 13657.2 };
+ }
+
+ return { marketPrice: 0 };
+
case 'NOVN.SW':
if (isSameDay(parseDate('2022-04-11'), date)) {
return { marketPrice: 87.8 };
diff --git a/apps/api/src/app/portfolio/portfolio-calculator-btcusd-buy-and-sell-partially.spec.ts b/apps/api/src/app/portfolio/portfolio-calculator-btcusd-buy-and-sell-partially.spec.ts
new file mode 100644
index 0000000000..ddb46c9a35
--- /dev/null
+++ b/apps/api/src/app/portfolio/portfolio-calculator-btcusd-buy-and-sell-partially.spec.ts
@@ -0,0 +1,110 @@
+import { CurrentRateService } from '@ghostfolio/api/app/portfolio/current-rate.service';
+import { parseDate } from '@ghostfolio/common/helper';
+import Big from 'big.js';
+
+import { CurrentRateServiceMock } from './current-rate.service.mock';
+import { PortfolioCalculator } from './portfolio-calculator';
+
+jest.mock('@ghostfolio/api/app/portfolio/current-rate.service', () => {
+ return {
+ // eslint-disable-next-line @typescript-eslint/naming-convention
+ CurrentRateService: jest.fn().mockImplementation(() => {
+ return CurrentRateServiceMock;
+ })
+ };
+});
+
+describe('PortfolioCalculator', () => {
+ let currentRateService: CurrentRateService;
+
+ beforeEach(() => {
+ currentRateService = new CurrentRateService(null, null, null);
+ });
+
+ describe('get current positions', () => {
+ it.only('with BTCUSD buy and sell partially', async () => {
+ const portfolioCalculator = new PortfolioCalculator({
+ currentRateService,
+ currency: 'CHF',
+ orders: [
+ {
+ currency: 'CHF',
+ date: '2015-01-01',
+ dataSource: 'YAHOO',
+ fee: new Big(0),
+ name: 'Bitcoin USD',
+ quantity: new Big(2),
+ symbol: 'BTCUSD',
+ type: 'BUY',
+ unitPrice: new Big(320.43)
+ },
+ {
+ currency: 'CHF',
+ date: '2017-12-31',
+ dataSource: 'YAHOO',
+ fee: new Big(0),
+ name: 'Bitcoin USD',
+ quantity: new Big(1),
+ symbol: 'BTCUSD',
+ type: 'SELL',
+ unitPrice: new Big(14156.4)
+ }
+ ]
+ });
+
+ portfolioCalculator.computeTransactionPoints();
+
+ const spy = jest
+ .spyOn(Date, 'now')
+ .mockImplementation(() => parseDate('2018-01-01').getTime());
+
+ const currentPositions = await portfolioCalculator.getCurrentPositions(
+ parseDate('2015-01-01')
+ );
+
+ const investments = portfolioCalculator.getInvestments();
+
+ const investmentsByMonth = portfolioCalculator.getInvestmentsByMonth();
+
+ spy.mockRestore();
+
+ expect(currentPositions).toEqual({
+ currentValue: new Big('13657.2'),
+ errors: [],
+ grossPerformance: new Big('27172.74'),
+ grossPerformancePercentage: new Big('42.40043067128546016291'),
+ hasErrors: false,
+ netPerformance: new Big('27172.74'),
+ netPerformancePercentage: new Big('42.40043067128546016291'),
+ positions: [
+ {
+ averagePrice: new Big('320.43'),
+ currency: 'CHF',
+ dataSource: 'YAHOO',
+ firstBuyDate: '2015-01-01',
+ grossPerformance: new Big('27172.74'),
+ grossPerformancePercentage: new Big('42.40043067128546016291'),
+ investment: new Big('320.43'),
+ netPerformance: new Big('27172.74'),
+ netPerformancePercentage: new Big('42.40043067128546016291'),
+ marketPrice: 13657.2,
+ quantity: new Big('1'),
+ symbol: 'BTCUSD',
+ transactionCount: 2
+ }
+ ],
+ totalInvestment: new Big('320.43')
+ });
+
+ expect(investments).toEqual([
+ { date: '2015-01-01', investment: new Big('640.86') },
+ { date: '2017-12-31', investment: new Big('320.43') }
+ ]);
+
+ expect(investmentsByMonth).toEqual([
+ { date: '2015-01-01', investment: new Big('640.86') },
+ { date: '2017-12-01', investment: new Big('-14156.4') }
+ ]);
+ });
+ });
+});