Skip to content

Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍

Bugfix/exclude emtpy items in activities filter (#999)

Thomas Kaul74fe90906a66
diff --git a/CHANGELOG.md b/CHANGELOG.md
index c8df6ba515..93be00b6af 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -14,6 +14,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Upgraded `chart.js` from version `3.7.0` to `3.8.0`
- Upgraded `envalid` from version `7.2.1` to `7.3.1`
+### Fixed
+
+- Excluded empty items in the activities filter
+
## 1.156.0 - 05.06.2022
### Added
diff --git a/libs/ui/src/lib/activities-table/activities-table.component.ts b/libs/ui/src/lib/activities-table/activities-table.component.ts
index 055c82d86a..268df1f3a8 100644
--- a/libs/ui/src/lib/activities-table/activities-table.component.ts
+++ b/libs/ui/src/lib/activities-table/activities-table.component.ts
@@ -192,11 +192,13 @@ export class ActivitiesTableComponent implements OnChanges, OnDestroy {
activity: OrderWithAccount,
fieldValueMap: { [id: string]: Filter } = {}
): Filter[] {
- fieldValueMap[activity.Account?.id] = {
- id: activity.Account?.id,
- label: activity.Account?.name,
- type: 'ACCOUNT'
- };
+ if (activity.Account?.id) {
+ fieldValueMap[activity.Account.id] = {
+ id: activity.Account.id,
+ label: activity.Account.name,
+ type: 'ACCOUNT'
+ };
+ }
fieldValueMap[activity.SymbolProfile.currency] = {
id: activity.SymbolProfile.currency,