Skip to content

Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍

Bugfix/fix all time high in benchmarks (#3527)

Thomas Kaul76890e63fafb
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 514f893939..c52c8589ca 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
+## Unreleased
+
+### Fixed
+
+- Fixed an issue with the all time high in the benchmarks of the markets overview
+
## 2.91.0 - 2024-06-26
### Added
diff --git a/apps/api/src/app/benchmark/benchmark.service.ts b/apps/api/src/app/benchmark/benchmark.service.ts
index f4f2d78485..6008746d12 100644
--- a/apps/api/src/app/benchmark/benchmark.service.ts
+++ b/apps/api/src/app/benchmark/benchmark.service.ts
@@ -161,7 +161,10 @@ export class BenchmarkService {
performances: {
allTimeHigh: {
date: allTimeHigh?.date,
- performancePercent: performancePercentFromAllTimeHigh
+ performancePercent:
+ performancePercentFromAllTimeHigh >= 0
+ ? 0
+ : performancePercentFromAllTimeHigh
}
},
symbol: benchmarkAssetProfiles[index].symbol,
@@ -419,7 +422,7 @@ export class BenchmarkService {
private getMarketCondition(
aPerformanceInPercent: number
): Benchmark['marketCondition'] {
- if (aPerformanceInPercent === 0) {
+ if (aPerformanceInPercent >= 0) {
return 'ALL_TIME_HIGH';
} else if (aPerformanceInPercent <= -0.2) {
return 'BEAR_MARKET';