Skip to content

Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍

Task/add asset profile to portfolio position interface (part 2) (#6500)

Thomas Kaul7ac32ee6f363
diff --git a/apps/api/src/app/portfolio/portfolio.service.ts b/apps/api/src/app/portfolio/portfolio.service.ts
index ed72260ca4..1673394871 100644
--- a/apps/api/src/app/portfolio/portfolio.service.ts
+++ b/apps/api/src/app/portfolio/portfolio.service.ts
@@ -628,6 +628,7 @@ export class PortfolioService {
assetSubClass: assetProfile.assetSubClass,
countries: assetProfile.countries,
dataSource: assetProfile.dataSource,
+ currency: assetProfile.currency,
holdings: assetProfile.holdings.map(
({ allocationInPercentage, name }) => {
return {
@@ -1699,6 +1700,7 @@ export class PortfolioService {
assetClass: AssetClass.LIQUIDITY,
assetSubClass: AssetSubClass.CASH,
assetProfile: {
+ currency,
assetClass: AssetClass.LIQUIDITY,
assetSubClass: AssetSubClass.CASH,
countries: [],
diff --git a/libs/common/src/lib/interfaces/portfolio-position.interface.ts b/libs/common/src/lib/interfaces/portfolio-position.interface.ts
index 742e63d7ac..c4ef2e3dc7 100644
--- a/libs/common/src/lib/interfaces/portfolio-position.interface.ts
+++ b/libs/common/src/lib/interfaces/portfolio-position.interface.ts
@@ -22,6 +22,7 @@ export interface PortfolioPosition {
| 'assetClass'
| 'assetSubClass'
| 'countries'
+ | 'currency'
| 'dataSource'
| 'holdings'
| 'name'
@@ -42,6 +43,7 @@ export interface PortfolioPosition {
/** @deprecated */
countries: Country[];
+ /** @deprecated */
currency: string;
/** @deprecated */
diff --git a/libs/ui/src/lib/mocks/holdings.ts b/libs/ui/src/lib/mocks/holdings.ts
index f426593c13..b32eb527aa 100644
--- a/libs/ui/src/lib/mocks/holdings.ts
+++ b/libs/ui/src/lib/mocks/holdings.ts
@@ -17,6 +17,7 @@ export const holdings: PortfolioPosition[] = [
weight: 1
}
],
+ currency: 'USD',
dataSource: 'YAHOO',
holdings: [],
sectors: [
@@ -81,6 +82,7 @@ export const holdings: PortfolioPosition[] = [
weight: 1
}
],
+ currency: 'EUR',
dataSource: 'YAHOO',
holdings: [],
sectors: [
@@ -145,6 +147,7 @@ export const holdings: PortfolioPosition[] = [
weight: 1
}
],
+ currency: 'USD',
dataSource: 'YAHOO',
holdings: [],
sectors: [
@@ -202,6 +205,7 @@ export const holdings: PortfolioPosition[] = [
assetClass: 'LIQUIDITY',
assetSubClass: 'CASH',
countries: [],
+ currency: 'USD',
dataSource: 'COINGECKO',
holdings: [],
sectors: [],
@@ -249,6 +253,7 @@ export const holdings: PortfolioPosition[] = [
weight: 1
}
],
+ currency: 'USD',
dataSource: 'YAHOO',
holdings: [],
sectors: [
@@ -313,6 +318,7 @@ export const holdings: PortfolioPosition[] = [
weight: 1
}
],
+ currency: 'USD',
dataSource: 'YAHOO',
holdings: [],
sectors: [
@@ -377,6 +383,7 @@ export const holdings: PortfolioPosition[] = [
weight: 1
}
],
+ currency: 'USD',
dataSource: 'YAHOO',
holdings: [],
sectors: [