Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍
TypeScript angularetffinancefintechghostfoliohacktoberfestinvestingnestjsosspersonal-financeportfolioprismasoftwarestocktrackertradingtypescriptwealth-managementweb
Bugfix/portfolio snapshot cache write and initialization retry limit (#7517)
Thomas Kaul7d053caf805a
diff --git a/CHANGELOG.md b/CHANGELOG.mdindex a916f86432..d6ef5e2f03 100644--- a/CHANGELOG.md+++ b/CHANGELOG.md@@ -21,6 +21,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0### Fixed- Fixed the loading state in the user detail dialog of the admin control panel’s users section+- Fixed a race condition where the portfolio snapshot computation was completed before its result had been cached, causing a redundant recomputation+- Fixed an endless loop in the portfolio snapshot computation if the computed result could not be read from the cache## 3.40.0 - 2026-08-02diff --git a/apps/api/src/app/app.module.ts b/apps/api/src/app/app.module.tsindex bd76ef49b4..ddda044a79 100644--- a/apps/api/src/app/app.module.ts+++ b/apps/api/src/app/app.module.ts@@ -1,4 +1,5 @@import { EventsModule } from '@ghostfolio/api/events/events.module';+import { PortfolioSnapshotComputationExceptionFilter } from '@ghostfolio/api/filters/portfolio-snapshot-computation-exception.filter';import { getRedisConnectionOptions } from '@ghostfolio/api/helper/redis.helper';import { BullBoardAuthMiddleware } from '@ghostfolio/api/middlewares/bull-board-auth.middleware';import { HtmlTemplateMiddleware } from '@ghostfolio/api/middlewares/html-template.middleware';@@ -24,6 +25,7 @@ import { ThrottlerStorageRedisService } from '@nest-lab/throttler-storage-redis'import { BullModule } from '@nestjs/bull';import { MiddlewareConsumer, Module, NestModule } from '@nestjs/common';import { ConfigModule } from '@nestjs/config';+import { APP_FILTER } from '@nestjs/core';import { EventEmitterModule } from '@nestjs/event-emitter';import { ScheduleModule } from '@nestjs/schedule';import { ServeStaticModule } from '@nestjs/serve-static';@@ -184,7 +186,13 @@ import { UserModule } from './user/user.module';UserModule,WatchlistModule],- providers: [I18nService]+ providers: [+ I18nService,+ {+ provide: APP_FILTER,+ useClass: PortfolioSnapshotComputationExceptionFilter+ }+ ]})export class AppModule implements NestModule {public configure(consumer: MiddlewareConsumer) {diff --git a/apps/api/src/app/portfolio/calculator/portfolio-calculator.ts b/apps/api/src/app/portfolio/calculator/portfolio-calculator.tsindex 38f942156a..cdab3fdf06 100644--- a/apps/api/src/app/portfolio/calculator/portfolio-calculator.ts+++ b/apps/api/src/app/portfolio/calculator/portfolio-calculator.ts@@ -1,4 +1,5 @@import { CurrentRateService } from '@ghostfolio/api/app/portfolio/current-rate.service';+import { PortfolioSnapshotComputationError } from '@ghostfolio/api/app/portfolio/errors/portfolio-snapshot-computation.error';import { PortfolioCalculatorPosition } from '@ghostfolio/api/app/portfolio/interfaces/portfolio-calculator-position.interface';import { PortfolioOrder } from '@ghostfolio/api/app/portfolio/interfaces/portfolio-order.interface';import { PortfolioSnapshotValue } from '@ghostfolio/api/app/portfolio/interfaces/snapshot-value.interface';@@ -65,6 +66,8 @@ import { isNumber, sortBy, sum, uniqBy } from 'lodash';export abstract class PortfolioCalculator {protected static readonly ENABLE_LOGGING = false;+ private static readonly MAX_INITIALIZATION_ATTEMPTS = 3;+protected readonly logger = new Logger(PortfolioCalculator.name);protected accountBalanceItems: HistoricalDataItem[];@@ -174,6 +177,11 @@ export abstract class PortfolioCalculator {this.computeTransactionPoints();this.snapshotPromise = this.initialize();++ // Mark the rejection as handled to prevent an unhandled promise rejection+ // in case the snapshot promise is never awaited. Consumers awaiting it+ // still receive the error.+ this.snapshotPromise.catch(() => undefined);}protected abstract calculateOverallPerformance(@@ -1124,7 +1132,7 @@ export abstract class PortfolioCalculator {}@LogPerformance- private async initialize() {+ private async initialize(attempt = 1) {const startTimeTotal = performance.now();let cachedPortfolioSnapshot: PortfolioSnapshot;@@ -1183,6 +1191,12 @@ export abstract class PortfolioCalculator {});}} else {+ if (attempt > PortfolioCalculator.MAX_INITIALIZATION_ATTEMPTS) {+ throw new PortfolioSnapshotComputationError(+ `Portfolio snapshot of user '${this.userId}' could not be computed after ${PortfolioCalculator.MAX_INITIALIZATION_ATTEMPTS} attempts`+ );+ }+// Wait for computationawait this.portfolioSnapshotService.addJobToQueue({data: {@@ -1205,7 +1219,7 @@ export abstract class PortfolioCalculator {await job.finished();}- await this.initialize();+ await this.initialize(attempt + 1);}}}diff --git a/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-baln-buy-and-buy.spec.ts b/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-baln-buy-and-buy.spec.tsindex fe23af04bb..a6bedc55d1 100644--- a/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-baln-buy-and-buy.spec.ts+++ b/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-baln-buy-and-buy.spec.ts@@ -54,6 +54,9 @@ describe('PortfolioCalculator', () => {let redisCacheService: RedisCacheService;beforeEach(() => {+ PortfolioSnapshotServiceMock.reset();+ RedisCacheServiceMock.reset();+configurationService = new ConfigurationService();currentRateService = new CurrentRateService(null, null, null, null);diff --git a/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-baln-buy-and-sell-in-two-activities.spec.ts b/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-baln-buy-and-sell-in-two-activities.spec.tsindex 061aaf8170..dc22cdbab5 100644--- a/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-baln-buy-and-sell-in-two-activities.spec.ts+++ b/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-baln-buy-and-sell-in-two-activities.spec.ts@@ -54,6 +54,9 @@ describe('PortfolioCalculator', () => {let redisCacheService: RedisCacheService;beforeEach(() => {+ PortfolioSnapshotServiceMock.reset();+ RedisCacheServiceMock.reset();+configurationService = new ConfigurationService();currentRateService = new CurrentRateService(null, null, null, null);diff --git a/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-baln-buy-and-sell.spec.ts b/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-baln-buy-and-sell.spec.tsindex c8e0af46de..9d55a79ddb 100644--- a/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-baln-buy-and-sell.spec.ts+++ b/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-baln-buy-and-sell.spec.ts@@ -54,6 +54,9 @@ describe('PortfolioCalculator', () => {let redisCacheService: RedisCacheService;beforeEach(() => {+ PortfolioSnapshotServiceMock.reset();+ RedisCacheServiceMock.reset();+configurationService = new ConfigurationService();currentRateService = new CurrentRateService(null, null, null, null);diff --git a/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-baln-buy.spec.ts b/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-baln-buy.spec.tsindex 4922382a9a..a2d576361d 100644--- a/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-baln-buy.spec.ts+++ b/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-baln-buy.spec.ts@@ -54,6 +54,9 @@ describe('PortfolioCalculator', () => {let redisCacheService: RedisCacheService;beforeEach(() => {+ PortfolioSnapshotServiceMock.reset();+ RedisCacheServiceMock.reset();+configurationService = new ConfigurationService();currentRateService = new CurrentRateService(null, null, null, null);diff --git a/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-btceur-in-base-currency-eur.spec.ts b/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-btceur-in-base-currency-eur.spec.tsindex 21a8d2056a..1143e3bd27 100644--- a/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-btceur-in-base-currency-eur.spec.ts+++ b/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-btceur-in-base-currency-eur.spec.ts@@ -76,6 +76,9 @@ describe('PortfolioCalculator', () => {});beforeEach(() => {+ PortfolioSnapshotServiceMock.reset();+ RedisCacheServiceMock.reset();+configurationService = new ConfigurationService();currentRateService = new CurrentRateService(null, null, null, null);diff --git a/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-btceur.spec.ts b/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-btceur.spec.tsindex 4f5da58b85..e5b0d69d64 100644--- a/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-btceur.spec.ts+++ b/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-btceur.spec.ts@@ -64,6 +64,9 @@ describe('PortfolioCalculator', () => {});beforeEach(() => {+ PortfolioSnapshotServiceMock.reset();+ RedisCacheServiceMock.reset();+configurationService = new ConfigurationService();currentRateService = new CurrentRateService(null, null, null, null);diff --git a/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-btcusd-buy-and-sell-partially.spec.ts b/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-btcusd-buy-and-sell-partially.spec.tsindex f20506b061..ea1df42032 100644--- a/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-btcusd-buy-and-sell-partially.spec.ts+++ b/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-btcusd-buy-and-sell-partially.spec.ts@@ -66,6 +66,9 @@ describe('PortfolioCalculator', () => {let redisCacheService: RedisCacheService;beforeEach(() => {+ PortfolioSnapshotServiceMock.reset();+ RedisCacheServiceMock.reset();+configurationService = new ConfigurationService();currentRateService = new CurrentRateService(null, null, null, null);diff --git a/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-btcusd-short.spec.ts b/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-btcusd-short.spec.tsindex 79c6979ef3..93d91c500e 100644--- a/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-btcusd-short.spec.ts+++ b/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-btcusd-short.spec.ts@@ -64,6 +64,9 @@ describe('PortfolioCalculator', () => {});beforeEach(() => {+ PortfolioSnapshotServiceMock.reset();+ RedisCacheServiceMock.reset();+configurationService = new ConfigurationService();currentRateService = new CurrentRateService(null, null, null, null);diff --git a/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-btcusd.spec.ts b/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-btcusd.spec.tsindex eb5571feb1..1fa2d12641 100644--- a/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-btcusd.spec.ts+++ b/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-btcusd.spec.ts@@ -64,6 +64,9 @@ describe('PortfolioCalculator', () => {});beforeEach(() => {+ PortfolioSnapshotServiceMock.reset();+ RedisCacheServiceMock.reset();+configurationService = new ConfigurationService();currentRateService = new CurrentRateService(null, null, null, null);diff --git a/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-cash.spec.ts b/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-cash.spec.tsindex aaa2f63cfa..3b09bfd260 100644--- a/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-cash.spec.ts+++ b/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-cash.spec.ts@@ -77,6 +77,9 @@ describe('PortfolioCalculator', () => {let redisCacheService: RedisCacheService;beforeEach(() => {+ PortfolioSnapshotServiceMock.reset();+ RedisCacheServiceMock.reset();+configurationService = new ConfigurationService();exchangeRateDataService = new ExchangeRateDataService(diff --git a/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-fee.spec.ts b/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-fee.spec.tsindex 4e413c0c52..000cc59357 100644--- a/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-fee.spec.ts+++ b/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-fee.spec.ts@@ -54,6 +54,9 @@ describe('PortfolioCalculator', () => {let redisCacheService: RedisCacheService;beforeEach(() => {+ PortfolioSnapshotServiceMock.reset();+ RedisCacheServiceMock.reset();+configurationService = new ConfigurationService();currentRateService = new CurrentRateService(null, null, null, null);diff --git a/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-googl-buy.spec.ts b/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-googl-buy.spec.tsindex 984dc11548..451973a9ff 100644--- a/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-googl-buy.spec.ts+++ b/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-googl-buy.spec.ts@@ -66,6 +66,9 @@ describe('PortfolioCalculator', () => {let redisCacheService: RedisCacheService;beforeEach(() => {+ PortfolioSnapshotServiceMock.reset();+ RedisCacheServiceMock.reset();+configurationService = new ConfigurationService();currentRateService = new CurrentRateService(null, null, null, null);diff --git a/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-jnug-buy-and-sell-and-buy-and-sell.spec.ts b/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-jnug-buy-and-sell-and-buy-and-sell.spec.tsindex 962cfe2d88..2cc87934ae 100644--- a/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-jnug-buy-and-sell-and-buy-and-sell.spec.ts+++ b/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-jnug-buy-and-sell-and-buy-and-sell.spec.ts@@ -67,6 +67,9 @@ describe('PortfolioCalculator', () => {});beforeEach(() => {+ PortfolioSnapshotServiceMock.reset();+ RedisCacheServiceMock.reset();+configurationService = new ConfigurationService();currentRateService = new CurrentRateService(null, null, null, null);diff --git a/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-liability.spec.ts b/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-liability.spec.tsindex 94654af610..68572c63e1 100644--- a/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-liability.spec.ts+++ b/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-liability.spec.ts@@ -54,6 +54,9 @@ describe('PortfolioCalculator', () => {let redisCacheService: RedisCacheService;beforeEach(() => {+ PortfolioSnapshotServiceMock.reset();+ RedisCacheServiceMock.reset();+configurationService = new ConfigurationService();currentRateService = new CurrentRateService(null, null, null, null);diff --git a/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-msft-buy-and-sell.spec.ts b/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-msft-buy-and-sell.spec.tsindex b1f030aae4..53236f007f 100644--- a/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-msft-buy-and-sell.spec.ts+++ b/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-msft-buy-and-sell.spec.ts@@ -52,6 +52,9 @@ describe('PortfolioCalculator', () => {let redisCacheService: RedisCacheService;beforeEach(() => {+ PortfolioSnapshotServiceMock.reset();+ RedisCacheServiceMock.reset();+configurationService = new ConfigurationService();currentRateService = new CurrentRateService(null, null, null, null);exchangeRateDataService = new ExchangeRateDataService(diff --git a/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-msft-buy-with-dividend.spec.ts b/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-msft-buy-with-dividend.spec.tsindex 91c095623b..f6598f22b8 100644--- a/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-msft-buy-with-dividend.spec.ts+++ b/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-msft-buy-with-dividend.spec.ts@@ -54,6 +54,9 @@ describe('PortfolioCalculator', () => {let redisCacheService: RedisCacheService;beforeEach(() => {+ PortfolioSnapshotServiceMock.reset();+ RedisCacheServiceMock.reset();+configurationService = new ConfigurationService();currentRateService = new CurrentRateService(null, null, null, null);diff --git a/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-no-activities.spec.ts b/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-no-activities.spec.tsindex ff5dc93f9d..fb7a434771 100644--- a/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-no-activities.spec.ts+++ b/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-no-activities.spec.ts@@ -49,6 +49,9 @@ describe('PortfolioCalculator', () => {let redisCacheService: RedisCacheService;beforeEach(() => {+ PortfolioSnapshotServiceMock.reset();+ RedisCacheServiceMock.reset();+configurationService = new ConfigurationService();currentRateService = new CurrentRateService(null, null, null, null);diff --git a/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-novn-buy-and-sell-partially.spec.ts b/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-novn-buy-and-sell-partially.spec.tsindex 8ce62db598..8c3858dcd6 100644--- a/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-novn-buy-and-sell-partially.spec.ts+++ b/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-novn-buy-and-sell-partially.spec.ts@@ -67,6 +67,9 @@ describe('PortfolioCalculator', () => {});beforeEach(() => {+ PortfolioSnapshotServiceMock.reset();+ RedisCacheServiceMock.reset();+configurationService = new ConfigurationService();currentRateService = new CurrentRateService(null, null, null, null);diff --git a/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-novn-buy-and-sell.spec.ts b/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-novn-buy-and-sell.spec.tsindex 10cc2da01f..364d173e14 100644--- a/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-novn-buy-and-sell.spec.ts+++ b/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-novn-buy-and-sell.spec.ts@@ -67,6 +67,9 @@ describe('PortfolioCalculator', () => {});beforeEach(() => {+ PortfolioSnapshotServiceMock.reset();+ RedisCacheServiceMock.reset();+configurationService = new ConfigurationService();currentRateService = new CurrentRateService(null, null, null, null);diff --git a/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-valuable.spec.ts b/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-valuable.spec.tsindex 226eaa3d87..ce5f90f5c3 100644--- a/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-valuable.spec.ts+++ b/apps/api/src/app/portfolio/calculator/roai/portfolio-calculator-valuable.spec.ts@@ -54,6 +54,9 @@ describe('PortfolioCalculator', () => {let redisCacheService: RedisCacheService;beforeEach(() => {+ PortfolioSnapshotServiceMock.reset();+ RedisCacheServiceMock.reset();+configurationService = new ConfigurationService();currentRateService = new CurrentRateService(null, null, null, null);diff --git a/apps/api/src/app/portfolio/errors/portfolio-snapshot-computation.error.ts b/apps/api/src/app/portfolio/errors/portfolio-snapshot-computation.error.tsnew file mode 100644index 0000000000..074ac0bae7--- /dev/null+++ b/apps/api/src/app/portfolio/errors/portfolio-snapshot-computation.error.ts@@ -0,0 +1,7 @@+export class PortfolioSnapshotComputationError extends Error {+ public constructor(message: string) {+ super(message);++ this.name = 'PortfolioSnapshotComputationError';+ }+}diff --git a/apps/api/src/app/redis-cache/redis-cache.service.mock.ts b/apps/api/src/app/redis-cache/redis-cache.service.mock.tsindex feb669ab0b..2a3c1cc7af 100644--- a/apps/api/src/app/redis-cache/redis-cache.service.mock.ts+++ b/apps/api/src/app/redis-cache/redis-cache.service.mock.ts@@ -18,6 +18,9 @@ export const RedisCacheServiceMock = {return `portfolio-snapshot-${userId}${filtersHash > 0 ? `-${filtersHash}` : ''}`;},+ reset: () => {+ RedisCacheServiceMock.cache.clear();+ },set: (key: string, value: string): Promise<string> => {RedisCacheServiceMock.cache.set(key, value);diff --git a/apps/api/src/filters/portfolio-snapshot-computation-exception.filter.ts b/apps/api/src/filters/portfolio-snapshot-computation-exception.filter.tsnew file mode 100644index 0000000000..05471c3f60--- /dev/null+++ b/apps/api/src/filters/portfolio-snapshot-computation-exception.filter.ts@@ -0,0 +1,26 @@+import { PortfolioSnapshotComputationError } from '@ghostfolio/api/app/portfolio/errors/portfolio-snapshot-computation.error';++import { ArgumentsHost, Catch, ExceptionFilter, Logger } from '@nestjs/common';+import { Response } from 'express';+import { getReasonPhrase, StatusCodes } from 'http-status-codes';++@Catch(PortfolioSnapshotComputationError)+export class PortfolioSnapshotComputationExceptionFilter implements ExceptionFilter {+ private readonly logger = new Logger(+ PortfolioSnapshotComputationExceptionFilter.name+ );++ public catch(+ exception: PortfolioSnapshotComputationError,+ host: ArgumentsHost+ ) {+ this.logger.error(exception.message);++ const response = host.switchToHttp().getResponse<Response>();++ response.status(StatusCodes.SERVICE_UNAVAILABLE).json({+ message: getReasonPhrase(StatusCodes.SERVICE_UNAVAILABLE),+ statusCode: StatusCodes.SERVICE_UNAVAILABLE+ });+ }+}diff --git a/apps/api/src/services/queues/portfolio-snapshot/portfolio-snapshot.processor.ts b/apps/api/src/services/queues/portfolio-snapshot/portfolio-snapshot.processor.tsindex cf94a9d2b0..2ade39a8ac 100644--- a/apps/api/src/services/queues/portfolio-snapshot/portfolio-snapshot.processor.ts+++ b/apps/api/src/services/queues/portfolio-snapshot/portfolio-snapshot.processor.ts@@ -87,7 +87,7 @@ export class PortfolioSnapshotProcessor {: 0);- this.redisCacheService.set(+ await this.redisCacheService.set(this.redisCacheService.getPortfolioSnapshotKey({filters: job.data.filters,userId: job.data.userIddiff --git a/apps/api/src/services/queues/portfolio-snapshot/portfolio-snapshot.service.mock.ts b/apps/api/src/services/queues/portfolio-snapshot/portfolio-snapshot.service.mock.tsindex 7eb09d966f..fddbd01aba 100644--- a/apps/api/src/services/queues/portfolio-snapshot/portfolio-snapshot.service.mock.ts+++ b/apps/api/src/services/queues/portfolio-snapshot/portfolio-snapshot.service.mock.ts@@ -1,32 +1,47 @@+import { PortfolioSnapshotValue } from '@ghostfolio/api/app/portfolio/interfaces/snapshot-value.interface';+import { RedisCacheServiceMock } from '@ghostfolio/api/app/redis-cache/redis-cache.service.mock';+import type { Job, JobId, JobOptions } from 'bull';+import ms from 'ms';import { setTimeout } from 'timers/promises';import { PortfolioSnapshotQueueJob } from './interfaces/portfolio-snapshot-queue-job.interface';export const PortfolioSnapshotServiceMock = {- addJobToQueue({+ addJobToQueue: ({opts}: {data: PortfolioSnapshotQueueJob;name: string;opts?: JobOptions;- }): Promise<Job> {+ }): Promise<Job> => {const mockJob: Partial<Job> = {finished: async () => {await setTimeout(100);- return Promise.resolve();+ // Mimic the processor which caches the computed portfolio snapshot+ // under the job id+ await RedisCacheServiceMock.set(+ opts?.jobId as string,+ JSON.stringify({+ expiration: Date.now() + ms('1 minute'),+ portfolioSnapshot: {}+ } as unknown as PortfolioSnapshotValue)+ );}};- this.jobsStore.set(opts?.jobId, mockJob);+ PortfolioSnapshotServiceMock.jobsStore.set(opts?.jobId, mockJob);return Promise.resolve(mockJob as Job);},- getJob(jobId: JobId): Promise<Job> {- const job = this.jobsStore.get(jobId);+ getJob: (jobId: JobId): Promise<Job> => {+ const job = PortfolioSnapshotServiceMock.jobsStore.get(jobId);return Promise.resolve(job as Job);},- jobsStore: new Map<JobId, Partial<Job>>()+ jobsStore: new Map<JobId, Partial<Job>>(),+ reset: () => {+ PortfolioSnapshotServiceMock.jobsStore.clear();+ }};