Skip to content

Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍

Bugfix/add missing country mapping for Macau in Trackinsight data enhancer (#7651)

Thomas Kaul8292699afb68
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 1e49a4967b..b052e2d106 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -11,6 +11,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Upgraded `ng-extract-i18n-merge` from `3.3.0` to `3.4.0`
+### Fixed
+
+- Fixed the missing mapping for Macau in the data enhancer for asset profile data via _Trackinsight_
+
## 3.53.0 - 2026-08-16
### Changed
diff --git a/apps/api/src/helper/country.helper.ts b/apps/api/src/helper/country.helper.ts
index 2e6da5340f..119f5e44c1 100644
--- a/apps/api/src/helper/country.helper.ts
+++ b/apps/api/src/helper/country.helper.ts
@@ -3,9 +3,11 @@ import { countries } from 'countries-list';
export function getCountryCodeByName({
aliases = {},
+ dataSource,
name
}: {
aliases?: Record<string, string>;
+ dataSource?: string;
name: string;
}): string {
if (aliases[name]) {
@@ -21,7 +23,11 @@ export function getCountryCodeByName({
if (name && name.toLowerCase() !== 'other') {
const logger = new Logger('getCountryCodeByName');
- logger.warn(`Could not map the country "${name}" to a code`);
+ logger.warn(
+ `Could not map the country "${name}" to a code${
+ dataSource ? ` (${dataSource})` : ''
+ }`
+ );
}
return undefined;
diff --git a/apps/api/src/services/data-provider/data-enhancer/trackinsight/trackinsight.service.ts b/apps/api/src/services/data-provider/data-enhancer/trackinsight/trackinsight.service.ts
index 7f58448b77..23a8ce33cc 100644
--- a/apps/api/src/services/data-provider/data-enhancer/trackinsight/trackinsight.service.ts
+++ b/apps/api/src/services/data-provider/data-enhancer/trackinsight/trackinsight.service.ts
@@ -17,6 +17,7 @@ export class TrackinsightDataEnhancerService implements DataEnhancerInterface {
private static countriesMapping = {
'Czech Republic': 'CZ',
+ Macau: 'MO',
'Republic of Korea': 'KR',
'Russian Federation': 'RU',
Turkey: 'TR',
@@ -128,7 +129,8 @@ export class TrackinsightDataEnhancerService implements DataEnhancerInterface {
)) {
const code = getCountryCodeByName({
name,
- aliases: TrackinsightDataEnhancerService.countriesMapping
+ aliases: TrackinsightDataEnhancerService.countriesMapping,
+ dataSource: this.getName()
});
if (code) {
diff --git a/apps/api/src/services/data-provider/data-enhancer/yahoo-finance/yahoo-finance.service.ts b/apps/api/src/services/data-provider/data-enhancer/yahoo-finance/yahoo-finance.service.ts
index 77e83b2716..cd4a0436e5 100644
--- a/apps/api/src/services/data-provider/data-enhancer/yahoo-finance/yahoo-finance.service.ts
+++ b/apps/api/src/services/data-provider/data-enhancer/yahoo-finance/yahoo-finance.service.ts
@@ -254,6 +254,7 @@ export class YahooFinanceDataEnhancerService implements DataEnhancerInterface {
const code = getCountryCodeByName({
aliases: YahooFinanceDataEnhancerService.countriesMapping,
+ dataSource: this.getName(),
name: assetProfile.summaryProfile.country
});
diff --git a/apps/api/src/services/data-provider/financial-modeling-prep/financial-modeling-prep.service.ts b/apps/api/src/services/data-provider/financial-modeling-prep/financial-modeling-prep.service.ts
index 2fd1013965..c768de0706 100644
--- a/apps/api/src/services/data-provider/financial-modeling-prep/financial-modeling-prep.service.ts
+++ b/apps/api/src/services/data-provider/financial-modeling-prep/financial-modeling-prep.service.ts
@@ -175,6 +175,7 @@ export class FinancialModelingPrepService
return {
code: getCountryCodeByName({
aliases: FinancialModelingPrepService.countriesMapping,
+ dataSource: this.getName(),
name: countryName
}),
weight: parseFloat(`${weightPercentage}`) / 100