Skip to content

Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍

Bugfix/missing performance chart in presenter view (#3181)

Thomas Kaul87bf8df1c306
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 5ad7269793..c29fa3d372 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -18,6 +18,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Upgraded `angular` from version `17.1.3` to `17.2.4`
- Upgraded `Nx` from version `18.0.4` to `18.1.2`
+### Fixed
+
+- Fixed the missing portfolio performance chart in the _Presenter View_ / _Zen Mode_
+
## 2.65.0 - 2024-03-19
### Added
diff --git a/apps/api/src/app/portfolio/portfolio.controller.ts b/apps/api/src/app/portfolio/portfolio.controller.ts
index 80ea08fce4..e4580f1f3f 100644
--- a/apps/api/src/app/portfolio/portfolio.controller.ts
+++ b/apps/api/src/app/portfolio/portfolio.controller.ts
@@ -418,6 +418,7 @@ export class PortfolioController {
({
date,
netPerformanceInPercentage,
+ netPerformanceInPercentageWithCurrencyEffect,
netWorth,
totalInvestment,
value
@@ -425,6 +426,7 @@ export class PortfolioController {
return {
date,
netPerformanceInPercentage,
+ netPerformanceInPercentageWithCurrencyEffect,
netWorthInPercentage:
performanceInformation.performance.currentNetWorth === 0
? 0
diff --git a/apps/client/src/app/components/home-overview/home-overview.component.ts b/apps/client/src/app/components/home-overview/home-overview.component.ts
index 7beb322a24..75e1777499 100644
--- a/apps/client/src/app/components/home-overview/home-overview.component.ts
+++ b/apps/client/src/app/components/home-overview/home-overview.component.ts
@@ -124,7 +124,6 @@ export class HomeOverviewComponent implements OnDestroy, OnInit {
.subscribe(({ chart, errors, performance }) => {
this.errors = errors;
this.performance = performance;
- this.isLoadingPerformance = false;
this.historicalDataItems = chart.map(
({ date, netPerformanceInPercentageWithCurrencyEffect }) => {
@@ -135,6 +134,8 @@ export class HomeOverviewComponent implements OnDestroy, OnInit {
}
);
+ this.isLoadingPerformance = false;
+
this.changeDetectorRef.markForCheck();
});