Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍
TypeScript angularetffinancefintechghostfoliohacktoberfestinvestingnestjsosspersonal-financeportfolioprismasoftwarestocktrackertradingtypescriptwealth-managementweb
Task/eliminate OnDestroy hook from ZEN page (#6452)
DmytroSkachko8b187c96b567
diff --git a/apps/client/src/app/pages/zen/zen-page.component.ts b/apps/client/src/app/pages/zen/zen-page.component.tsindex 280f33c251..633f158852 100644--- a/apps/client/src/app/pages/zen/zen-page.component.ts+++ b/apps/client/src/app/pages/zen/zen-page.component.ts@@ -2,15 +2,19 @@ import { UserService } from '@ghostfolio/client/services/user/user.service';import { TabConfiguration, User } from '@ghostfolio/common/interfaces';import { internalRoutes } from '@ghostfolio/common/routes/routes';-import { ChangeDetectorRef, Component, OnDestroy, OnInit } from '@angular/core';+import {+ ChangeDetectorRef,+ Component,+ DestroyRef,+ OnInit+} from '@angular/core';+import { takeUntilDestroyed } from '@angular/core/rxjs-interop';import { MatTabsModule } from '@angular/material/tabs';import { RouterModule } from '@angular/router';import { IonIcon } from '@ionic/angular/standalone';import { addIcons } from 'ionicons';import { albumsOutline, analyticsOutline } from 'ionicons/icons';import { DeviceDetectorService } from 'ngx-device-detector';-import { Subject } from 'rxjs';-import { takeUntil } from 'rxjs/operators';@Component({host: { class: 'page has-tabs' },@@ -19,20 +23,19 @@ import { takeUntil } from 'rxjs/operators';styleUrls: ['./zen-page.scss'],templateUrl: './zen-page.html'})-export class GfZenPageComponent implements OnDestroy, OnInit {+export class GfZenPageComponent implements OnInit {public deviceType: string;public tabs: TabConfiguration[] = [];public user: User;- private unsubscribeSubject = new Subject<void>();-public constructor(private changeDetectorRef: ChangeDetectorRef,+ private destroyRef: DestroyRef,private deviceService: DeviceDetectorService,private userService: UserService) {this.userService.stateChanged- .pipe(takeUntil(this.unsubscribeSubject))+ .pipe(takeUntilDestroyed(this.destroyRef)).subscribe((state) => {if (state?.user) {this.tabs = [@@ -59,9 +62,4 @@ export class GfZenPageComponent implements OnDestroy, OnInit {public ngOnInit() {this.deviceType = this.deviceService.getDeviceInfo().deviceType;}-- public ngOnDestroy() {- this.unsubscribeSubject.next();- this.unsubscribeSubject.complete();- }}