Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍
TypeScript angularetffinancefintechghostfoliohacktoberfestinvestingnestjsosspersonal-financeportfolioprismasoftwarestocktrackertradingtypescriptwealth-managementweb
Task/remove deprecated committed funds from summary of portfolio details (#6442)
Thomas Kaul8e47e198fa92
diff --git a/CHANGELOG.md b/CHANGELOG.mdindex d7ebb665ca..ddcb68ad80 100644--- a/CHANGELOG.md+++ b/CHANGELOG.md@@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0### Changed+- Removed the deprecated `committedFunds` from the summary of the portfolio details endpoint- Upgraded `Nx` from version `22.4.5` to `22.5.3`## 2.245.0 - 2026-03-01diff --git a/apps/api/src/app/portfolio/portfolio.controller.ts b/apps/api/src/app/portfolio/portfolio.controller.tsindex 5ed3c00093..67b5229c1d 100644--- a/apps/api/src/app/portfolio/portfolio.controller.ts+++ b/apps/api/src/app/portfolio/portfolio.controller.ts@@ -187,7 +187,6 @@ export class PortfolioController {portfolioSummary = nullifyValuesInObject(summary, ['cash',- 'committedFunds','currentNetWorth','currentValueInBaseCurrency','dividendInBaseCurrency',diff --git a/apps/api/src/app/portfolio/portfolio.service.ts b/apps/api/src/app/portfolio/portfolio.service.tsindex 17bd01ce48..26d16bf757 100644--- a/apps/api/src/app/portfolio/portfolio.service.ts+++ b/apps/api/src/app/portfolio/portfolio.service.ts@@ -1914,8 +1914,6 @@ export class PortfolioService {.plus(emergencyFundHoldingsValueInBaseCurrency).toNumber();- const committedFunds = new Big(totalBuy).minus(totalSell);-const totalOfExcludedActivities = this.getSumOfActivityType({userCurrency,activities: excludedActivities,@@ -1979,7 +1977,6 @@ export class PortfolioService {activityCount: activities.filter(({ type }) => {return ['BUY', 'SELL'].includes(type);}).length,- committedFunds: committedFunds.toNumber(),currentValueInBaseCurrency: currentValueInBaseCurrency.toNumber(),dividendInBaseCurrency: dividendInBaseCurrency.toNumber(),emergencyFund: {diff --git a/apps/api/src/helper/object.helper.spec.ts b/apps/api/src/helper/object.helper.spec.tsindex eed261f3eb..ba8760c70c 100644--- a/apps/api/src/helper/object.helper.spec.ts+++ b/apps/api/src/helper/object.helper.spec.ts@@ -1540,7 +1540,6 @@ describe('redactAttributes', () => {netPerformanceWithCurrencyEffect: null,totalBuy: null,totalSell: null,- committedFunds: null,currentValueInBaseCurrency: null,dividendInBaseCurrency: null,emergencyFund: null,@@ -3017,7 +3016,6 @@ describe('redactAttributes', () => {netPerformanceWithCurrencyEffect: null,totalBuy: null,totalSell: null,- committedFunds: null,currentValueInBaseCurrency: null,dividendInBaseCurrency: null,emergencyFund: null,diff --git a/libs/common/src/lib/interfaces/portfolio-summary.interface.ts b/libs/common/src/lib/interfaces/portfolio-summary.interface.tsindex 79fbf8707d..8db6b39bba 100644--- a/libs/common/src/lib/interfaces/portfolio-summary.interface.ts+++ b/libs/common/src/lib/interfaces/portfolio-summary.interface.ts@@ -6,10 +6,6 @@ export interface PortfolioSummary extends PortfolioPerformance {annualizedPerformancePercent: number;annualizedPerformancePercentWithCurrencyEffect: number;cash: number;-- /** @deprecated use totalInvestmentValueWithCurrencyEffect instead */- committedFunds: number;-dateOfFirstActivity: Date;dividendInBaseCurrency: number;emergencyFund: {