Skip to content

Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍

Task/widen input types in world map and top holdings components (#8017)

Kenrick Tandrian933df54b98d1
diff --git a/libs/ui/src/lib/top-holdings/top-holdings.component.ts b/libs/ui/src/lib/top-holdings/top-holdings.component.ts
index 1a675a5531..80caca9185 100644
--- a/libs/ui/src/lib/top-holdings/top-holdings.component.ts
+++ b/libs/ui/src/lib/top-holdings/top-holdings.component.ts
@@ -38,11 +38,11 @@ import { GfValueComponent } from '../value/value.component';
templateUrl: './top-holdings.component.html'
})
export class GfTopHoldingsComponent implements OnChanges {
- @Input() baseCurrency: string;
- @Input() hasPermissionToShowValues = true;
- @Input() locale = getLocale();
- @Input() pageSize = Number.MAX_SAFE_INTEGER;
- @Input() topHoldings: HoldingWithParents[];
+ @Input() public baseCurrency?: string;
+ @Input() public hasPermissionToShowValues = true;
+ @Input() public locale?: string = getLocale();
+ @Input() public pageSize = Number.MAX_SAFE_INTEGER;
+ @Input() public topHoldings?: HoldingWithParents[];
@Output() holdingClicked = new EventEmitter<AssetProfileIdentifier>();
diff --git a/libs/ui/src/lib/world-map-chart/world-map-chart.component.ts b/libs/ui/src/lib/world-map-chart/world-map-chart.component.ts
index 899441b7be..29c66267a1 100644
--- a/libs/ui/src/lib/world-map-chart/world-map-chart.component.ts
+++ b/libs/ui/src/lib/world-map-chart/world-map-chart.component.ts
@@ -23,10 +23,12 @@ import svgMap from 'svgmap';
templateUrl: './world-map-chart.component.html'
})
export class GfWorldMapChartComponent implements OnChanges, OnDestroy {
- @Input() countries: { [code: string]: { name?: string; value: number } };
- @Input() format: string;
- @Input() isInPercentage = false;
- @Input() locale = getLocale();
+ @Input() public countries: {
+ [code: string]: { name?: string; value: number };
+ };
+ @Input() public format: string;
+ @Input() public isInPercentage?: boolean = false;
+ @Input() public locale?: string = getLocale();
public isLoading = true;
public svgMapElement: any;