Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍
TypeScript angularetffinancefintechghostfoliohacktoberfestinvestingnestjsosspersonal-financeportfolioprismasoftwarestocktrackertradingtypescriptwealth-managementweb
Feature/skip data enhancement if data is inaccurate (#935)
Thomas Kaul977c5a954456
diff --git a/CHANGELOG.md b/CHANGELOG.mdindex a3596cc81e..0723c83a9a 100644--- a/CHANGELOG.md+++ b/CHANGELOG.md@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).+## Unreleased++### Changed++- Skipped data enhancer (_Trackinsight_) if data is inaccurate+## 1.149.0 - 16.05.2022### Addeddiff --git a/apps/api/src/services/data-provider/data-enhancer/trackinsight/trackinsight.service.ts b/apps/api/src/services/data-provider/data-enhancer/trackinsight/trackinsight.service.tsindex f612973682..8ebdb1dbaf 100644--- a/apps/api/src/services/data-provider/data-enhancer/trackinsight/trackinsight.service.ts+++ b/apps/api/src/services/data-provider/data-enhancer/trackinsight/trackinsight.service.ts@@ -32,7 +32,7 @@ export class TrackinsightDataEnhancerService implements DataEnhancerInterface {return response;}- const holdings = await getJSON(+ const result = await getJSON(`${TrackinsightDataEnhancerService.baseUrl}/${symbol}.json`).catch(() => {return getJSON(@@ -42,12 +42,17 @@ export class TrackinsightDataEnhancerService implements DataEnhancerInterface {);});+ if (result.weight < 0.95) {+ // Skip if data is inaccurate+ return response;+ }+if (!response.countries ||(response.countries as unknown as Country[]).length === 0) {response.countries = [];- for (const [name, value] of Object.entries<any>(holdings.countries)) {+ for (const [name, value] of Object.entries<any>(result.countries)) {let countryCode: string;for (const [key, country] of Object.entries<any>(@@ -75,7 +80,7 @@ export class TrackinsightDataEnhancerService implements DataEnhancerInterface {(response.sectors as unknown as Sector[]).length === 0) {response.sectors = [];- for (const [name, value] of Object.entries<any>(holdings.sectors)) {+ for (const [name, value] of Object.entries<any>(result.sectors)) {response.sectors.push({name: TrackinsightDataEnhancerService.sectorsMapping[name] ?? name,weight: value.weight