Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍
TypeScript angularetffinancefintechghostfoliohacktoberfestinvestingnestjsosspersonal-financeportfolioprismasoftwarestocktrackertradingtypescriptwealth-managementweb
Refactor params to object (#2987)
Thomas Kaul9acdb41aa290
diff --git a/apps/api/src/services/data-provider/alpha-vantage/alpha-vantage.service.ts b/apps/api/src/services/data-provider/alpha-vantage/alpha-vantage.service.tsindex ab89230358..08dc48e57b 100644--- a/apps/api/src/services/data-provider/alpha-vantage/alpha-vantage.service.ts+++ b/apps/api/src/services/data-provider/alpha-vantage/alpha-vantage.service.ts@@ -37,12 +37,14 @@ export class AlphaVantageService implements DataProviderInterface {return !!this.configurationService.get('API_KEY_ALPHA_VANTAGE');}- public async getAssetProfile(- aSymbol: string- ): Promise<Partial<SymbolProfile>> {+ public async getAssetProfile({+ symbol+ }: {+ symbol: string;+ }): Promise<Partial<SymbolProfile>> {return {- dataSource: this.getName(),- symbol: aSymbol+ symbol,+ dataSource: this.getName()};}diff --git a/apps/api/src/services/data-provider/coingecko/coingecko.service.ts b/apps/api/src/services/data-provider/coingecko/coingecko.service.tsindex b05ffc02be..d17ba4b7e3 100644--- a/apps/api/src/services/data-provider/coingecko/coingecko.service.ts+++ b/apps/api/src/services/data-provider/coingecko/coingecko.service.ts@@ -52,15 +52,17 @@ export class CoinGeckoService implements DataProviderInterface {return true;}- public async getAssetProfile(- aSymbol: string- ): Promise<Partial<SymbolProfile>> {+ public async getAssetProfile({+ symbol+ }: {+ symbol: string;+ }): Promise<Partial<SymbolProfile>> {const response: Partial<SymbolProfile> = {+ symbol,assetClass: AssetClass.CASH,assetSubClass: AssetSubClass.CRYPTOCURRENCY,currency: DEFAULT_CURRENCY,- dataSource: this.getName(),- symbol: aSymbol+ dataSource: this.getName()};try {@@ -70,7 +72,7 @@ export class CoinGeckoService implements DataProviderInterface {abortController.abort();}, this.configurationService.get('REQUEST_TIMEOUT'));- const { name } = await got(`${this.apiUrl}/coins/${aSymbol}`, {+ const { name } = await got(`${this.apiUrl}/coins/${symbol}`, {headers: this.headers,// @ts-ignoresignal: abortController.signal@@ -81,7 +83,7 @@ export class CoinGeckoService implements DataProviderInterface {let message = error;if (error?.code === 'ABORT_ERR') {- message = `RequestError: The operation to get the asset profile for ${aSymbol} was aborted because the request to the data provider took more than ${this.configurationService.get(+ message = `RequestError: The operation to get the asset profile for ${symbol} was aborted because the request to the data provider took more than ${this.configurationService.get('REQUEST_TIMEOUT')}ms`;}diff --git a/apps/api/src/services/data-provider/data-provider.service.ts b/apps/api/src/services/data-provider/data-provider.service.tsindex 127af3f0d1..1b52ca3741 100644--- a/apps/api/src/services/data-provider/data-provider.service.ts+++ b/apps/api/src/services/data-provider/data-provider.service.ts@@ -92,7 +92,9 @@ export class DataProviderService {for (const symbol of symbols) {const promise = Promise.resolve(- this.getDataProvider(DataSource[dataSource]).getAssetProfile(symbol)+ this.getDataProvider(DataSource[dataSource]).getAssetProfile({+ symbol+ }));promises.push(diff --git a/apps/api/src/services/data-provider/eod-historical-data/eod-historical-data.service.ts b/apps/api/src/services/data-provider/eod-historical-data/eod-historical-data.service.tsindex 798973be6c..af67d62e94 100644--- a/apps/api/src/services/data-provider/eod-historical-data/eod-historical-data.service.ts+++ b/apps/api/src/services/data-provider/eod-historical-data/eod-historical-data.service.ts@@ -46,19 +46,21 @@ export class EodHistoricalDataService implements DataProviderInterface {return true;}- public async getAssetProfile(- aSymbol: string- ): Promise<Partial<SymbolProfile>> {- const [searchResult] = await this.getSearchResult(aSymbol);+ public async getAssetProfile({+ symbol+ }: {+ symbol: string;+ }): Promise<Partial<SymbolProfile>> {+ const [searchResult] = await this.getSearchResult(symbol);return {+ symbol,assetClass: searchResult?.assetClass,assetSubClass: searchResult?.assetSubClass,currency: this.convertCurrency(searchResult?.currency),dataSource: this.getName(),isin: searchResult?.isin,- name: searchResult?.name,- symbol: aSymbol+ name: searchResult?.name};}diff --git a/apps/api/src/services/data-provider/financial-modeling-prep/financial-modeling-prep.service.ts b/apps/api/src/services/data-provider/financial-modeling-prep/financial-modeling-prep.service.tsindex dcc2d3ae05..2faaf8db88 100644--- a/apps/api/src/services/data-provider/financial-modeling-prep/financial-modeling-prep.service.ts+++ b/apps/api/src/services/data-provider/financial-modeling-prep/financial-modeling-prep.service.ts@@ -37,12 +37,14 @@ export class FinancialModelingPrepService implements DataProviderInterface {return true;}- public async getAssetProfile(- aSymbol: string- ): Promise<Partial<SymbolProfile>> {+ public async getAssetProfile({+ symbol+ }: {+ symbol: string;+ }): Promise<Partial<SymbolProfile>> {return {- dataSource: this.getName(),- symbol: aSymbol+ symbol,+ dataSource: this.getName()};}diff --git a/apps/api/src/services/data-provider/google-sheets/google-sheets.service.ts b/apps/api/src/services/data-provider/google-sheets/google-sheets.service.tsindex 9029e38f03..68e8bf7322 100644--- a/apps/api/src/services/data-provider/google-sheets/google-sheets.service.ts+++ b/apps/api/src/services/data-provider/google-sheets/google-sheets.service.ts@@ -33,12 +33,14 @@ export class GoogleSheetsService implements DataProviderInterface {return true;}- public async getAssetProfile(- aSymbol: string- ): Promise<Partial<SymbolProfile>> {+ public async getAssetProfile({+ symbol+ }: {+ symbol: string;+ }): Promise<Partial<SymbolProfile>> {return {- dataSource: this.getName(),- symbol: aSymbol+ symbol,+ dataSource: this.getName()};}diff --git a/apps/api/src/services/data-provider/interfaces/data-provider.interface.ts b/apps/api/src/services/data-provider/interfaces/data-provider.interface.tsindex 07fca64bd7..3b36444732 100644--- a/apps/api/src/services/data-provider/interfaces/data-provider.interface.ts+++ b/apps/api/src/services/data-provider/interfaces/data-provider.interface.ts@@ -11,7 +11,11 @@ import { DataSource, SymbolProfile } from '@prisma/client';export interface DataProviderInterface {canHandle(symbol: string): boolean;- getAssetProfile(aSymbol: string): Promise<Partial<SymbolProfile>>;+ getAssetProfile({+ symbol+ }: {+ symbol: string;+ }): Promise<Partial<SymbolProfile>>;getDataProviderInfo(): DataProviderInfo;diff --git a/apps/api/src/services/data-provider/manual/manual.service.ts b/apps/api/src/services/data-provider/manual/manual.service.tsindex 2ac293384c..bc76645eb9 100644--- a/apps/api/src/services/data-provider/manual/manual.service.ts+++ b/apps/api/src/services/data-provider/manual/manual.service.ts@@ -43,16 +43,18 @@ export class ManualService implements DataProviderInterface {return true;}- public async getAssetProfile(- aSymbol: string- ): Promise<Partial<SymbolProfile>> {+ public async getAssetProfile({+ symbol+ }: {+ symbol: string;+ }): Promise<Partial<SymbolProfile>> {const assetProfile: Partial<SymbolProfile> = {- dataSource: this.getName(),- symbol: aSymbol+ symbol,+ dataSource: this.getName()};const [symbolProfile] = await this.symbolProfileService.getSymbolProfiles([- { dataSource: this.getName(), symbol: aSymbol }+ { symbol, dataSource: this.getName() }]);if (symbolProfile) {diff --git a/apps/api/src/services/data-provider/rapid-api/rapid-api.service.ts b/apps/api/src/services/data-provider/rapid-api/rapid-api.service.tsindex fd34abb924..e55fbd4e2c 100644--- a/apps/api/src/services/data-provider/rapid-api/rapid-api.service.ts+++ b/apps/api/src/services/data-provider/rapid-api/rapid-api.service.ts@@ -30,12 +30,14 @@ export class RapidApiService implements DataProviderInterface {return !!this.configurationService.get('API_KEY_RAPID_API');}- public async getAssetProfile(- aSymbol: string- ): Promise<Partial<SymbolProfile>> {+ public async getAssetProfile({+ symbol+ }: {+ symbol: string;+ }): Promise<Partial<SymbolProfile>> {return {- dataSource: this.getName(),- symbol: aSymbol+ symbol,+ dataSource: this.getName()};}diff --git a/apps/api/src/services/data-provider/yahoo-finance/yahoo-finance.service.ts b/apps/api/src/services/data-provider/yahoo-finance/yahoo-finance.service.tsindex 645ec133e1..b6148d4319 100644--- a/apps/api/src/services/data-provider/yahoo-finance/yahoo-finance.service.ts+++ b/apps/api/src/services/data-provider/yahoo-finance/yahoo-finance.service.ts@@ -33,11 +33,13 @@ export class YahooFinanceService implements DataProviderInterface {return true;}- public async getAssetProfile(- aSymbol: string- ): Promise<Partial<SymbolProfile>> {- const { assetClass, assetSubClass, currency, name, symbol } =- await this.yahooFinanceDataEnhancerService.getAssetProfile(aSymbol);+ public async getAssetProfile({+ symbol+ }: {+ symbol: string;+ }): Promise<Partial<SymbolProfile>> {+ const { assetClass, assetSubClass, currency, name } =+ await this.yahooFinanceDataEnhancerService.getAssetProfile(symbol);return {assetClass,