Skip to content

Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍

Feature/improve usability of create or update access dialog (#3791)

Thomas Kaul9b07b195233f
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 1ae53a5fc5..1868c050ff 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -13,6 +13,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed
+- Improved the usability of the create or update access dialog
- Improved the loading indicator of the accounts table
- Improved the language localization for German (`de`)
- Improved the language localization for Polish (`pl`)
diff --git a/apps/client/src/app/components/user-account-access/create-or-update-access-dialog/create-or-update-access-dialog.component.ts b/apps/client/src/app/components/user-account-access/create-or-update-access-dialog/create-or-update-access-dialog.component.ts
index dd755a8b92..5bb6ca3e50 100644
--- a/apps/client/src/app/components/user-account-access/create-or-update-access-dialog/create-or-update-access-dialog.component.ts
+++ b/apps/client/src/app/components/user-account-access/create-or-update-access-dialog/create-or-update-access-dialog.component.ts
@@ -52,13 +52,12 @@ export class CreateOrUpdateAccessDialog implements OnDestroy {
if (accessType === 'PRIVATE') {
granteeUserIdControl.setValidators(Validators.required);
- permissionsControl.setValidators(Validators.required);
} else {
granteeUserIdControl.clearValidators();
+ permissionsControl.setValue(this.data.access.permissions[0]);
}
granteeUserIdControl.updateValueAndValidity();
- permissionsControl.updateValueAndValidity();
this.changeDetectorRef.markForCheck();
});
diff --git a/apps/client/src/app/components/user-account-access/create-or-update-access-dialog/create-or-update-access-dialog.html b/apps/client/src/app/components/user-account-access/create-or-update-access-dialog/create-or-update-access-dialog.html
index 9510797176..b903c64d59 100644
--- a/apps/client/src/app/components/user-account-access/create-or-update-access-dialog/create-or-update-access-dialog.html
+++ b/apps/client/src/app/components/user-account-access/create-or-update-access-dialog/create-or-update-access-dialog.html
@@ -27,18 +27,18 @@
</mat-form-field>
</div>
- @if (accessForm.get('type').value === 'PRIVATE') {
- <div>
- <mat-form-field appearance="outline" class="w-100">
- <mat-label i18n>Permission</mat-label>
- <mat-select formControlName="permissions">
- <mat-option i18n value="READ_RESTRICTED"
- >Restricted view</mat-option
- >
+ <div>
+ <mat-form-field appearance="outline" class="w-100">
+ <mat-label i18n>Permission</mat-label>
+ <mat-select formControlName="permissions">
+ <mat-option i18n value="READ_RESTRICTED">Restricted view</mat-option>
+ @if (accessForm.get('type').value === 'PRIVATE') {
<mat-option i18n value="READ">View</mat-option>
- </mat-select>
- </mat-form-field>
- </div>
+ }
+ </mat-select>
+ </mat-form-field>
+ </div>
+ @if (accessForm.get('type').value === 'PRIVATE') {
<div>
<mat-form-field appearance="outline" class="w-100">
<mat-label>
diff --git a/apps/client/src/app/components/user-account-access/user-account-access.component.ts b/apps/client/src/app/components/user-account-access/user-account-access.component.ts
index d36c31632a..2a44524853 100644
--- a/apps/client/src/app/components/user-account-access/user-account-access.component.ts
+++ b/apps/client/src/app/components/user-account-access/user-account-access.component.ts
@@ -111,7 +111,7 @@ export class UserAccountAccessComponent implements OnDestroy, OnInit {
type: 'PRIVATE'
}
},
- height: this.deviceType === 'mobile' ? '97.5vh' : '80vh',
+ height: this.deviceType === 'mobile' ? '97.5vh' : undefined,
width: this.deviceType === 'mobile' ? '100vw' : '50rem'
});