Skip to content

Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍

Feature/ignore first item in portfolio evolution chart (#1816)

Thomas Kaul9bef2e960c41
diff --git a/CHANGELOG.md b/CHANGELOG.md
index cbaffbf5d2..e1442d3bfd 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
+## Unreleased
+
+### Changed
+
+- Improved the portfolio evolution chart (ignore first item)
+
## 1.249.0 - 2023-03-27
### Added
diff --git a/apps/client/src/app/pages/portfolio/analysis/analysis-page.component.ts b/apps/client/src/app/pages/portfolio/analysis/analysis-page.component.ts
index ae60a5e2ac..74371da9df 100644
--- a/apps/client/src/app/pages/portfolio/analysis/analysis-page.component.ts
+++ b/apps/client/src/app/pages/portfolio/analysis/analysis-page.component.ts
@@ -308,18 +308,24 @@ export class AnalysisPageComponent implements OnDestroy, OnInit {
this.performanceDataItems = [];
this.performanceDataItemsInPercentage = [];
- for (const {
- date,
- netPerformanceInPercentage,
- totalInvestment,
- value,
- valueInPercentage
- } of chart) {
- this.investments.push({ date, investment: totalInvestment });
- this.performanceDataItems.push({
+ for (const [
+ index,
+ {
date,
- value: isNumber(value) ? value : valueInPercentage
- });
+ netPerformanceInPercentage,
+ totalInvestment,
+ value,
+ valueInPercentage
+ }
+ ] of chart.entries()) {
+ if (index > 0 || this.user?.settings?.dateRange === 'max') {
+ // Ignore first item where value is 0
+ this.investments.push({ date, investment: totalInvestment });
+ this.performanceDataItems.push({
+ date,
+ value: isNumber(value) ? value : valueInPercentage
+ });
+ }
this.performanceDataItemsInPercentage.push({
date,
value: netPerformanceInPercentage