Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍
TypeScript angularetffinancefintechghostfoliohacktoberfestinvestingnestjsosspersonal-financeportfolioprismasoftwarestocktrackertradingtypescriptwealth-managementweb
Fix date conversion in import of historical market data (#3117)
helgehatta0ddd1f9b991
diff --git a/CHANGELOG.md b/CHANGELOG.mdindex 6f1c07500b..f60fcdf267 100644--- a/CHANGELOG.md+++ b/CHANGELOG.md@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).+## Unreleased++### Fixed++- Fixed the date conversion of the import of historical market data in the admin control panel+## 2.63.2 - 2024-03-12### Addeddiff --git a/apps/client/src/app/components/admin-market-data-detail/admin-market-data-detail.component.ts b/apps/client/src/app/components/admin-market-data-detail/admin-market-data-detail.component.tsindex 5a2ec5265f..26da886e77 100644--- a/apps/client/src/app/components/admin-market-data-detail/admin-market-data-detail.component.ts+++ b/apps/client/src/app/components/admin-market-data-detail/admin-market-data-detail.component.ts@@ -155,15 +155,14 @@ export class AdminMarketDataDetailComponent implements OnChanges, OnInit {day: string;yearMonth: string;}) {- const date = parseISO(`${yearMonth}-${day}`);const marketPrice = this.marketDataByMonth[yearMonth]?.[day]?.marketPrice;const dialogRef = this.dialog.open(MarketDataDetailDialog, {data: <MarketDataDetailDialogParams>{- date,marketPrice,currency: this.currency,dataSource: this.dataSource,+ dateString: `${yearMonth}-${day}`,symbol: this.symbol,user: this.user},diff --git a/apps/client/src/app/components/admin-market-data-detail/market-data-detail-dialog/interfaces/interfaces.ts b/apps/client/src/app/components/admin-market-data-detail/market-data-detail-dialog/interfaces/interfaces.tsindex 8f5447f9c2..81188cd1f7 100644--- a/apps/client/src/app/components/admin-market-data-detail/market-data-detail-dialog/interfaces/interfaces.ts+++ b/apps/client/src/app/components/admin-market-data-detail/market-data-detail-dialog/interfaces/interfaces.ts@@ -5,7 +5,7 @@ import { DataSource } from '@prisma/client';export interface MarketDataDetailDialogParams {currency: string;dataSource: DataSource;- date: Date;+ dateString: string;marketPrice: number;symbol: string;user: User;diff --git a/apps/client/src/app/components/admin-market-data-detail/market-data-detail-dialog/market-data-detail-dialog.component.ts b/apps/client/src/app/components/admin-market-data-detail/market-data-detail-dialog/market-data-detail-dialog.component.tsindex df8ac6067e..6a44d0dfb7 100644--- a/apps/client/src/app/components/admin-market-data-detail/market-data-detail-dialog/market-data-detail-dialog.component.ts+++ b/apps/client/src/app/components/admin-market-data-detail/market-data-detail-dialog/market-data-detail-dialog.component.ts@@ -45,7 +45,7 @@ export class MarketDataDetailDialog implements OnDestroy {this.adminService.fetchSymbolForDate({dataSource: this.data.dataSource,- date: this.data.date,+ dateString: this.data.dateString,symbol: this.data.symbol}).pipe(takeUntil(this.unsubscribeSubject))@@ -63,7 +63,7 @@ export class MarketDataDetailDialog implements OnDestroy {marketData: {marketData: [{- date: this.data.date.toISOString(),+ date: this.data.dateString,marketPrice: this.data.marketPrice}]diff --git a/apps/client/src/app/components/admin-market-data-detail/market-data-detail-dialog/market-data-detail-dialog.html b/apps/client/src/app/components/admin-market-data-detail/market-data-detail-dialog/market-data-detail-dialog.htmlindex 5e16fc702e..8e7e306497 100644--- a/apps/client/src/app/components/admin-market-data-detail/market-data-detail-dialog/market-data-detail-dialog.html+++ b/apps/client/src/app/components/admin-market-data-detail/market-data-detail-dialog/market-data-detail-dialog.html@@ -9,7 +9,7 @@matInputname="date"[matDatepicker]="date"- [(ngModel)]="data.date"+ [(ngModel)]="data.dateString"/><mat-datepicker-toggle class="mr-2" matSuffix [for]="date"><ion-icondiff --git a/apps/client/src/app/components/admin-market-data/asset-profile-dialog/asset-profile-dialog.component.ts b/apps/client/src/app/components/admin-market-data/asset-profile-dialog/asset-profile-dialog.component.tsindex f0e9abf437..9157476f06 100644--- a/apps/client/src/app/components/admin-market-data/asset-profile-dialog/asset-profile-dialog.component.ts+++ b/apps/client/src/app/components/admin-market-data/asset-profile-dialog/asset-profile-dialog.component.ts@@ -1,4 +1,5 @@import { UpdateAssetProfileDto } from '@ghostfolio/api/app/admin/update-asset-profile.dto';+import { UpdateMarketDataDto } from '@ghostfolio/api/app/admin/update-market-data.dto';import { AdminService } from '@ghostfolio/client/services/admin.service';import { DataService } from '@ghostfolio/client/services/data.service';import { DATE_FORMAT, parseDate } from '@ghostfolio/common/helper';@@ -195,15 +196,13 @@ export class AssetProfileDialog implements OnDestroy, OnInit {header: true,skipEmptyLines: true}- ).data;+ ).data as UpdateMarketDataDto[];this.adminService.postMarketData({dataSource: this.data.dataSource,marketData: {- marketData: marketData.map(({ date, marketPrice }) => {- return { marketPrice, date: parseDate(date).toISOString() };- })+ marketData},symbol: this.data.symbol})diff --git a/apps/client/src/app/services/admin.service.ts b/apps/client/src/app/services/admin.service.tsindex 7d204c607b..c850527a89 100644--- a/apps/client/src/app/services/admin.service.ts+++ b/apps/client/src/app/services/admin.service.ts@@ -188,17 +188,14 @@ export class AdminService {public fetchSymbolForDate({dataSource,- date,+ dateString,symbol}: {dataSource: DataSource;- date: Date;+ dateString: string;symbol: string;}) {- const url = `/api/v1/symbol/${dataSource}/${symbol}/${format(- date,- DATE_FORMAT- )}`;+ const url = `/api/v1/symbol/${dataSource}/${symbol}/${dateString}`;return this.http.get<IDataProviderHistoricalResponse>(url);}