Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍
TypeScript angularetffinancefintechghostfoliohacktoberfestinvestingnestjsosspersonal-financeportfolioprismasoftwarestocktrackertradingtypescriptwealth-managementweb
Bugfix/countries in FMP service (#6005)
Thomas Kaula2498a54a6ac
diff --git a/CHANGELOG.md b/CHANGELOG.mdindex cb145bb14a..f60d2434c0 100644--- a/CHANGELOG.md+++ b/CHANGELOG.md@@ -11,6 +11,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0- Extended the _Storybook_ stories of the portfolio proportion chart component by a story using percentage values+### Fixed++- Improved the country weightings in the _Financial Modeling Prep_ service+## 2.220.0 - 2025-11-29### Changeddiff --git a/apps/api/src/services/data-provider/financial-modeling-prep/financial-modeling-prep.service.ts b/apps/api/src/services/data-provider/financial-modeling-prep/financial-modeling-prep.service.tsindex 6fe928d7ab..fe8c4ecd63 100644--- a/apps/api/src/services/data-provider/financial-modeling-prep/financial-modeling-prep.service.ts+++ b/apps/api/src/services/data-provider/financial-modeling-prep/financial-modeling-prep.service.ts@@ -44,6 +44,12 @@ import {@Injectable()export class FinancialModelingPrepService implements DataProviderInterface {+ private static countriesMapping = {+ 'Korea (the Republic of)': 'South Korea',+ 'Russian Federation': 'Russia',+ 'Taiwan (Province of China)': 'Taiwan'+ };+private apiKey: string;public constructor(@@ -121,12 +127,19 @@ export class FinancialModelingPrepService implements DataProviderInterface {}).then((res) => res.json());- response.countries = etfCountryWeightings.map(- ({ country: countryName, weightPercentage }) => {+ response.countries = etfCountryWeightings+ .filter(({ country: countryName }) => {+ return countryName.toLowerCase() !== 'other';+ })+ .map(({ country: countryName, weightPercentage }) => {let countryCode: string;for (const [code, country] of Object.entries(countries)) {- if (country.name === countryName) {+ if (+ country.name === countryName ||+ country.name ===+ FinancialModelingPrepService.countriesMapping[countryName]+ ) {countryCode = code;break;}@@ -136,8 +149,7 @@ export class FinancialModelingPrepService implements DataProviderInterface {code: countryCode,weight: parseFloat(weightPercentage.slice(0, -1)) / 100};- }- );+ });const etfHoldings = await fetch(`${this.getUrl({ version: 'stable' })}/etf/holdings?symbol=${symbol}&apikey=${this.apiKey}`,