Skip to content

Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍

Bugfix/fix missing localization for alias fallback on public page (#4610)

Thomas Kaula5e13d30aeba
diff --git a/CHANGELOG.md b/CHANGELOG.md
index db9ccf9bf5..580489cd26 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -19,6 +19,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed
- Improved the file selector of the activities import functionality to accept case-insensitive file extensions (`.CSV` and `.JSON`)
+- Fixed the missing localization for "someone" on the public page
## 2.155.0 - 2025-04-23
diff --git a/apps/client/src/app/pages/public/public-page.component.ts b/apps/client/src/app/pages/public/public-page.component.ts
index b343a6e015..38a147081e 100644
--- a/apps/client/src/app/pages/public/public-page.component.ts
+++ b/apps/client/src/app/pages/public/public-page.component.ts
@@ -30,6 +30,7 @@ export class PublicPageComponent implements OnInit {
public countries: {
[code: string]: { name: string; value: number };
};
+ public defaultAlias = $localize`someone`;
public deviceType: string;
public holdings: PublicPortfolioResponse['holdings'][string][];
public markets: {
diff --git a/apps/client/src/app/pages/public/public-page.html b/apps/client/src/app/pages/public/public-page.html
index ac1628a3ae..e51aee9a75 100644
--- a/apps/client/src/app/pages/public/public-page.html
+++ b/apps/client/src/app/pages/public/public-page.html
@@ -2,7 +2,7 @@
<div class="row">
<div class="col">
<h1 class="h4 mb-3 text-center" i18n>
- Hello, {{ publicPortfolioDetails?.alias ?? 'someone' }} has shared a
+ Hello, {{ publicPortfolioDetails?.alias ?? defaultAlias }} has shared a
<strong>Portfolio</strong> with you!
</h1>
</div>