Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍
TypeScript angularetffinancefintechghostfoliohacktoberfestinvestingnestjsosspersonal-financeportfolioprismasoftwarestocktrackertradingtypescriptwealth-managementweb
Fix accounts page (#1908)
Thomas Kaula5f0f48ddbd0
diff --git a/CHANGELOG.md b/CHANGELOG.mdindex 6974ddf5fb..b9645b9d6e 100644--- a/CHANGELOG.md+++ b/CHANGELOG.md@@ -11,6 +11,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0- Split the environment variable `DATA_SOURCE_PRIMARY` in `DATA_SOURCE_EXCHANGE_RATES` and `DATA_SOURCE_IMPORT`+### Fixed++- Fixed the exception on the accounts page+## 1.262.0 - 2023-04-29### Addeddiff --git a/apps/api/src/app/portfolio/portfolio.service.ts b/apps/api/src/app/portfolio/portfolio.service.tsindex 1b839977b1..3536169f2f 100644--- a/apps/api/src/app/portfolio/portfolio.service.ts+++ b/apps/api/src/app/portfolio/portfolio.service.ts@@ -466,9 +466,10 @@ export class PortfolioService {cashDetails.balanceInBaseCurrency);- const isFilteredByAccount = filters.some((filter) => {- return filter.type === 'ACCOUNT';- });+ const isFilteredByAccount =+ filters?.some((filter) => {+ return filter.type === 'ACCOUNT';+ }) ?? false;let filteredValueInBaseCurrency = isFilteredByAccount? totalValueInBaseCurrency@@ -571,11 +572,11 @@ export class PortfolioService {};}- const isFilteredByCash = filters.some((filter) => {+ const isFilteredByCash = filters?.some((filter) => {return filter.type === 'ASSET_CLASS' && filter.id === 'CASH';});- if (filters.length === 0 || isFilteredByCash || isFilteredByAccount) {+ if (filters?.length === 0 || isFilteredByAccount || isFilteredByCash) {const cashPositions = await this.getCashPositions({cashDetails,userCurrency,