Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍
TypeScript angularetffinancefintechghostfoliohacktoberfestinvestingnestjsosspersonal-financeportfolioprismasoftwarestocktrackertradingtypescriptwealth-managementweb
Feature/improve import of historical market data (#2559)
Thomas Kaula7baad10d109
diff --git a/CHANGELOG.md b/CHANGELOG.mdindex 3f21cec7a5..a9b5dc8d16 100644--- a/CHANGELOG.md+++ b/CHANGELOG.md@@ -11,6 +11,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0- Improved the usability and validation in the cash balance transfer from one to another account- Changed the checkboxes to slide toggles in the overview of the admin control panel+- Switched from the deprecated (`PUT`) to the new endpoint (`POST`) to manage historical market data in the asset profile details dialog of the admin control panel+- Improved the date parsing in the import historical market data of the admin control panel- Improved the localized meta data (keywords) in `html` files- Improved the language localization for German (`de`)diff --git a/apps/api/src/app/admin/admin.controller.ts b/apps/api/src/app/admin/admin.controller.tsindex a19b17d4a0..e277e77e40 100644--- a/apps/api/src/app/admin/admin.controller.ts+++ b/apps/api/src/app/admin/admin.controller.ts@@ -7,7 +7,10 @@ import {GATHER_ASSET_PROFILE_PROCESS,GATHER_ASSET_PROFILE_PROCESS_OPTIONS} from '@ghostfolio/common/config';-import { getAssetProfileIdentifier } from '@ghostfolio/common/helper';+import {+ getAssetProfileIdentifier,+ resetHours+} from '@ghostfolio/common/helper';import {AdminData,AdminMarketData,@@ -331,9 +334,9 @@ export class AdminController {const dataBulkUpdate: Prisma.MarketDataUpdateInput[] = data.marketData.map(({ date, marketPrice }) => ({dataSource,- date,marketPrice,symbol,+ date: resetHours(parseISO(date)),state: 'CLOSE'}));diff --git a/apps/api/src/app/admin/update-market-data.dto.ts b/apps/api/src/app/admin/update-market-data.dto.tsindex c0463de310..c2a6de11e7 100644--- a/apps/api/src/app/admin/update-market-data.dto.ts+++ b/apps/api/src/app/admin/update-market-data.dto.ts@@ -1,9 +1,9 @@-import { IsDate, IsNumber, IsOptional } from 'class-validator';+import { IsISO8601, IsNumber, IsOptional } from 'class-validator';export class UpdateMarketDataDto {- @IsDate()+ @IsISO8601()@IsOptional()- date?: Date;+ date?: string;@IsNumber()marketPrice: number;diff --git a/apps/client/src/app/components/admin-market-data-detail/market-data-detail-dialog/market-data-detail-dialog.component.ts b/apps/client/src/app/components/admin-market-data-detail/market-data-detail-dialog/market-data-detail-dialog.component.tsindex dddef0c8f7..99fc1abe23 100644--- a/apps/client/src/app/components/admin-market-data-detail/market-data-detail-dialog/market-data-detail-dialog.component.ts+++ b/apps/client/src/app/components/admin-market-data-detail/market-data-detail-dialog/market-data-detail-dialog.component.ts@@ -57,10 +57,16 @@ export class MarketDataDetailDialog implements OnDestroy {public onUpdate() {this.adminService- .putMarketData({+ .postMarketData({dataSource: this.data.dataSource,- date: this.data.date,- marketData: { marketPrice: this.data.marketPrice },+ marketData: {+ marketData: [+ {+ date: this.data.date.toISOString(),+ marketPrice: this.data.marketPrice+ }+ ]+ },symbol: this.data.symbol}).pipe(takeUntil(this.unsubscribeSubject))diff --git a/apps/client/src/app/components/admin-market-data/asset-profile-dialog/asset-profile-dialog.component.ts b/apps/client/src/app/components/admin-market-data/asset-profile-dialog/asset-profile-dialog.component.tsindex c5c2db17a7..5e331ca91f 100644--- a/apps/client/src/app/components/admin-market-data/asset-profile-dialog/asset-profile-dialog.component.ts+++ b/apps/client/src/app/components/admin-market-data/asset-profile-dialog/asset-profile-dialog.component.ts@@ -11,7 +11,7 @@ import { MAT_DIALOG_DATA, MatDialogRef } from '@angular/material/dialog';import { UpdateAssetProfileDto } from '@ghostfolio/api/app/admin/update-asset-profile.dto';import { AdminService } from '@ghostfolio/client/services/admin.service';import { DataService } from '@ghostfolio/client/services/data.service';-import { DATE_FORMAT } from '@ghostfolio/common/helper';+import { DATE_FORMAT, parseDate } from '@ghostfolio/common/helper';import {AdminMarketDataDetails,UniqueAsset@@ -23,7 +23,7 @@ import {MarketData,SymbolProfile} from '@prisma/client';-import { format, parseISO } from 'date-fns';+import { format } from 'date-fns';import { parse as csvToJson } from 'papaparse';import { Subject } from 'rxjs';import { takeUntil } from 'rxjs/operators';@@ -174,7 +174,7 @@ export class AssetProfileDialog implements OnDestroy, OnInit {dataSource: this.data.dataSource,marketData: {marketData: marketData.map(({ date, marketPrice }) => {- return { marketPrice, date: parseISO(date) };+ return { marketPrice, date: parseDate(date).toISOString() };})},symbol: this.data.symboldiff --git a/apps/client/src/app/services/admin.service.ts b/apps/client/src/app/services/admin.service.tsindex 4965c60675..042914ee41 100644--- a/apps/client/src/app/services/admin.service.ts+++ b/apps/client/src/app/services/admin.service.ts@@ -2,7 +2,6 @@ import { HttpClient, HttpParams } from '@angular/common/http';import { Injectable } from '@angular/core';import { UpdateAssetProfileDto } from '@ghostfolio/api/app/admin/update-asset-profile.dto';import { UpdateBulkMarketDataDto } from '@ghostfolio/api/app/admin/update-bulk-market-data.dto';-import { UpdateMarketDataDto } from '@ghostfolio/api/app/admin/update-market-data.dto';import { CreatePlatformDto } from '@ghostfolio/api/app/platform/create-platform.dto';import { UpdatePlatformDto } from '@ghostfolio/api/app/platform/update-platform.dto';import { CreateTagDto } from '@ghostfolio/api/app/tag/create-tag.dto';@@ -247,25 +246,6 @@ export class AdminService {return this.http.post<Tag>(`/api/v1/tag`, aTag);}- public putMarketData({- dataSource,- date,- marketData,- symbol- }: {- dataSource: DataSource;- date: Date;- marketData: UpdateMarketDataDto;- symbol: string;- }) {- const url = `/api/v1/admin/market-data/${dataSource}/${symbol}/${format(- date,- DATE_FORMAT- )}`;-- return this.http.put<MarketData>(url, marketData);- }-public putPlatform(aPlatform: UpdatePlatformDto) {return this.http.put<Platform>(`/api/v1/platform/${aPlatform.id}`,