Skip to content

Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍

Feature/migrate markets page to standalone (#5492)

David Requenoaeb3df56d11e
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 3b0a5567d3..447f5dc7ba 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed
+- Refactored the markets page to standalone
- Refactored the header component to standalone
- Refactored the rule component to standalone
- Refactored the rules component to standalone
diff --git a/apps/client/src/app/app-routing.module.ts b/apps/client/src/app/app-routing.module.ts
index 2d4f1b2278..53db1f06b3 100644
--- a/apps/client/src/app/app-routing.module.ts
+++ b/apps/client/src/app/app-routing.module.ts
@@ -1,11 +1,11 @@
-import { AuthGuard } from '@ghostfolio/client/core/auth.guard';
-import { PageTitleStrategy } from '@ghostfolio/client/services/page-title.strategy';
import { publicRoutes, internalRoutes } from '@ghostfolio/common/routes/routes';
import { NgModule } from '@angular/core';
import { RouterModule, Routes, TitleStrategy } from '@angular/router';
+import { AuthGuard } from './core/auth.guard';
import { ModulePreloadService } from './core/module-preload.service';
+import { PageTitleStrategy } from './services/page-title.strategy';
const routes: Routes = [
{
@@ -89,9 +89,7 @@ const routes: Routes = [
{
path: publicRoutes.markets.path,
loadChildren: () =>
- import('./pages/markets/markets-page.module').then(
- (m) => m.MarketsPageModule
- )
+ import('./pages/markets/markets-page.routes').then((m) => m.routes)
},
{
path: publicRoutes.openStartup.path,
diff --git a/apps/client/src/app/pages/markets/markets-page-routing.module.ts b/apps/client/src/app/pages/markets/markets-page-routing.module.ts
deleted file mode 100644
index 05ab9b2752..0000000000
--- a/apps/client/src/app/pages/markets/markets-page-routing.module.ts
+++ /dev/null
@@ -1,22 +0,0 @@
-import { AuthGuard } from '@ghostfolio/client/core/auth.guard';
-import { publicRoutes } from '@ghostfolio/common/routes/routes';
-
-import { NgModule } from '@angular/core';
-import { RouterModule, Routes } from '@angular/router';
-
-import { MarketsPageComponent } from './markets-page.component';
-
-const routes: Routes = [
- {
- canActivate: [AuthGuard],
- component: MarketsPageComponent,
- path: '',
- title: publicRoutes.markets.title
- }
-];
-
-@NgModule({
- imports: [RouterModule.forChild(routes)],
- exports: [RouterModule]
-})
-export class MarketsPageRoutingModule {}
diff --git a/apps/client/src/app/pages/markets/markets-page.component.ts b/apps/client/src/app/pages/markets/markets-page.component.ts
index be569233ee..2d4a25876c 100644
--- a/apps/client/src/app/pages/markets/markets-page.component.ts
+++ b/apps/client/src/app/pages/markets/markets-page.component.ts
@@ -1,14 +1,17 @@
+import { HomeMarketComponent } from '@ghostfolio/client/components/home-market/home-market.component';
+
+import { CommonModule } from '@angular/common';
import { Component, OnDestroy } from '@angular/core';
import { Subject } from 'rxjs';
@Component({
host: { class: 'page' },
+ imports: [CommonModule, HomeMarketComponent],
selector: 'gf-markets-page',
styleUrls: ['./markets-page.scss'],
- templateUrl: './markets-page.html',
- standalone: false
+ templateUrl: './markets-page.html'
})
-export class MarketsPageComponent implements OnDestroy {
+export class GfMarketsPageComponent implements OnDestroy {
private unsubscribeSubject = new Subject<void>();
public ngOnDestroy() {
diff --git a/apps/client/src/app/pages/markets/markets-page.module.ts b/apps/client/src/app/pages/markets/markets-page.module.ts
deleted file mode 100644
index 34938612e1..0000000000
--- a/apps/client/src/app/pages/markets/markets-page.module.ts
+++ /dev/null
@@ -1,14 +0,0 @@
-import { HomeMarketComponent } from '@ghostfolio/client/components/home-market/home-market.component';
-
-import { CommonModule } from '@angular/common';
-import { CUSTOM_ELEMENTS_SCHEMA, NgModule } from '@angular/core';
-
-import { MarketsPageRoutingModule } from './markets-page-routing.module';
-import { MarketsPageComponent } from './markets-page.component';
-
-@NgModule({
- declarations: [MarketsPageComponent],
- imports: [CommonModule, HomeMarketComponent, MarketsPageRoutingModule],
- schemas: [CUSTOM_ELEMENTS_SCHEMA]
-})
-export class MarketsPageModule {}
diff --git a/apps/client/src/app/pages/markets/markets-page.routes.ts b/apps/client/src/app/pages/markets/markets-page.routes.ts
new file mode 100644
index 0000000000..70ebb5553b
--- /dev/null
+++ b/apps/client/src/app/pages/markets/markets-page.routes.ts
@@ -0,0 +1,24 @@
+import { AuthGuard } from '@ghostfolio/client/core/auth.guard';
+import { publicRoutes } from '@ghostfolio/common/routes/routes';
+
+import { Routes } from '@angular/router';
+
+import { GfMarketsPageComponent } from './markets-page.component';
+
+export const routes: Routes = [
+ {
+ canActivate: [AuthGuard],
+ children: [
+ {
+ path: '',
+ loadComponent: () =>
+ import('./markets-page.component').then(
+ (m) => m.GfMarketsPageComponent
+ )
+ }
+ ],
+ component: GfMarketsPageComponent,
+ path: '',
+ title: publicRoutes.markets.title
+ }
+];