Skip to content

Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍

Task/improve type safety in file drop directive (#6961)

Kenrick Tandrianb6b44347b029
diff --git a/apps/client/src/app/directives/file-drop/file-drop.directive.ts b/apps/client/src/app/directives/file-drop/file-drop.directive.ts
index a7e628bc9f..b46357005c 100644
--- a/apps/client/src/app/directives/file-drop/file-drop.directive.ts
+++ b/apps/client/src/app/directives/file-drop/file-drop.directive.ts
@@ -1,28 +1,34 @@
-import { Directive, EventEmitter, HostListener, Output } from '@angular/core';
+import { Directive, output } from '@angular/core';
@Directive({
+ host: {
+ '(dragenter)': 'onDragEnter($event)',
+ '(dragover)': 'onDragOver($event)',
+ '(drop)': 'onDrop($event)'
+ },
selector: '[gfFileDrop]'
})
export class GfFileDropDirective {
- @Output() filesDropped = new EventEmitter<FileList>();
+ public readonly filesDropped = output<FileList>();
- @HostListener('dragenter', ['$event']) onDragEnter(event: DragEvent) {
+ public onDragEnter(event: DragEvent) {
event.preventDefault();
event.stopPropagation();
}
- @HostListener('dragover', ['$event']) onDragOver(event: DragEvent) {
+ public onDragOver(event: DragEvent) {
event.preventDefault();
event.stopPropagation();
}
- @HostListener('drop', ['$event']) onDrop(event: DragEvent) {
+ public onDrop(event: DragEvent) {
event.preventDefault();
event.stopPropagation();
- // Prevent the browser's default behavior for handling the file drop
- event.dataTransfer.dropEffect = 'copy';
-
- this.filesDropped.emit(event.dataTransfer.files);
+ if (event.dataTransfer) {
+ // Prevent the browser's default behavior for handling the file drop
+ event.dataTransfer.dropEffect = 'copy';
+ this.filesDropped.emit(event.dataTransfer.files);
+ }
}
}