Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍
TypeScript angularetffinancefintechghostfoliohacktoberfestinvestingnestjsosspersonal-financeportfolioprismasoftwarestocktrackertradingtypescriptwealth-managementweb
Task/harden validation of sectors in asset profile endpoints (#7319)
Thomas Kaulb7fc13e20a93
diff --git a/CHANGELOG.md b/CHANGELOG.mdindex c2b3109164..cdf27bf9b7 100644--- a/CHANGELOG.md+++ b/CHANGELOG.md@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0### Changed- Hardened the validation of the countries in the asset profile endpoints+- Hardened the validation of the sectors in the asset profile endpoints- Rounded the value of the _Fear & Greed Index_ (market mood) in the twitter bot service- Set the change detection strategy to `OnPush` in the _X-ray_ pagediff --git a/libs/common/src/lib/dtos/country.dto.ts b/libs/common/src/lib/dtos/country.dto.tsindex 663aa1ac61..7fc8c38ab3 100644--- a/libs/common/src/lib/dtos/country.dto.ts+++ b/libs/common/src/lib/dtos/country.dto.ts@@ -5,7 +5,7 @@ export class CountryDto {code: string;@IsNumber()- @Min(0)@Max(1)+ @Min(0)weight: number;}diff --git a/libs/common/src/lib/dtos/create-asset-profile.dto.ts b/libs/common/src/lib/dtos/create-asset-profile.dto.tsindex 3e7e2224e7..0b0ccb9d36 100644--- a/libs/common/src/lib/dtos/create-asset-profile.dto.ts+++ b/libs/common/src/lib/dtos/create-asset-profile.dto.ts@@ -13,6 +13,7 @@ import {} from 'class-validator';import { CountryDto } from './country.dto';+import { SectorDto } from './sector.dto';export class CreateAssetProfileDto {@IsEnum(AssetClass)@@ -73,6 +74,8 @@ export class CreateAssetProfileDto {@IsArray()@IsOptional()+ @Type(() => SectorDto)+ @ValidateNested({ each: true })sectors?: Prisma.InputJsonArray;@IsString()diff --git a/libs/common/src/lib/dtos/index.ts b/libs/common/src/lib/dtos/index.tsindex dea0923989..c74c68dfd5 100644--- a/libs/common/src/lib/dtos/index.ts+++ b/libs/common/src/lib/dtos/index.ts@@ -11,6 +11,7 @@ import { CreatePlatformDto } from './create-platform.dto';import { CreateTagDto } from './create-tag.dto';import { CreateWatchlistItemDto } from './create-watchlist-item.dto';import { DeleteOwnUserDto } from './delete-own-user.dto';+import { SectorDto } from './sector.dto';import { TransferBalanceDto } from './transfer-balance.dto';import { UpdateAccessDto } from './update-access.dto';import { UpdateAccountDto } from './update-account.dto';@@ -39,6 +40,7 @@ export {CreateTagDto,CreateWatchlistItemDto,DeleteOwnUserDto,+ SectorDto,TransferBalanceDto,UpdateAccessDto,UpdateAccountDto,diff --git a/libs/common/src/lib/dtos/sector.dto.ts b/libs/common/src/lib/dtos/sector.dto.tsnew file mode 100644index 0000000000..e4655cb739--- /dev/null+++ b/libs/common/src/lib/dtos/sector.dto.ts@@ -0,0 +1,11 @@+import { IsNumber, IsString, Max, Min } from 'class-validator';++export class SectorDto {+ @IsString()+ name: string;++ @IsNumber()+ @Max(1)+ @Min(0)+ weight: number;+}diff --git a/libs/common/src/lib/dtos/update-asset-profile.dto.ts b/libs/common/src/lib/dtos/update-asset-profile.dto.tsindex dc660a4818..5b193ff7ec 100644--- a/libs/common/src/lib/dtos/update-asset-profile.dto.ts+++ b/libs/common/src/lib/dtos/update-asset-profile.dto.ts@@ -20,6 +20,7 @@ import {} from 'class-validator';import { CountryDto } from './country.dto';+import { SectorDto } from './sector.dto';export class UpdateAssetProfileDto {@IsEnum(AssetClass)@@ -70,6 +71,8 @@ export class UpdateAssetProfileDto {@IsArray()@IsOptional()+ @Type(() => SectorDto)+ @ValidateNested({ each: true })sectors?: Prisma.InputJsonArray;@IsOptional()