Skip to content

Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍

Feature/remove ghostfolio in numbers section from about page (#2029)

Thomas Kaulbd8bb1a36af5
diff --git a/CHANGELOG.md b/CHANGELOG.md
index e7955e442a..4f14d2a5cf 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
+## Unreleased
+
+### Changed
+
+- Removed the _Ghostfolio in Numbers_ section from the about page
+
## 1.275.0 - 2023-05-30
### Changed
diff --git a/apps/client/src/app/pages/about/about-page.component.ts b/apps/client/src/app/pages/about/about-page.component.ts
index 69f8eb0939..5790d663d1 100644
--- a/apps/client/src/app/pages/about/about-page.component.ts
+++ b/apps/client/src/app/pages/about/about-page.component.ts
@@ -3,7 +3,7 @@ import { environment } from '@ghostfolio/client/../environments/environment';
import { DataService } from '@ghostfolio/client/services/data.service';
import { UserService } from '@ghostfolio/client/services/user/user.service';
import { DEFAULT_LANGUAGE_CODE } from '@ghostfolio/common/config';
-import { Statistics, User } from '@ghostfolio/common/interfaces';
+import { User } from '@ghostfolio/common/interfaces';
import { hasPermission, permissions } from '@ghostfolio/common/permissions';
import { Subject } from 'rxjs';
import { takeUntil } from 'rxjs/operators';
@@ -17,10 +17,8 @@ import { takeUntil } from 'rxjs/operators';
export class AboutPageComponent implements OnDestroy, OnInit {
public defaultLanguageCode = DEFAULT_LANGUAGE_CODE;
public hasPermissionForBlog: boolean;
- public hasPermissionForStatistics: boolean;
public hasPermissionForSubscription: boolean;
public isLoggedIn: boolean;
- public statistics: Statistics;
public user: User;
public version = environment.version;
@@ -31,24 +29,17 @@ export class AboutPageComponent implements OnDestroy, OnInit {
private dataService: DataService,
private userService: UserService
) {
- const { globalPermissions, statistics } = this.dataService.fetchInfo();
+ const { globalPermissions } = this.dataService.fetchInfo();
this.hasPermissionForBlog = hasPermission(
globalPermissions,
permissions.enableBlog
);
- this.hasPermissionForStatistics = hasPermission(
- globalPermissions,
- permissions.enableStatistics
- );
-
this.hasPermissionForSubscription = hasPermission(
globalPermissions,
permissions.enableSubscription
);
-
- this.statistics = statistics;
}
public ngOnInit() {
diff --git a/apps/client/src/app/pages/about/about-page.html b/apps/client/src/app/pages/about/about-page.html
index 6030ce0e42..c761b9aed9 100644
--- a/apps/client/src/app/pages/about/about-page.html
+++ b/apps/client/src/app/pages/about/about-page.html
@@ -38,7 +38,7 @@
<ng-container *ngIf="version">
This instance is running Ghostfolio {{ version }}.
</ng-container>
- <ng-container *ngIf="hasPermissionForStatistics"
+ <ng-container *ngIf="hasPermissionForSubscription"
>Check the system status at
<a href="https://status.ghostfol.io" title="Ghostfolio Status"
>status.ghostfol.io</a
@@ -134,81 +134,6 @@
</div>
</div>
- <div *ngIf="hasPermissionForStatistics" class="mb-5 row">
- <div class="col">
- <h3 class="mb-3 text-center">Ghostfolio in Numbers</h3>
- <mat-card appearance="outlined">
- <mat-card-content>
- <div class="row">
- <div class="col-xs-12 col-md-4 my-2">
- <gf-value
- size="large"
- subLabel="(Last 24 hours)"
- [locale]="user?.settings?.locale"
- [value]="statistics?.activeUsers1d ?? '-'"
- >Active Users</gf-value
- >
- </div>
- <div class="col-xs-12 col-md-4 my-2">
- <gf-value
- size="large"
- subLabel="(Last 30 days)"
- [locale]="user?.settings?.locale"
- [value]="statistics?.newUsers30d ?? '-'"
- >New Users</gf-value
- >
- </div>
- <div class="col-xs-12 col-md-4 my-2">
- <gf-value
- size="large"
- subLabel="(Last 30 days)"
- [locale]="user?.settings?.locale"
- [value]="statistics?.activeUsers30d ?? '-'"
- >Active Users</gf-value
- >
- </div>
- <div class="col-xs-12 col-md-4 my-2">
- <a class="d-block" href="https://ghostfolio.slack.com">
- <gf-value
- size="large"
- [locale]="user?.settings?.locale"
- [value]="statistics?.slackCommunityUsers ?? '-'"
- >Users in Slack community</gf-value
- >
- </a>
- </div>
- <div class="col-xs-12 col-md-4 my-2">
- <a
- class="d-block"
- href="https://github.com/ghostfolio/ghostfolio/graphs/contributors"
- >
- <gf-value
- size="large"
- [locale]="user?.settings?.locale"
- [value]="statistics?.gitHubContributors ?? '-'"
- >Contributors on GitHub</gf-value
- >
- </a>
- </div>
- <div class="col-xs-12 col-md-4 my-2">
- <a
- class="d-block"
- href="https://github.com/ghostfolio/ghostfolio/stargazers"
- >
- <gf-value
- size="large"
- [locale]="user?.settings?.locale"
- [value]="statistics?.gitHubStargazers ?? '-'"
- >Stars on GitHub</gf-value
- >
- </a>
- </div>
- </div>
- </mat-card-content>
- </mat-card>
- </div>
- </div>
-
<div class="row">
<div *ngIf="hasPermissionForSubscription" class="col-md-3 col-xs-12 my-2">
<a
diff --git a/apps/client/src/app/pages/about/about-page.module.ts b/apps/client/src/app/pages/about/about-page.module.ts
index ab1be9b84a..05e7a2e302 100644
--- a/apps/client/src/app/pages/about/about-page.module.ts
+++ b/apps/client/src/app/pages/about/about-page.module.ts
@@ -1,21 +1,13 @@
import { CommonModule } from '@angular/common';
import { CUSTOM_ELEMENTS_SCHEMA, NgModule } from '@angular/core';
import { MatButtonModule } from '@angular/material/button';
-import { MatCardModule } from '@angular/material/card';
-import { GfValueModule } from '@ghostfolio/ui/value';
import { AboutPageRoutingModule } from './about-page-routing.module';
import { AboutPageComponent } from './about-page.component';
@NgModule({
declarations: [AboutPageComponent],
- imports: [
- AboutPageRoutingModule,
- CommonModule,
- GfValueModule,
- MatButtonModule,
- MatCardModule
- ],
+ imports: [AboutPageRoutingModule, CommonModule, MatButtonModule],
schemas: [CUSTOM_ELEMENTS_SCHEMA]
})
export class AboutPageModule {}