Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍
TypeScript angularetffinancefintechghostfoliohacktoberfestinvestingnestjsosspersonal-financeportfolioprismasoftwarestocktrackertradingtypescriptwealth-managementweb
Bugfix/fix symbol validation in Yahoo Finance service (#4472)
Thomas Kaulc467c946d428
diff --git a/apps/api/src/services/data-provider/data-enhancer/yahoo-finance/yahoo-finance.service.ts b/apps/api/src/services/data-provider/data-enhancer/yahoo-finance/yahoo-finance.service.tsindex 78644726ad..d876b42ca2 100644--- a/apps/api/src/services/data-provider/data-enhancer/yahoo-finance/yahoo-finance.service.ts+++ b/apps/api/src/services/data-provider/data-enhancer/yahoo-finance/yahoo-finance.service.ts@@ -170,7 +170,7 @@ export class YahooFinanceDataEnhancerService implements DataEnhancerInterface {symbol = quotes[0].symbol;}} catch {}- } else if (symbol?.includes('-')) {+ } else if (symbol?.endsWith(`-${DEFAULT_CURRENCY}`)) {throw new Error(`${symbol} is not valid`);} else {symbol = this.convertToYahooFinanceSymbol(symbol);diff --git a/test/import/invalid-symbol-btc-usd.csv b/test/import/invalid-symbol-btc-usd.csvnew file mode 100644index 0000000000..d2c91be768--- /dev/null+++ b/test/import/invalid-symbol-btc-usd.csv@@ -0,0 +1,2 @@+Date,Code,Currency,Price,Quantity,Action,Fee+12/12/2021,BTC-USD,USD,44558.42,1,buy,0diff --git a/test/import/ok-btcusd.csv b/test/import/ok-btcusd.csvnew file mode 100644index 0000000000..8cddc12708--- /dev/null+++ b/test/import/ok-btcusd.csv@@ -0,0 +1,2 @@+Date,Code,Currency,Price,Quantity,Action,Fee+12/12/2021,BTCUSD,USD,44558.42,1,buy,0