Skip to content

Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍

Setup tests (#1234)

Thomas Kaulc4d83aabe785
diff --git a/apps/api/src/app/benchmark/benchmark.service.spec.ts b/apps/api/src/app/benchmark/benchmark.service.spec.ts
new file mode 100644
index 0000000000..8875c9e1de
--- /dev/null
+++ b/apps/api/src/app/benchmark/benchmark.service.spec.ts
@@ -0,0 +1,15 @@
+import { BenchmarkService } from './benchmark.service';
+
+describe('BenchmarkService', () => {
+ let benchmarkService: BenchmarkService;
+
+ beforeAll(async () => {
+ benchmarkService = new BenchmarkService(null, null, null, null, null);
+ });
+
+ it('calculateChangeInPercentage', async () => {
+ expect(benchmarkService.calculateChangeInPercentage(1, 2)).toEqual(1);
+ expect(benchmarkService.calculateChangeInPercentage(2, 2)).toEqual(0);
+ expect(benchmarkService.calculateChangeInPercentage(2, 1)).toEqual(-0.5);
+ });
+});
diff --git a/apps/api/src/app/benchmark/benchmark.service.ts b/apps/api/src/app/benchmark/benchmark.service.ts
index 351ec2974d..51fac62129 100644
--- a/apps/api/src/app/benchmark/benchmark.service.ts
+++ b/apps/api/src/app/benchmark/benchmark.service.ts
@@ -27,6 +27,10 @@ export class BenchmarkService {
private readonly symbolProfileService: SymbolProfileService
) {}
+ public calculateChangeInPercentage(baseValue: number, currentValue: number) {
+ return new Big(currentValue).div(baseValue).minus(1).toNumber();
+ }
+
public async getBenchmarks({ useCache = true } = {}): Promise<
BenchmarkResponse['benchmarks']
> {
@@ -64,12 +68,13 @@ export class BenchmarkService {
benchmarks = allTimeHighs.map((allTimeHigh, index) => {
const { marketPrice } = quotes[benchmarkAssets[index].symbol] ?? {};
- let performancePercentFromAllTimeHigh = new Big(0);
+ let performancePercentFromAllTimeHigh = 0;
if (allTimeHigh && marketPrice) {
- performancePercentFromAllTimeHigh = new Big(marketPrice)
- .div(allTimeHigh)
- .minus(1);
+ performancePercentFromAllTimeHigh = this.calculateChangeInPercentage(
+ allTimeHigh,
+ marketPrice
+ );
}
return {
@@ -84,7 +89,7 @@ export class BenchmarkService {
})?.name,
performances: {
allTimeHigh: {
- performancePercent: performancePercentFromAllTimeHigh.toNumber()
+ performancePercent: performancePercentFromAllTimeHigh
}
}
};
@@ -135,26 +140,24 @@ export class BenchmarkService {
}
});
- const marketPriceAtStartDate = new Big(
- marketDataItems?.[0]?.marketPrice ?? 0
- );
-
+ const marketPriceAtStartDate = marketDataItems?.[0]?.marketPrice ?? 0;
return {
marketData: marketDataItems.map((marketDataItem) => {
return {
date: format(marketDataItem.date, DATE_FORMAT),
- value: marketPriceAtStartDate.eq(0)
- ? 0
- : new Big(marketDataItem.marketPrice)
- .div(marketPriceAtStartDate)
- .minus(1)
- .toNumber() * 100
+ value:
+ marketPriceAtStartDate === 0
+ ? 0
+ : this.calculateChangeInPercentage(
+ marketPriceAtStartDate,
+ marketDataItem.marketPrice
+ ) * 100
};
})
};
}
- private getMarketCondition(aPerformanceInPercent: Big) {
- return aPerformanceInPercent.lte(-0.2) ? 'BEAR_MARKET' : 'NEUTRAL_MARKET';
+ private getMarketCondition(aPerformanceInPercent: number) {
+ return aPerformanceInPercent <= -0.2 ? 'BEAR_MARKET' : 'NEUTRAL_MARKET';
}
}