Skip to content

Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍

Bugfix/fix historical market data gathering for asset profiles with manual data source (#3336)

Thomas Kaulcd0780240030
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 18e38e100a..e558f5afd6 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -20,6 +20,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed
- Fixed the form submit in the asset profile details dialog of the admin control due to the `url` validation
+- Fixed the historical market data gathering for asset profiles with `MANUAL` data source
## 2.76.0 - 2024-04-23
diff --git a/apps/api/src/app/import/import.service.ts b/apps/api/src/app/import/import.service.ts
index 26df9d0699..a1ddeb4828 100644
--- a/apps/api/src/app/import/import.service.ts
+++ b/apps/api/src/app/import/import.service.ts
@@ -416,6 +416,11 @@ export class ImportService {
User: { connect: { id: user.id } },
userId: user.id
});
+
+ if (order.SymbolProfile?.symbol) {
+ // Update symbol that may have been assigned in createOrder()
+ assetProfile.symbol = order.SymbolProfile.symbol;
+ }
}
const value = new Big(quantity).mul(unitPrice).toNumber();
diff --git a/apps/api/src/app/order/order.service.ts b/apps/api/src/app/order/order.service.ts
index a78daa1437..e976fc80d0 100644
--- a/apps/api/src/app/order/order.service.ts
+++ b/apps/api/src/app/order/order.service.ts
@@ -140,7 +140,8 @@ export class OrderService {
return { id };
})
}
- }
+ },
+ include: { SymbolProfile: true }
});
if (updateAccountBalance === true) {
diff --git a/apps/api/src/services/data-provider/manual/manual.service.ts b/apps/api/src/services/data-provider/manual/manual.service.ts
index 4ff3ba6532..5066a4d3a2 100644
--- a/apps/api/src/services/data-provider/manual/manual.service.ts
+++ b/apps/api/src/services/data-provider/manual/manual.service.ts
@@ -91,7 +91,7 @@ export class ManualService implements DataProviderInterface {
headers = {},
selector,
url
- } = symbolProfile.scraperConfiguration ?? {};
+ } = symbolProfile?.scraperConfiguration ?? {};
if (defaultMarketPrice) {
const historical: {