Skip to content

Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍

Task/refactor input in world map chart component (#6692)

Thomas Kaulcebf15284e73
diff --git a/apps/client/src/app/pages/portfolio/allocations/allocations-page.html b/apps/client/src/app/pages/portfolio/allocations/allocations-page.html
index 0b75c6d8f2..530b528e6a 100644
--- a/apps/client/src/app/pages/portfolio/allocations/allocations-page.html
+++ b/apps/client/src/app/pages/portfolio/allocations/allocations-page.html
@@ -204,7 +204,7 @@
<gf-world-map-chart
[countries]="countries"
[format]="worldMapChartFormat"
- [isInPercent]="showValuesInPercentage()"
+ [isInPercentage]="showValuesInPercentage()"
[locale]="user?.settings?.locale"
/>
</div>
diff --git a/apps/client/src/app/pages/public/public-page.html b/apps/client/src/app/pages/public/public-page.html
index c422f90060..53132442b9 100644
--- a/apps/client/src/app/pages/public/public-page.html
+++ b/apps/client/src/app/pages/public/public-page.html
@@ -154,7 +154,7 @@
<gf-world-map-chart
format="{0}%"
[countries]="countries"
- [isInPercent]="true"
+ [isInPercentage]="true"
/>
</div>
<div class="row">
diff --git a/libs/ui/src/lib/world-map-chart/world-map-chart.component.stories.ts b/libs/ui/src/lib/world-map-chart/world-map-chart.component.stories.ts
index bdc983ae3d..6d9d852951 100644
--- a/libs/ui/src/lib/world-map-chart/world-map-chart.component.stories.ts
+++ b/libs/ui/src/lib/world-map-chart/world-map-chart.component.stories.ts
@@ -44,7 +44,7 @@ export const Default: Story = {
})
),
format: `{0} ${DEFAULT_CURRENCY}`,
- isInPercent: false
+ isInPercentage: false
}
};
@@ -52,6 +52,6 @@ export const InPercentage: Story = {
args: {
countries: VWRL_COUNTRY_ALLOCATION,
format: '{0}%',
- isInPercent: true
+ isInPercentage: true
}
};
diff --git a/libs/ui/src/lib/world-map-chart/world-map-chart.component.ts b/libs/ui/src/lib/world-map-chart/world-map-chart.component.ts
index 2a926cf7ce..f86d4d0107 100644
--- a/libs/ui/src/lib/world-map-chart/world-map-chart.component.ts
+++ b/libs/ui/src/lib/world-map-chart/world-map-chart.component.ts
@@ -21,7 +21,7 @@ import svgMap from 'svgmap';
export class GfWorldMapChartComponent implements OnChanges, OnDestroy {
@Input() countries: { [code: string]: { name?: string; value: number } };
@Input() format: string;
- @Input() isInPercent = false;
+ @Input() isInPercentage = false;
@Input() locale = getLocale();
public isLoading = true;
@@ -47,7 +47,7 @@ export class GfWorldMapChartComponent implements OnChanges, OnDestroy {
}
private initialize() {
- if (this.isInPercent) {
+ if (this.isInPercentage) {
// Convert value of countries to percentage
let sum = 0;
Object.keys(this.countries).map((country) => {