Skip to content

Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍

Task/improve loading state of symbol autocomplete component (#7739)

Thomas Kauld236a5ca33e6
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 9cc46088e0..59cbf634d2 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed
+- Improved the loading state of the symbol autocomplete component
- Consolidated the duplicated translations of the asset classes and asset sub classes
### Fixed
diff --git a/libs/ui/src/lib/symbol-autocomplete/symbol-autocomplete.component.ts b/libs/ui/src/lib/symbol-autocomplete/symbol-autocomplete.component.ts
index cd78464785..5c582e6a16 100644
--- a/libs/ui/src/lib/symbol-autocomplete/symbol-autocomplete.component.ts
+++ b/libs/ui/src/lib/symbol-autocomplete/symbol-autocomplete.component.ts
@@ -128,6 +128,7 @@ export class GfSymbolAutocompleteComponent
map((query) => {
return isString(query) ? query.trim() : query;
}),
+ distinctUntilChanged(),
filter((query) => {
if (query?.length === 0) {
this.showDefaultOptions();
@@ -137,13 +138,12 @@ export class GfSymbolAutocompleteComponent
return isString(query);
}),
- debounceTime(400),
- distinctUntilChanged(),
tap(() => {
this.isLoading = true;
this.changeDetectorRef.markForCheck();
}),
+ debounceTime(400),
takeUntilDestroyed(this.destroyRef),
switchMap((query: string) => {
return this.dataService.fetchSymbols({