Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍
TypeScript angularetffinancefintechghostfoliohacktoberfestinvestingnestjsosspersonal-financeportfolioprismasoftwarestocktrackertradingtypescriptwealth-managementweb
Task/improve date formatting in market data table of admin control panel (#7278)
Thomas Kauld44243d737a3
diff --git a/CHANGELOG.md b/CHANGELOG.mdindex 0b0237916e..88b32f0322 100644--- a/CHANGELOG.md+++ b/CHANGELOG.md@@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0### Changed- Improved the user account deletion flow in the user settings of the user account page+- Improved the date formatting of the first activity in the historical market data table of the admin control panel- Set the change detection strategy to `OnPush` in the allocations page- Set the change detection strategy to `OnPush` in the portfolio holdings page- Set the change detection strategy to `OnPush` in the _FIRE_ pagediff --git a/apps/client/src/app/components/admin-market-data/admin-market-data.component.ts b/apps/client/src/app/components/admin-market-data/admin-market-data.component.tsindex ae0f8fda2f..c64405cb67 100644--- a/apps/client/src/app/components/admin-market-data/admin-market-data.component.ts+++ b/apps/client/src/app/components/admin-market-data/admin-market-data.component.ts@@ -4,10 +4,7 @@ import {DEFAULT_LOCALE,DEFAULT_PAGE_SIZE} from '@ghostfolio/common/config';-import {- canDeleteAssetProfile,- getDateFormatString-} from '@ghostfolio/common/helper';+import { canDeleteAssetProfile } from '@ghostfolio/common/helper';import {AssetProfileIdentifier,AssetProfileItem,@@ -153,7 +150,6 @@ export class GfAdminMarketDataComponent implements AfterViewInit, OnInit {];protected readonly canDeleteAssetProfile = canDeleteAssetProfile;protected dataSource = new MatTableDataSource<AssetProfileItem>();- protected defaultDateFormat: string;protected readonly displayedColumns: string[] = [];protected readonly filters$ = new Subject<Filter[]>();protected isLoading = true;@@ -236,10 +232,6 @@ export class GfAdminMarketDataComponent implements AfterViewInit, OnInit {.subscribe((state) => {if (state?.user) {this.user = state.user;-- this.defaultDateFormat = getDateFormatString(- this.user.settings.locale- );}});diff --git a/apps/client/src/app/components/admin-market-data/admin-market-data.html b/apps/client/src/app/components/admin-market-data/admin-market-data.htmlindex 83703b548b..ae7adfdd89 100644--- a/apps/client/src/app/components/admin-market-data/admin-market-data.html+++ b/apps/client/src/app/components/admin-market-data/admin-market-data.html@@ -147,7 +147,13 @@<ng-container i18n>First Activity</ng-container></th><td *matCellDef="let element" class="px-1" mat-cell>- {{ (element.date | date: defaultDateFormat) ?? '' }}+ @if (element.date) {+ <gf-value+ [isDate]="true"+ [locale]="user?.settings?.locale"+ [value]="element.date"+ />+ }</td></ng-container>