Skip to content

Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍

Feature/add support for ETF sector data in YahooFinanceDataEnhancer (#4258)

Guillermo Tomás Fernández Martínd4f28e27593f
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 9bdbb832d7..9ffd570f91 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Added
- Added a new static portfolio analysis rule: _Regional Market Cluster Risk_ (North America)
+- Added support for ETF sector data in the _Yahoo Finance_ data enhancer
### Changed
diff --git a/apps/api/src/services/data-provider/data-enhancer/yahoo-finance/yahoo-finance.service.ts b/apps/api/src/services/data-provider/data-enhancer/yahoo-finance/yahoo-finance.service.ts
index b71e3e3169..18d6240985 100644
--- a/apps/api/src/services/data-provider/data-enhancer/yahoo-finance/yahoo-finance.service.ts
+++ b/apps/api/src/services/data-provider/data-enhancer/yahoo-finance/yahoo-finance.service.ts
@@ -197,7 +197,7 @@ export class YahooFinanceDataEnhancerService implements DataEnhancerInterface {
assetProfile.price.symbol
);
- if (assetSubClass === AssetSubClass.MUTUALFUND) {
+ if (['ETF', 'MUTUALFUND'].includes(assetSubClass)) {
response.sectors = [];
for (const sectorWeighting of assetProfile.topHoldings
@@ -207,7 +207,7 @@ export class YahooFinanceDataEnhancerService implements DataEnhancerInterface {
}
}
} else if (
- assetSubClass === AssetSubClass.STOCK &&
+ assetSubClass === 'STOCK' &&
assetProfile.summaryProfile?.country
) {
// Add country if asset is stock and country available