Skip to content

Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍

Feature/increase timeout to load benchmarks (#3158)

Thomas Kaule21563d90394
diff --git a/CHANGELOG.md b/CHANGELOG.md
index f7aef27091..54e1c4e171 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -19,6 +19,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Improved the usability of the platform management in the admin control panel
- Improved the usability of the tag management in the admin control panel
- Improved the exception handling of various rules in the _X-ray_ section
+- Increased the timeout to load benchmarks
- Upgraded `prisma` from version `5.10.2` to `5.11.0`
### Fixed
diff --git a/apps/api/src/app/access/access.controller.ts b/apps/api/src/app/access/access.controller.ts
index eb2116e3c2..8444a88d16 100644
--- a/apps/api/src/app/access/access.controller.ts
+++ b/apps/api/src/app/access/access.controller.ts
@@ -83,7 +83,7 @@ export class AccessController {
}
try {
- return await this.accessService.createAccess({
+ return this.accessService.createAccess({
alias: data.alias || undefined,
GranteeUser: data.granteeUserId
? { connect: { id: data.granteeUserId } }
diff --git a/apps/api/src/app/admin/admin.controller.ts b/apps/api/src/app/admin/admin.controller.ts
index 40ba85759e..dab8fb8b2c 100644
--- a/apps/api/src/app/admin/admin.controller.ts
+++ b/apps/api/src/app/admin/admin.controller.ts
@@ -339,6 +339,6 @@ export class AdminController {
@Param('key') key: string,
@Body() data: PropertyDto
) {
- return await this.adminService.putSetting(key, data.value);
+ return this.adminService.putSetting(key, data.value);
}
}
diff --git a/apps/api/src/app/admin/admin.service.ts b/apps/api/src/app/admin/admin.service.ts
index f78d1b61d0..06ccdf379d 100644
--- a/apps/api/src/app/admin/admin.service.ts
+++ b/apps/api/src/app/admin/admin.service.ts
@@ -71,7 +71,7 @@ export class AdminService {
);
}
- return await this.symbolProfileService.add(
+ return this.symbolProfileService.add(
assetProfiles[symbol] as Prisma.SymbolProfileCreateInput
);
} catch (error) {
diff --git a/apps/api/src/app/benchmark/benchmark.service.ts b/apps/api/src/app/benchmark/benchmark.service.ts
index b820430f6b..5a8c1cc2d6 100644
--- a/apps/api/src/app/benchmark/benchmark.service.ts
+++ b/apps/api/src/app/benchmark/benchmark.service.ts
@@ -110,7 +110,9 @@ export class BenchmarkService {
const quotes = await this.dataProviderService.getQuotes({
items: benchmarkAssetProfiles.map(({ dataSource, symbol }) => {
return { dataSource, symbol };
- })
+ }),
+ requestTimeout: ms('30 seconds'),
+ useCache: false
});
for (const { dataSource, symbol } of benchmarkAssetProfiles) {
@@ -163,7 +165,7 @@ export class BenchmarkService {
await this.redisCacheService.set(
this.CACHE_KEY_BENCHMARKS,
JSON.stringify(benchmarks),
- ms('4 hours') / 1000
+ ms('2 hours') / 1000
);
}
diff --git a/apps/api/src/app/redis-cache/redis-cache.service.ts b/apps/api/src/app/redis-cache/redis-cache.service.ts
index fe3fad13ad..3891cc5ab8 100644
--- a/apps/api/src/app/redis-cache/redis-cache.service.ts
+++ b/apps/api/src/app/redis-cache/redis-cache.service.ts
@@ -21,7 +21,7 @@ export class RedisCacheService {
}
public async get(key: string): Promise<string> {
- return await this.cache.get(key);
+ return this.cache.get(key);
}
public getQuoteKey({ dataSource, symbol }: UniqueAsset) {
@@ -29,15 +29,15 @@ export class RedisCacheService {
}
public async remove(key: string) {
- await this.cache.del(key);
+ return this.cache.del(key);
}
public async reset() {
- await this.cache.reset();
+ return this.cache.reset();
}
public async set(key: string, value: string, ttlInSeconds?: number) {
- await this.cache.set(
+ return this.cache.set(
key,
value,
ttlInSeconds ?? this.configurationService.get('CACHE_TTL')
diff --git a/apps/api/src/app/subscription/subscription.controller.ts b/apps/api/src/app/subscription/subscription.controller.ts
index 7aef702736..f4ca6d4272 100644
--- a/apps/api/src/app/subscription/subscription.controller.ts
+++ b/apps/api/src/app/subscription/subscription.controller.ts
@@ -116,7 +116,7 @@ export class SubscriptionController {
@Body() { couponId, priceId }: { couponId: string; priceId: string }
) {
try {
- return await this.subscriptionService.createCheckoutSession({
+ return this.subscriptionService.createCheckoutSession({
couponId,
priceId,
user: this.request.user
diff --git a/apps/api/src/app/user/user.controller.ts b/apps/api/src/app/user/user.controller.ts
index 541c7b1785..14c545192f 100644
--- a/apps/api/src/app/user/user.controller.ts
+++ b/apps/api/src/app/user/user.controller.ts
@@ -135,7 +135,7 @@ export class UserController {
}
}
- return await this.userService.updateUserSetting({
+ return this.userService.updateUserSetting({
userSettings,
userId: this.request.user.id
});