Skip to content

Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍

Feature/add horizontal lines to separate delete actions in menus (#3805)

Thomas Kaule301dc5612f0
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 38fb0dde27..2a89208729 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed
+- Improved the usability of various action menus by introducing horizontal lines to separate the delete action
- Considered the user’s language in the link of the access table to share the portfolio
- Improved the language localization for German (`de`)
diff --git a/apps/client/src/app/components/access-table/access-table.component.html b/apps/client/src/app/components/access-table/access-table.component.html
index 8716873a7a..2a20e46317 100644
--- a/apps/client/src/app/components/access-table/access-table.component.html
+++ b/apps/client/src/app/components/access-table/access-table.component.html
@@ -69,6 +69,7 @@
<button mat-menu-item (click)="onCopyToClipboard(element.id)">
<ng-container i18n>Copy link to clipboard</ng-container>
</button>
+ <hr class="my-0" />
}
<button mat-menu-item (click)="onDeleteAccess(element.id)">
<ng-container i18n>Revoke</ng-container>
diff --git a/apps/client/src/app/components/accounts-table/accounts-table.component.html b/apps/client/src/app/components/accounts-table/accounts-table.component.html
index f5039395b3..ecb51fc29c 100644
--- a/apps/client/src/app/components/accounts-table/accounts-table.component.html
+++ b/apps/client/src/app/components/accounts-table/accounts-table.component.html
@@ -278,6 +278,7 @@
<span i18n>Edit</span>
</span>
</button>
+ <hr class="m-0" />
<button
mat-menu-item
[disabled]="element.transactionCount > 0"
diff --git a/apps/client/src/app/components/admin-jobs/admin-jobs.html b/apps/client/src/app/components/admin-jobs/admin-jobs.html
index ef46d766e2..9a82cdbbea 100644
--- a/apps/client/src/app/components/admin-jobs/admin-jobs.html
+++ b/apps/client/src/app/components/admin-jobs/admin-jobs.html
@@ -175,6 +175,7 @@
<button mat-menu-item (click)="onExecuteJob(element.id)">
<ng-container i18n>Execute Job</ng-container>
</button>
+ <hr class="m-0" />
<button mat-menu-item (click)="onDeleteJob(element.id)">
<ng-container i18n>Delete Job</ng-container>
</button>
diff --git a/apps/client/src/app/components/admin-market-data/admin-market-data.html b/apps/client/src/app/components/admin-market-data/admin-market-data.html
index a151d1cd01..de5707d02f 100644
--- a/apps/client/src/app/components/admin-market-data/admin-market-data.html
+++ b/apps/client/src/app/components/admin-market-data/admin-market-data.html
@@ -197,6 +197,7 @@
<button mat-menu-item (click)="onGatherProfileData()">
<ng-container i18n>Gather Profile Data</ng-container>
</button>
+ <hr class="m-0" />
<button
mat-menu-item
[disabled]="!selection.hasValue()"
@@ -230,6 +231,7 @@
<span i18n>Edit</span>
</span>
</a>
+ <hr class="m-0" />
<button
mat-menu-item
[disabled]="
diff --git a/apps/client/src/app/components/admin-market-data/asset-profile-dialog/asset-profile-dialog.html b/apps/client/src/app/components/admin-market-data/asset-profile-dialog/asset-profile-dialog.html
index 3e39109610..a5d2205d2c 100644
--- a/apps/client/src/app/components/admin-market-data/asset-profile-dialog/asset-profile-dialog.html
+++ b/apps/client/src/app/components/admin-market-data/asset-profile-dialog/asset-profile-dialog.html
@@ -44,6 +44,7 @@
>
<ng-container i18n>Gather Profile Data</ng-container>
</button>
+ <hr class="m-0" />
<button
mat-menu-item
type="button"
diff --git a/apps/client/src/app/components/admin-overview/admin-overview.html b/apps/client/src/app/components/admin-overview/admin-overview.html
index a1bce76166..ba8545d16c 100644
--- a/apps/client/src/app/components/admin-overview/admin-overview.html
+++ b/apps/client/src/app/components/admin-overview/admin-overview.html
@@ -79,6 +79,7 @@
</span>
</a>
@if (customCurrencies.includes(exchangeRate.label2)) {
+ <hr class="m-0" />
<button
mat-menu-item
(click)="onDeleteCurrency(exchangeRate.label2)"
diff --git a/apps/client/src/app/components/admin-platform/admin-platform.component.html b/apps/client/src/app/components/admin-platform/admin-platform.component.html
index f5f766838a..c71594e45e 100644
--- a/apps/client/src/app/components/admin-platform/admin-platform.component.html
+++ b/apps/client/src/app/components/admin-platform/admin-platform.component.html
@@ -92,6 +92,7 @@
<span i18n>Edit</span>
</span>
</button>
+ <hr class="m-0" />
<button
mat-menu-item
[disabled]="element.accountCount > 0"
diff --git a/apps/client/src/app/components/admin-tag/admin-tag.component.html b/apps/client/src/app/components/admin-tag/admin-tag.component.html
index c6e7f00fec..046d0a0a57 100644
--- a/apps/client/src/app/components/admin-tag/admin-tag.component.html
+++ b/apps/client/src/app/components/admin-tag/admin-tag.component.html
@@ -71,6 +71,7 @@
<span i18n>Edit</span>
</span>
</button>
+ <hr class="m-0" />
<button
mat-menu-item
[disabled]="element.activityCount > 0"
diff --git a/apps/client/src/app/components/admin-users/admin-users.html b/apps/client/src/app/components/admin-users/admin-users.html
index b65b7c821b..2c806684e6 100644
--- a/apps/client/src/app/components/admin-users/admin-users.html
+++ b/apps/client/src/app/components/admin-users/admin-users.html
@@ -218,6 +218,7 @@
<span i18n>Impersonate User</span>
</span>
</button>
+ <hr class="m-0" />
}
<button
mat-menu-item
diff --git a/libs/ui/src/lib/activities-table/activities-table.component.html b/libs/ui/src/lib/activities-table/activities-table.component.html
index cb8115d3e2..4fdc41c592 100644
--- a/libs/ui/src/lib/activities-table/activities-table.component.html
+++ b/libs/ui/src/lib/activities-table/activities-table.component.html
@@ -55,6 +55,7 @@
</span>
</button>
}
+ <hr class="m-0" />
<button
class="align-items-center d-flex"
mat-menu-item
@@ -445,6 +446,7 @@
<span i18n>Export Draft as ICS</span>
</span>
</button>
+ <hr class="m-0" />
<button
mat-menu-item
[disabled]="!hasPermissionToDeleteActivity"