Skip to content

Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍

Feature/switch typescript-eslint no-unused-expressions rule to error (#3872)

Thomas Kaule715ce14e538
diff --git a/.eslintrc.json b/.eslintrc.json
index 59b7e8b894..4078da0e8c 100644
--- a/.eslintrc.json
+++ b/.eslintrc.json
@@ -107,7 +107,6 @@
"@typescript-eslint/no-unsafe-argument": "warn",
"@typescript-eslint/no-unsafe-assignment": "warn",
"@typescript-eslint/no-unsafe-enum-comparison": "warn",
- "@typescript-eslint/no-unused-expressions": "warn",
"@typescript-eslint/no-unsafe-member-access": "warn",
"@typescript-eslint/no-unsafe-return": "warn",
"@typescript-eslint/no-unused-vars": "warn",
diff --git a/libs/ui/src/lib/activities-table/activities-table.component.ts b/libs/ui/src/lib/activities-table/activities-table.component.ts
index 4f8fff9043..67f81adceb 100644
--- a/libs/ui/src/lib/activities-table/activities-table.component.ts
+++ b/libs/ui/src/lib/activities-table/activities-table.component.ts
@@ -269,9 +269,13 @@ export class GfActivitiesTableComponent
}
public toggleAllRows() {
- this.areAllRowsSelected()
- ? this.selectedRows.clear()
- : this.dataSource.data.forEach((row) => this.selectedRows.select(row));
+ if (this.areAllRowsSelected()) {
+ this.selectedRows.clear();
+ } else {
+ this.dataSource.data.forEach((row) => {
+ this.selectedRows.select(row);
+ });
+ }
this.selectedActivities.emit(this.selectedRows.selected);
}