Skip to content

Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍

Task/set change detection strategy to OnPush in users of admin control panel (#7266)

David Requenoe9c48de49090
diff --git a/CHANGELOG.md b/CHANGELOG.md
index e968ebdbaa..6d127948f1 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed
- Set the change detection strategy to `OnPush` in the _FIRE_ page
+- Set the change detection strategy to `OnPush` in the users section of the admin control panel
- Improved the language localization for Dutch (`nl`)
- Improved the language localization for French (`fr`)
- Improved the language localization for German (`de`)
diff --git a/apps/client/src/app/components/admin-users/admin-users.component.ts b/apps/client/src/app/components/admin-users/admin-users.component.ts
index 5460745f58..4b9848cf81 100644
--- a/apps/client/src/app/components/admin-users/admin-users.component.ts
+++ b/apps/client/src/app/components/admin-users/admin-users.component.ts
@@ -27,6 +27,7 @@ import { GfValueComponent } from '@ghostfolio/ui/value';
import { CommonModule } from '@angular/common';
import {
+ ChangeDetectionStrategy,
ChangeDetectorRef,
Component,
computed,
@@ -67,6 +68,7 @@ import { interval } from 'rxjs';
import { switchMap, tap } from 'rxjs/operators';
@Component({
+ changeDetection: ChangeDetectionStrategy.OnPush,
imports: [
CommonModule,
GfPremiumIndicatorComponent,
@@ -165,6 +167,8 @@ export class GfAdminUsersComponent implements OnInit {
this.user.permissions,
permissions.impersonateAllUsers
);
+
+ this.changeDetectorRef.markForCheck();
}
}),
switchMap(() => this.route.paramMap)
@@ -196,6 +200,8 @@ export class GfAdminUsersComponent implements OnInit {
pageIndex: this.paginator().pageIndex,
showLoading: false
});
+
+ this.changeDetectorRef.markForCheck();
});
}