Skip to content

Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍

Task/migrate open page component to standalone (#5645)

s-vamshif122bd996b0e
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 7d5425fc5a..5047e97bbf 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Improved the usability of the _Cancel_ / _Close_ buttons in the create watchlist item dialog
- Refactored the `fireWealth` from `number` type to a structured object in the summary of the portfolio details endpoint
+- Refactored the _Open Startup_ (`/open`) page to standalone
- Refactored the symbol pipe to standalone
### Fixed
diff --git a/apps/client/src/app/app-routing.module.ts b/apps/client/src/app/app-routing.module.ts
index 53db1f06b3..5c5eadcabb 100644
--- a/apps/client/src/app/app-routing.module.ts
+++ b/apps/client/src/app/app-routing.module.ts
@@ -94,7 +94,7 @@ const routes: Routes = [
{
path: publicRoutes.openStartup.path,
loadChildren: () =>
- import('./pages/open/open-page.module').then((m) => m.OpenPageModule)
+ import('./pages/open/open-page.routes').then((m) => m.routes)
},
{
path: internalRoutes.portfolio.path,
diff --git a/apps/client/src/app/pages/open/open-page-routing.module.ts b/apps/client/src/app/pages/open/open-page-routing.module.ts
deleted file mode 100644
index c56fe80bad..0000000000
--- a/apps/client/src/app/pages/open/open-page-routing.module.ts
+++ /dev/null
@@ -1,22 +0,0 @@
-import { AuthGuard } from '@ghostfolio/client/core/auth.guard';
-import { publicRoutes } from '@ghostfolio/common/routes/routes';
-
-import { NgModule } from '@angular/core';
-import { RouterModule, Routes } from '@angular/router';
-
-import { OpenPageComponent } from './open-page.component';
-
-const routes: Routes = [
- {
- canActivate: [AuthGuard],
- component: OpenPageComponent,
- path: '',
- title: publicRoutes.openStartup.title
- }
-];
-
-@NgModule({
- imports: [RouterModule.forChild(routes)],
- exports: [RouterModule]
-})
-export class OpenPageRoutingModule {}
diff --git a/apps/client/src/app/pages/open/open-page.component.ts b/apps/client/src/app/pages/open/open-page.component.ts
index c876c3cc8e..6521951dac 100644
--- a/apps/client/src/app/pages/open/open-page.component.ts
+++ b/apps/client/src/app/pages/open/open-page.component.ts
@@ -1,18 +1,28 @@
import { DataService } from '@ghostfolio/client/services/data.service';
import { UserService } from '@ghostfolio/client/services/user/user.service';
import { Statistics, User } from '@ghostfolio/common/interfaces';
-
-import { ChangeDetectorRef, Component, OnDestroy, OnInit } from '@angular/core';
+import { GfValueComponent } from '@ghostfolio/ui/value';
+
+import { CommonModule } from '@angular/common';
+import {
+ ChangeDetectorRef,
+ Component,
+ CUSTOM_ELEMENTS_SCHEMA,
+ OnDestroy,
+ OnInit
+} from '@angular/core';
+import { MatCardModule } from '@angular/material/card';
import { Subject, takeUntil } from 'rxjs';
@Component({
host: { class: 'page' },
+ imports: [CommonModule, GfValueComponent, MatCardModule],
+ schemas: [CUSTOM_ELEMENTS_SCHEMA],
selector: 'gf-open-page',
styleUrls: ['./open-page.scss'],
- templateUrl: './open-page.html',
- standalone: false
+ templateUrl: './open-page.html'
})
-export class OpenPageComponent implements OnDestroy, OnInit {
+export class GfOpenPageComponent implements OnDestroy, OnInit {
public statistics: Statistics;
public user: User;
diff --git a/apps/client/src/app/pages/open/open-page.module.ts b/apps/client/src/app/pages/open/open-page.module.ts
deleted file mode 100644
index ab48f2d4a9..0000000000
--- a/apps/client/src/app/pages/open/open-page.module.ts
+++ /dev/null
@@ -1,20 +0,0 @@
-import { GfValueComponent } from '@ghostfolio/ui/value';
-
-import { CommonModule } from '@angular/common';
-import { CUSTOM_ELEMENTS_SCHEMA, NgModule } from '@angular/core';
-import { MatCardModule } from '@angular/material/card';
-
-import { OpenPageRoutingModule } from './open-page-routing.module';
-import { OpenPageComponent } from './open-page.component';
-
-@NgModule({
- declarations: [OpenPageComponent],
- imports: [
- CommonModule,
- GfValueComponent,
- MatCardModule,
- OpenPageRoutingModule
- ],
- schemas: [CUSTOM_ELEMENTS_SCHEMA]
-})
-export class OpenPageModule {}
diff --git a/apps/client/src/app/pages/open/open-page.routes.ts b/apps/client/src/app/pages/open/open-page.routes.ts
new file mode 100644
index 0000000000..da04d6f5b7
--- /dev/null
+++ b/apps/client/src/app/pages/open/open-page.routes.ts
@@ -0,0 +1,15 @@
+import { AuthGuard } from '@ghostfolio/client/core/auth.guard';
+import { publicRoutes } from '@ghostfolio/common/routes/routes';
+
+import { Routes } from '@angular/router';
+
+import { GfOpenPageComponent } from './open-page.component';
+
+export const routes: Routes = [
+ {
+ canActivate: [AuthGuard],
+ component: GfOpenPageComponent,
+ path: '',
+ title: publicRoutes.openStartup.title
+ }
+];