Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍
TypeScript angularetffinancefintechghostfoliohacktoberfestinvestingnestjsosspersonal-financeportfolioprismasoftwarestocktrackertradingtypescriptwealth-managementweb
Feature/improve styling of benchmarks (#1131)
Thomas Kaulf127e7c61a64
diff --git a/CHANGELOG.md b/CHANGELOG.mdindex 1bd17aead3..32bce24986 100644--- a/CHANGELOG.md+++ b/CHANGELOG.md@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0### Changed- Simplified the initialization of the exchange rate service+- Improved the styling of the benchmarks in the markets overview## 1.177.0 - 04.08.2022diff --git a/apps/client/src/app/components/home-market/home-market.html b/apps/client/src/app/components/home-market/home-market.htmlindex e8cf52beeb..b0a01a43c9 100644--- a/apps/client/src/app/components/home-market/home-market.html+++ b/apps/client/src/app/components/home-market/home-market.html@@ -34,6 +34,7 @@<ngx-skeleton-loader*ngIf="isLoading"animation="pulse"+ class="px-2 py-3"[theme]="{height: '1.5rem',width: '100%'diff --git a/libs/ui/src/lib/benchmark/benchmark.component.html b/libs/ui/src/lib/benchmark/benchmark.component.htmlindex a0fa4c1cc8..c6ec23f69f 100644--- a/libs/ui/src/lib/benchmark/benchmark.component.html+++ b/libs/ui/src/lib/benchmark/benchmark.component.html@@ -1,50 +1,50 @@-<table class="gf-table w-100">- <thead>- <tr class="mat-header-row">- <th class="mat-header-cell px-1 py-2" i18n>Index</th>- <th class="mat-header-cell px-1 py-2 text-right">- <span class="d-none d-sm-block text-nowrap" i18n- >Change from All Time High</span- >- <span class="d-block d-sm-none text-nowrap" i18n>from ATH</span>- </th>- <th class="mat-header-cell px-1 py-2 text-right" i18n></th>- </tr>- </thead>- <tbody>- <tr *ngFor="let benchmark of benchmarks" class="mat-row">- <td class="mat-cell px-1 py-2">- <div class="d-flex align-items-center">- {{ benchmark.name }}- </div>- </td>- <td class="mat-cell px-1 py-2 text-right">- <gf-value- class="d-inline-block justify-content-end"- size="medium"- [isPercent]="true"- [locale]="locale"- [ngClass]="{- 'text-danger':- benchmark?.performances?.allTimeHigh?.performancePercent < 0,- 'text-success':- benchmark?.performances?.allTimeHigh?.performancePercent > 0- }"- [value]="- benchmark?.performances?.allTimeHigh?.performancePercent ??- undefined- "- ></gf-value>- </td>- <td class="mat-cell px-1 py-2">- <div- *ngIf="benchmark?.marketCondition"- class="text-center"- [title]="benchmark?.marketCondition"- >- {{ resolveMarketCondition(benchmark.marketCondition).emoji }}- </div>- </td>- </tr>- </tbody>+<table class="gf-table w-100" mat-table [dataSource]="benchmarks">+ <ng-container matColumnDef="name">+ <th *matHeaderCellDef class="px-2" i18n mat-header-cell>Index</th>+ <td *matCellDef="let element" class="px-2" mat-cell>+ {{ element?.name }}+ </td>+ </ng-container>++ <ng-container matColumnDef="change">+ <th *matHeaderCellDef class="text-right" mat-header-cell>+ <span class="d-none d-sm-block text-nowrap" i18n+ >Change from All Time High</span+ >+ <span class="d-block d-sm-none text-nowrap" i18n>from ATH</span>+ </th>+ <td *matCellDef="let element" class="text-right" mat-cell>+ <gf-value+ class="d-inline-block justify-content-end"+ size="medium"+ [isPercent]="true"+ [locale]="locale"+ [ngClass]="{+ 'text-danger':+ element?.performances?.allTimeHigh?.performancePercent < 0,+ 'text-success':+ element?.performances?.allTimeHigh?.performancePercent > 0+ }"+ [value]="+ element?.performances?.allTimeHigh?.performancePercent ?? undefined+ "+ ></gf-value>+ </td>+ </ng-container>++ <ng-container matColumnDef="marketCondition">+ <th *matHeaderCellDef mat-header-cell></th>+ <td *matCellDef="let element" class="px-0" mat-cell>+ <div+ *ngIf="element?.marketCondition"+ class="text-center"+ [title]="element?.marketCondition"+ >+ {{ resolveMarketCondition(element.marketCondition).emoji }}+ </div>+ </td>+ </ng-container>++ <tr mat-header-row *matHeaderRowDef="displayedColumns"></tr>+ <tr mat-row *matRowDef="let row; columns: displayedColumns"></tr></table>diff --git a/libs/ui/src/lib/benchmark/benchmark.component.ts b/libs/ui/src/lib/benchmark/benchmark.component.tsindex c1e35f4386..a5c117c244 100644--- a/libs/ui/src/lib/benchmark/benchmark.component.ts+++ b/libs/ui/src/lib/benchmark/benchmark.component.ts@@ -18,6 +18,7 @@ export class BenchmarkComponent implements OnChanges {@Input() benchmarks: Benchmark[];@Input() locale: string;+ public displayedColumns = ['name', 'change', 'marketCondition'];public resolveMarketCondition = resolveMarketCondition;public constructor() {}diff --git a/libs/ui/src/lib/benchmark/benchmark.module.ts b/libs/ui/src/lib/benchmark/benchmark.module.tsindex 3a0eeb5dd7..1768aa39ff 100644--- a/libs/ui/src/lib/benchmark/benchmark.module.ts+++ b/libs/ui/src/lib/benchmark/benchmark.module.ts@@ -1,5 +1,6 @@import { CommonModule } from '@angular/common';import { CUSTOM_ELEMENTS_SCHEMA, NgModule } from '@angular/core';+import { MatTableModule } from '@angular/material/table';import { NgxSkeletonLoaderModule } from 'ngx-skeleton-loader';import { GfValueModule } from '../value';@@ -8,7 +9,12 @@ import { BenchmarkComponent } from './benchmark.component';@NgModule({declarations: [BenchmarkComponent],exports: [BenchmarkComponent],- imports: [CommonModule, GfValueModule, NgxSkeletonLoaderModule],+ imports: [+ CommonModule,+ GfValueModule,+ MatTableModule,+ NgxSkeletonLoaderModule+ ],schemas: [CUSTOM_ELEMENTS_SCHEMA]})export class GfBenchmarkModule {}