Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍
TypeScript angularetffinancefintechghostfoliohacktoberfestinvestingnestjsosspersonal-financeportfolioprismasoftwarestocktrackertradingtypescriptwealth-managementweb
Task/remove deprecated activities from portfolio holding response (#6157)
Thomas Kaulf19e417068ef
diff --git a/CHANGELOG.md b/CHANGELOG.mdindex 5bbf0c8d47..779b249817 100644--- a/CHANGELOG.md+++ b/CHANGELOG.md@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0### Changed- Removed the deprecated platforms from the info service+- Removed the deprecated activities from the endpoint `GET api/v1/portfolio/holding/:dataSource/:symbol`## 2.230.0 - 2026-01-14diff --git a/apps/api/src/app/portfolio/portfolio.service.ts b/apps/api/src/app/portfolio/portfolio.service.tsindex d9783f34c4..5fc2224ebc 100644--- a/apps/api/src/app/portfolio/portfolio.service.ts+++ b/apps/api/src/app/portfolio/portfolio.service.ts@@ -920,7 +920,6 @@ export class PortfolioService {marketPriceMin,SymbolProfile,tags,- activities: activitiesOfHolding,activitiesCount: transactionCount,averagePrice: averagePrice.toNumber(),dataProviderInfo: portfolioCalculator.getDataProviderInfos()?.[0],diff --git a/libs/common/src/lib/interfaces/responses/portfolio-holding-response.interface.ts b/libs/common/src/lib/interfaces/responses/portfolio-holding-response.interface.tsindex 4ec42933a8..95c1c3689a 100644--- a/libs/common/src/lib/interfaces/responses/portfolio-holding-response.interface.ts+++ b/libs/common/src/lib/interfaces/responses/portfolio-holding-response.interface.ts@@ -1,5 +1,4 @@import {- Activity,Benchmark,DataProviderInfo,EnhancedSymbolProfile,@@ -9,9 +8,6 @@ import {import { Tag } from '@prisma/client';export interface PortfolioHoldingResponse {- /** @deprecated */- activities: Activity[];-activitiesCount: number;averagePrice: number;dataProviderInfo: DataProviderInfo;diff --git a/libs/ui/src/lib/services/data.service.ts b/libs/ui/src/lib/services/data.service.tsindex 21eec06c3b..37443cd205 100644--- a/libs/ui/src/lib/services/data.service.ts+++ b/libs/ui/src/lib/services/data.service.ts@@ -424,22 +424,9 @@ export class DataService {dataSource: DataSource;symbol: string;}) {- return this.http- .get<PortfolioHoldingResponse>(- `/api/v1/portfolio/holding/${dataSource}/${symbol}`- )- .pipe(- map((data) => {- if (data.activities) {- for (const order of data.activities) {- order.createdAt = parseISO(order.createdAt as unknown as string);- order.date = parseISO(order.date as unknown as string);- }- }-- return data;- })- );+ return this.http.get<PortfolioHoldingResponse>(+ `/api/v1/portfolio/holding/${dataSource}/${symbol}`+ );}public fetchInfo(): InfoItem {