Skip to content

Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍

Feature/set validation rule to positive number in cash balance transfer (#2544)

Thomas Kaulf5ad1d2d245b
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 9a6074cfde..5831763586 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Improved the style and wording of the position detail dialog
- Improved the validation in the activities import (expects positive values for `fee`, `quantity` and `unitPrice`)
+- Improved the validation in the cash balance transfer from one to another account (expects a positive value)
- Changed the currency selector in the create or update account dialog to `@angular/material/autocomplete`
- Upgraded `uuid` from version `9.0.0` to `9.0.1`
- Upgraded `yahoo-finance2` from version `2.8.0` to `2.8.1`
diff --git a/apps/api/src/app/account/transfer-balance.dto.ts b/apps/api/src/app/account/transfer-balance.dto.ts
index fb602033ea..93a25d7ccf 100644
--- a/apps/api/src/app/account/transfer-balance.dto.ts
+++ b/apps/api/src/app/account/transfer-balance.dto.ts
@@ -1,4 +1,4 @@
-import { IsNumber, IsString } from 'class-validator';
+import { IsNumber, IsPositive, IsString } from 'class-validator';
export class TransferBalanceDto {
@IsString()
@@ -8,5 +8,6 @@ export class TransferBalanceDto {
accountIdTo: string;
@IsNumber()
+ @IsPositive()
balance: number;
}