Skip to content

Open Source Wealth Management Software. Angular + NestJS + Prisma + Nx + TypeScript 🤍

Bugfix/loading state of holdings table on portfolio holdings page (#7788)

Thomas Kaulfc083fb0cd36
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 646c59ecb9..ad6228c2ac 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed
- Fixed the loading state of the accounts table on the accounts page
+- Fixed the loading state of the holdings table on the portfolio holdings page
## 3.65.0 - 2026-08-31
diff --git a/apps/client/src/app/components/home-holdings/home-holdings.html b/apps/client/src/app/components/home-holdings/home-holdings.html
index df6d57c0e9..b55b1c54ef 100644
--- a/apps/client/src/app/components/home-holdings/home-holdings.html
+++ b/apps/client/src/app/components/home-holdings/home-holdings.html
@@ -37,7 +37,7 @@
}
<div [class.d-none]="holdingsViewMode !== 'TABLE'">
<gf-holdings-table
- [holdings]="holdings ?? []"
+ [holdings]="holdings"
[locale]="user?.settings?.locale ?? DEFAULT_LOCALE"
(holdingClicked)="onHoldingClicked($event)"
/>
diff --git a/libs/ui/src/lib/holdings-table/holdings-table.component.ts b/libs/ui/src/lib/holdings-table/holdings-table.component.ts
index 7fe21720ef..1bbfa515b1 100644
--- a/libs/ui/src/lib/holdings-table/holdings-table.component.ts
+++ b/libs/ui/src/lib/holdings-table/holdings-table.component.ts
@@ -50,7 +50,7 @@ export class GfHoldingsTableComponent {
public readonly hasPermissionToOpenDetails = input(true);
public readonly hasPermissionToShowQuantities = input(true);
public readonly hasPermissionToShowValues = input(true);
- public readonly holdings = input.required<PortfolioPosition[]>();
+ public readonly holdings = input.required<PortfolioPosition[] | undefined>();
public readonly locale = input(getLocale());
public readonly pageSize = model(Number.MAX_SAFE_INTEGER);
@@ -89,7 +89,7 @@ export class GfHoldingsTableComponent {
// Reactive data update
effect(() => {
- this.dataSource.data = this.holdings();
+ this.dataSource.data = this.holdings() ?? [];
});
// Reactive view connection