Skip to content

Git designed for AI agents.

6.5 KB
Raw Blame
package commit

import (
	"testing"

	"github.com/feder-cr/git-ai/internal/git/gittest"
	"github.com/feder-cr/git-ai/internal/git/localrepo"
	"github.com/feder-cr/git-ai/internal/gitaly/storage"
	"github.com/feder-cr/git-ai/internal/structerr"
	"github.com/feder-cr/git-ai/internal/testhelper"
	"github.com/feder-cr/git-ai/proto/go/gitalypb"
)

func TestLastCommitForPath(t *testing.T) {
	t.Parallel()

	ctx := testhelper.Context(t)
	cfg, client := setupCommitService(t, ctx)

	repoProto, repoPath := gittest.CreateRepository(t, ctx, cfg)
	repo := localrepo.NewTestRepo(t, cfg, repoProto)

	initialCommitID := gittest.WriteCommit(t, cfg, repoPath, gittest.WithTreeEntries(
		gittest.TreeEntry{Path: "file", Content: "unmodified", Mode: "100644"},
		gittest.TreeEntry{Path: "delete-me", Content: "something", Mode: "100644"},
	))
	deletedCommitID, deletedCommit := writeCommit(t, ctx, cfg, repo, gittest.WithParents(initialCommitID), gittest.WithTreeEntries(
		gittest.TreeEntry{Path: "file", Content: "unmodified", Mode: "100644"},
	))
	modifiedCommitID, modifiedCommit := writeCommit(t, ctx, cfg, repo, gittest.WithParents(deletedCommitID), gittest.WithTreeEntries(
		gittest.TreeEntry{Path: "file", Content: "modified", Mode: "100644"},
	))
	globCommitID, globCommit := writeCommit(t, ctx, cfg, repo, gittest.WithParents(modifiedCommitID), gittest.WithTreeEntries(
		gittest.TreeEntry{Path: "file", Content: "modified", Mode: "100644"},
		gittest.TreeEntry{Path: ":wq", Content: "glob", Mode: "100644"},
	))
	latestCommitID, latestCommit := writeCommit(t, ctx, cfg, repo, gittest.WithParents(globCommitID), gittest.WithTreeEntries(
		gittest.TreeEntry{Path: "file", Content: "modified", Mode: "100644"},
		gittest.TreeEntry{Path: ":wq", Content: "glob", Mode: "100644"},
		gittest.TreeEntry{Path: "uninteresting", Content: "uninteresting", Mode: "100644"},
	))

	for _, tc := range []struct {
		desc             string
		request          *gitalypb.LastCommitForPathRequest
		expectedErr      error
		expectedResponse *gitalypb.LastCommitForPathResponse
	}{
		{
			desc: "invalid storage",
			request: &gitalypb.LastCommitForPathRequest{
				Repository: &gitalypb.Repository{
					StorageName:  "fake",
					RelativePath: gittest.NewRepositoryName(t),
				},
				Revision: []byte("some-branch"),
			},
			expectedErr: testhelper.ToInterceptedMetadata(structerr.NewInvalidArgument(
				"%w", storage.NewStorageNotFoundError("fake"),
			)),
		},
		{
			desc: "unset repository",
			request: &gitalypb.LastCommitForPathRequest{
				Repository: nil,
			},
			expectedErr: structerr.NewInvalidArgument("%w", storage.ErrRepositoryNotSet),
		},
		{
			desc: "unset revision",
			request: &gitalypb.LastCommitForPathRequest{
				Repository: repoProto,
			},
			expectedErr: structerr.NewInvalidArgument("empty revision"),
		},
		{
			desc: "invalid revision",
			request: &gitalypb.LastCommitForPathRequest{
				Repository: repoProto,
				Path:       []byte("foo/bar"),
				Revision:   []byte("--output=/meow"),
			},
			expectedErr: structerr.NewInvalidArgument("revision can't start with '-'"),
		},
		{
			desc: "path present",
			request: &gitalypb.LastCommitForPathRequest{
				Repository: repoProto,
				Revision:   []byte(latestCommitID),
				Path:       []byte("file"),
			},
			expectedResponse: &gitalypb.LastCommitForPathResponse{
				Commit: modifiedCommit,
			},
		},
		{
			desc: "path empty",
			request: &gitalypb.LastCommitForPathRequest{
				Repository: repoProto,
				Revision:   []byte(latestCommitID),
				Path:       []byte(""),
			},
			expectedResponse: &gitalypb.LastCommitForPathResponse{
				Commit: latestCommit,
			},
		},
		{
			desc: "path is '/'",
			request: &gitalypb.LastCommitForPathRequest{
				Repository: repoProto,
				Revision:   []byte(latestCommitID),
				Path:       []byte("/"),
			},
			expectedResponse: &gitalypb.LastCommitForPathResponse{
				Commit: latestCommit,
			},
		},
		{
			desc: "path is '*'",
			request: &gitalypb.LastCommitForPathRequest{
				Repository: repoProto,
				Revision:   []byte(latestCommitID),
				Path:       []byte("*"),
			},
			expectedResponse: &gitalypb.LastCommitForPathResponse{
				Commit: latestCommit,
			},
		},
		{
			desc: "absolute path escaping",
			request: &gitalypb.LastCommitForPathRequest{
				Repository: repoProto,
				Revision:   []byte(latestCommitID),
				Path:       []byte(repoPath),
			},
			expectedErr: testhelper.ToInterceptedMetadata(
				structerr.NewInvalidArgument("path is an absolute path").WithMetadata("path", repoPath),
			),
		},
		{
			desc: "relative path escaping root directory",
			request: &gitalypb.LastCommitForPathRequest{
				Repository: repoProto,
				Revision:   []byte(latestCommitID),
				Path:       []byte("foo/bar/../../../baz"),
			},
			expectedErr: testhelper.ToInterceptedMetadata(
				structerr.NewInvalidArgument("path escapes repository").WithMetadata("path", "foo/bar/../../../baz"),
			),
		},
		{
			desc: "deleted file",
			request: &gitalypb.LastCommitForPathRequest{
				Repository: repoProto,
				Revision:   []byte(latestCommitID),
				Path:       []byte("delete-me"),
			},
			expectedResponse: &gitalypb.LastCommitForPathResponse{
				Commit: deletedCommit,
			},
		},
		{
			desc: "missing file",
			request: &gitalypb.LastCommitForPathRequest{
				Repository: repoProto,
				Revision:   []byte(latestCommitID),
				Path:       []byte("does-not-exist"),
			},
			expectedResponse: &gitalypb.LastCommitForPathResponse{
				Commit: nil,
			},
		},
		{
			desc: "not existing revision",
			request: &gitalypb.LastCommitForPathRequest{
				Repository: repoProto,
				Revision:   []byte("refs/heads/does-not-exist"),
				Path:       []byte("does-not-exist"),
			},
			expectedResponse: &gitalypb.LastCommitForPathResponse{
				Commit: nil,
			},
		},
		{
			desc: "glob with literal pathspec",
			request: &gitalypb.LastCommitForPathRequest{
				Repository:      repoProto,
				Revision:        []byte(latestCommitID),
				Path:            []byte(":wq"),
				LiteralPathspec: true,
			},
			expectedResponse: &gitalypb.LastCommitForPathResponse{
				Commit: globCommit,
			},
		},
		{
			desc: "glob without literal pathspec",
			request: &gitalypb.LastCommitForPathRequest{
				Repository:      repoProto,
				Revision:        []byte(latestCommitID),
				Path:            []byte(":wq"),
				LiteralPathspec: false,
			},
			expectedResponse: &gitalypb.LastCommitForPathResponse{
				Commit: nil,
			},
		},
	} {
		t.Run(tc.desc, func(t *testing.T) {
			t.Parallel()

			response, err := client.LastCommitForPath(ctx, tc.request)
			testhelper.RequireGrpcError(t, tc.expectedErr, err)
			testhelper.ProtoEqual(t, tc.expectedResponse, response)
		})
	}
}