Skip to content

Git designed for AI agents.

docs: PLAN10 15.25: renames_context is not merged, it stays on branch c1-renames

Federico Elia13d1df710a2a
diff --git a/doc/graft/PLAN10.md b/doc/graft/PLAN10.md
index 0596326..4df1b6c 100644
--- a/doc/graft/PLAN10.md
+++ b/doc/graft/PLAN10.md
@@ -2568,7 +2568,7 @@ the case file does not show, and it says nothing about the wrong answers that pa
**The answer.** The pre-registered primary test is **not met: B (`renames_context`) is not better than A.** On the 252 files that have a conflict region next to a rename the other side made outside it, B lands 11 wrong answers against A's 17 (6 fewer), but it also lands 5 fewer right ones
(121 against 126), and the protocol allows a loss of 2. The gain in wrong answers is not significant (exact McNemar on the discordant files, 11 against 5: p = 0.21) and, on the part where the noise was measured (TypeScript + Python), it is 2 files against a noise measure of 1. **The honest reading is "a small possible reduction of wrong answers, paid for by landing fewer files, not distinguishable from noise".**
-`renames_context` stays **off by default** (as the PM conditioned); nothing here changes the closed results of 15.15-15.24.
+`renames_context` is **not merged**: it stays on branch `c1-renames` as a record (without a demonstrated gain it is code to maintain for nothing); nothing here changes the closed results of 15.15-15.24.
**What was tested.** Many of the "rule 4" verdicts (a change not adapted next to the conflict, 15.24) have a common shape: one side renamed an identifier outside the conflict region, the other side's lines inside it, or next to it, still use the old name. B shows the writer those renames and lets it rewrite the listed lines.
* *The method* (`renames_context`, `tools/graft-agents/resolve/llm_renames.go`, branch `c1-renames`, commits 377d378 and 0426960, default off, in `LLMOptions.RenamesContext` and the strategy option `renames_context`): a rename is a token substitution R to A (a name or a dotted path of at most 3 tokens) in the paired lines of a base-to-side hunk that lies **outside every conflict region**, with R absent from the whole side file and present in the region's base, ours or theirs. The prompt lists the rename and up to 12 "uses" (lines of the merged text that still contain R, not written by the renaming side, not written by both), at most 6 renames per region, and accepts
@@ -2616,7 +2616,7 @@ The paired exact tests on the discordant files (landed-wrong: A only against B o
2. *The mechanism works as designed* (45 edits proposed, 37 applied, none refused by the validator) *but is rarely the deciding factor:* B lands mostly the same answers as A; only 15 distinct answers are new. The comparison therefore rests on a few discordant files (16 wrong, 41 right), which is why the p-values are high.
3. *Tuning data:* the TypeScript and Python gain, if any, is on the data the method was tuned on. The cleanest figure, Go held-out, has 14 files (A 3 wrong, B 1): a direction, not evidence.
4. *The label is an AI reference, not a human one* (the PM label of 15.23, calibrated 78.3% on TypeScript, so under its own 80% criterion). The PM's rubric counts UNCLEAR and any disagreement as wrong (none occurred here).
-5. *Nothing is promoted:* `renames_context` is off by default in main. The code (default off) is on branch `c1-renames`; the data, scripts and verdicts are in `c1-work/run/renames/` and `c1-work/scripts/rn_*.py` (report script sha256 `36979f49f13e`), outside the repository.
+5. *Nothing is promoted:* the code (`renames_context`, default off) stays on branch `c1-renames` and is not merged into main. The data, scripts and verdicts are in `c1-work/run/renames/` and `c1-work/scripts/rn_*.py` (report script sha256 `36979f49f13e`), outside the repository.
### Appendix A: the measurement log of section 15