Git designed for AI agents.
e2e: the reference-transaction hook decides alone for an agent write
Federico Eliadd16802c6e04
diff --git a/internal/graft/e2e/e2e_test.go b/internal/graft/e2e/e2e_test.goindex dee43d8..52b499d 100644--- a/internal/graft/e2e/e2e_test.go+++ b/internal/graft/e2e/e2e_test.go@@ -143,7 +143,7 @@ func startExampleUnbatched(t *testing.T) gitalyStack {// startGitaly starts a standalone Gitaly with every service registered and// creates an empty repository on it. The shared token authorizes the setup// calls of the test helpers.-func startGitaly(t *testing.T, graft config.Graft, sharedToken string) gitalyStack {+func startGitaly(t *testing.T, graft config.Graft, sharedToken string, opts ...testserver.GitalyServerOpt) gitalyStack {t.Helper()ctx := featureflag.OutgoingCtxWithFeatureFlag(testhelper.Context(t), featureflag.GPGSigning, false)@@ -155,9 +155,9 @@ func startGitaly(t *testing.T, graft config.Graft, sharedToken string) gitalyStatestcfg.BuildGitalySSH(t, cfg)testcfg.BuildGitalyHooks(t, cfg)- addr := testserver.RunGitalyServer(t, cfg, setup.RegisterAll,+ addr := testserver.RunGitalyServer(t, cfg, setup.RegisterAll, append([]testserver.GitalyServerOpt{testserver.WithGitLabClient(gitlab.NewStandaloneClient(cfg.Graft, testhelper.SharedLogger(t))),- )+ }, opts...)...)cfg.SocketPath = addr// Only the setup call carries gitaly-servers metadata. The context of thediff --git a/internal/graft/e2e/policy_hook_test.go b/internal/graft/e2e/policy_hook_test.gonew file mode 100644index 0000000..697ddd5--- /dev/null+++ b/internal/graft/e2e/policy_hook_test.go@@ -0,0 +1,88 @@+package e2e++import (+ "strings"+ "testing"++ "github.com/stretchr/testify/require"++ "github.com/feder-cr/git-ai/internal/git"+ "github.com/feder-cr/git-ai/internal/git/gittest"+ "github.com/feder-cr/git-ai/internal/git/localrepo"+ "github.com/feder-cr/git-ai/internal/git/updateref"+ "github.com/feder-cr/git-ai/internal/graft/identity"+ "github.com/feder-cr/git-ai/internal/testhelper"+ "github.com/feder-cr/git-ai/internal/testhelper/testserver"+ "github.com/feder-cr/git-ai/proto/go/gitalypb"+)++// TestPolicyHookDecidesForAgentUpdates drives the last layer of the policy on its+// own: the real reference-transaction hook (git runs the gitaly-hooks binary,+// which calls the server's HookService), run by git update-ref with the hooks+// payload that the server builds for a write of an agent, as for an RPC or a+// push. The earlier layers (the pre-receive hook, CheckAgentPolicy, the agents'+// receive.hideRefs) do not take part, so the hook decides alone:+// - refs/graft/x is refused although the policy lets the builder update+// refs/graft/** (startWithAgentPushes), because that namespace is the server's;+// - a branch the policy allows is written;+// - a branch the policy denies (main for the builder) is refused.+//+// git only reports that the hook aborted the transaction, so the reason of each+// refusal is read from the hook's log entry in the server. TestPolicyHoldsOnAgentPushes+// covers the layers before the hook on a real push.+func TestPolicyHookDecidesForAgentUpdates(t *testing.T) {+ t.Parallel()++ logger := testhelper.NewLogger(t)+ logs := testhelper.AddLoggerHook(logger)+ s := startWithAgentPushes(t, testserver.WithLogger(logger))+ mainCommit := writeMain(t, s, map[string]string{"README.md": "hook\n"})+ next := gittest.WriteCommit(t, s.cfg, s.repoPath, gittest.WithParents(git.ObjectID(mainCommit)), gittest.WithMessage("next"))++ // The payload of the hook carries the agent of the context, as for a write that+ // the builder makes with its token.+ ctx := identity.NewContext(s.ctx, identity.Identity{Name: "builder", Source: identity.SourceAgent})+ repo := localrepo.NewTestRepo(t, s.cfg, &gitalypb.Repository{StorageName: s.storage, RelativePath: s.relPath})++ update := func(reference git.ReferenceName, newOID, oldOID git.ObjectID) error {+ t.Helper()+ updater, err := updateref.New(ctx, repo)+ require.NoError(t, err)++ require.NoError(t, updater.Start())+ require.NoError(t, updater.Update(reference, newOID, oldOID))+ commitErr := updater.Commit()+ // A refused transaction ends git update-ref with an error, which Close+ // reports again.+ closeErr := updater.Close()+ if commitErr == nil {+ require.NoError(t, closeErr)+ }+ return commitErr+ }+ // hookDenials returns the reasons of the hook's policy denials logged so far.+ hookDenials := func() []string {+ var reasons []string+ for _, entry := range logs.AllEntries() {+ if entry.Message == "standalone policy denied reference transaction" {+ reasons = append(reasons, entry.Data["reason"].(string))+ }+ }+ return reasons+ }+ zero := gittest.DefaultObjectHash.ZeroOID++ require.NoError(t, update("refs/heads/feature/hook", next, zero))+ require.Equal(t, next.String(), s.git(t, "rev-parse", "refs/heads/feature/hook"))+ require.Empty(t, hookDenials())++ require.Error(t, update("refs/heads/main", next, git.ObjectID(mainCommit)))+ require.Equal(t, mainCommit, s.git(t, "rev-parse", "refs/heads/main"))+ require.Equal(t, []string{`policy denies "builder" to update "refs/heads/main" (rule 3)`}, hookDenials())++ require.Error(t, update("refs/graft/x", next, zero))+ require.Empty(t, s.git(t, "for-each-ref", "refs/graft/"))+ denials := hookDenials()+ require.Len(t, denials, 2)+ require.True(t, strings.HasPrefix(denials[1], `"refs/graft/x" is under refs/graft/, which is reserved for the server`), denials[1])+}diff --git a/internal/graft/e2e/policy_push_test.go b/internal/graft/e2e/policy_push_test.goindex 1ad2d21..1f329af 100644--- a/internal/graft/e2e/policy_push_test.go+++ b/internal/graft/e2e/policy_push_test.go@@ -13,6 +13,7 @@ import ("github.com/feder-cr/git-ai/internal/featureflag""github.com/feder-cr/git-ai/internal/git/gittest""github.com/feder-cr/git-ai/internal/gitaly/config"+ "github.com/feder-cr/git-ai/internal/testhelper/testserver""github.com/feder-cr/git-ai/proto/go/gitalypb")@@ -20,7 +21,7 @@ import (// opened to agents through [graft] agent_rpcs, the operator opt-in of// AGENT-SECURITY.md, and a policy that also lets the builder update// refs/graft/**, so that only the reservation of that namespace can refuse it.-func startWithAgentPushes(t *testing.T) gitalyStack {+func startWithAgentPushes(t *testing.T, opts ...testserver.GitalyServerOpt) gitalyStack {t.Helper()ex := loadExample(t)@@ -29,7 +30,7 @@ func startWithAgentPushes(t *testing.T) gitalyStack {{Actor: "builder", Refs: []string{"refs/graft/**"}, Allow: true},}, ex.graft.Policy...)- return startGitaly(t, ex.graft, ex.sharedToken)+ return startGitaly(t, ex.graft, ex.sharedToken, opts...)}// agentPush pushes refspec from the client repository at clientPath to the