Skip to content

Open-source eCommerce platform for C# and ASP.NET Core 10 with MongoDB. Build multi-store shops and multi-vendor marketplaces with B2B/B2C, REST API, plugins, Vue 3 and Docker.

Admin panel - Elfinder - prevent for import not allowed files

KrzysztofPajak0a79f811e258
diff --git a/src/Web/Grand.Web.Admin/Areas/Admin/Views/Shared/EditorTemplates/Editor.cshtml b/src/Web/Grand.Web.Admin/Areas/Admin/Views/Shared/EditorTemplates/Editor.cshtml
index 64a2253cd..1c0fda4d0 100644
--- a/src/Web/Grand.Web.Admin/Areas/Admin/Views/Shared/EditorTemplates/Editor.cshtml
+++ b/src/Web/Grand.Web.Admin/Areas/Admin/Views/Shared/EditorTemplates/Editor.cshtml
@@ -31,6 +31,7 @@
['view', 'sort']
]
},
+ requestType: 'post',
getFileCallback: function (file, fm) {
var fulltype = file.mime;
if (fulltype.includes("video")) {
diff --git a/src/Web/Grand.Web.Admin/Controllers/ElFinderController.cs b/src/Web/Grand.Web.Admin/Controllers/ElFinderController.cs
index c03f31b9c..79bc4a639 100644
--- a/src/Web/Grand.Web.Admin/Controllers/ElFinderController.cs
+++ b/src/Web/Grand.Web.Admin/Controllers/ElFinderController.cs
@@ -71,6 +71,9 @@ namespace Grand.Web.Admin.Controllers
await SetupConnectorAsync();
var cmd = ConnectorHelper.ParseCommand(Request);
+ if (cmd.Cmd == "upload" && cmd.Files != null && cmd.Files.Any())
+ cmd.Files = cmd.Files.Where(x => !NotAllowedExtensions(Path.GetExtension(x.FileName))).ToList();
+
var ccTokenSource = ConnectorHelper.RegisterCcTokenSource(HttpContext);
var conResult = await _connector.ProcessAsync(cmd, ccTokenSource);
var actionResult = conResult.ToActionResult(HttpContext);
@@ -99,15 +102,22 @@ namespace Grand.Web.Admin.Controllers
Name = "Volume",
MaxUploadConnections = 3
};
- volume.ObjectAttributes = new List<FilteredObjectAttribute>()
- {
+ volume.ObjectAttributes = new List<FilteredObjectAttribute>() {
new FilteredObjectAttribute()
{
- FileFilter = (file) => !CanAllowedExtensions(file.Extension),
- Visible = false,
- Access = false,
- Write = false,
- Read = false
+ FileFilter = (file) => {
+ return NotAllowedExtensions(file.Extension);
+ },
+ ObjectFilter = (obj) =>
+ {
+ var extensions = Path.GetExtension(obj.FullName);
+ if(!string.IsNullOrEmpty(extensions))
+ return NotAllowedExtensions(extensions);
+
+
+ return false;
+ },
+ ShowOnly = false, Access = false, Visible = false, Write = false, Read = false
},
};
_connector.AddVolume(volume);
@@ -115,7 +125,7 @@ namespace Grand.Web.Admin.Controllers
}
- private bool CanAllowedExtensions(string extensions)
+ private bool NotAllowedExtensions(string extensions)
{
var allowedFileTypes = new List<string>();
if (string.IsNullOrEmpty(_mediaSettings.AllowedFileTypes))
@@ -123,7 +133,10 @@ namespace Grand.Web.Admin.Controllers
else
allowedFileTypes = _mediaSettings.AllowedFileTypes.Split(',').Select(x => x.Trim().ToLowerInvariant()).ToList();
- return allowedFileTypes.Contains(extensions.ToLowerInvariant());
+ if (allowedFileTypes.Contains(extensions))
+ return false;
+
+ return true;
}
#endregion