Skip to content

Open-source eCommerce platform for C# and ASP.NET Core 10 with MongoDB. Build multi-store shops and multi-vendor marketplaces with B2B/B2C, REST API, plugins, Vue 3 and Docker.

Update AuthorizeMenuAttribute to return ForbidResult instead of previous result

support2c67a96dc6b1
diff --git a/src/Tests/Grand.Web.Common.Tests/AuthorizeMenuAttributeTests.cs b/src/Tests/Grand.Web.Common.Tests/AuthorizeMenuAttributeTests.cs
index e4f1e9879..52965354b 100644
--- a/src/Tests/Grand.Web.Common.Tests/AuthorizeMenuAttributeTests.cs
+++ b/src/Tests/Grand.Web.Common.Tests/AuthorizeMenuAttributeTests.cs
@@ -139,7 +139,7 @@ public class AuthorizeMenuAttributeTests
await filter.OnAuthorizationAsync(_mockFilterContext);
// Assert
- Assert.IsInstanceOfType(_mockFilterContext.Result, typeof(RedirectToRouteResult));
+ Assert.IsInstanceOfType(_mockFilterContext.Result, typeof(ForbidResult));
}
[Test]
@@ -217,6 +217,6 @@ public class AuthorizeMenuAttributeTests
// Assert
// Permission exists but user is not authorized, so a redirect should occur
- Assert.IsInstanceOfType(_mockFilterContext.Result, typeof(RedirectToRouteResult));
+ Assert.IsInstanceOfType(_mockFilterContext.Result, typeof(ForbidResult));
}
}
\ No newline at end of file
diff --git a/src/Web/Grand.Web.Common/Filters/AuthorizeMenuAttribute.cs b/src/Web/Grand.Web.Common/Filters/AuthorizeMenuAttribute.cs
index c575a0bce..9697982fb 100644
--- a/src/Web/Grand.Web.Common/Filters/AuthorizeMenuAttribute.cs
+++ b/src/Web/Grand.Web.Common/Filters/AuthorizeMenuAttribute.cs
@@ -107,13 +107,13 @@ namespace Grand.Web.Common.Filters
{
if (!(await menuSiteMap.PermissionNames.AllAsync(async x =>
await _permissionService.Authorize(x, _workContext.CurrentCustomer))))
- filterContext.Result = new RedirectToRouteResult("AdminLogin", new RouteValueDictionary());
+ filterContext.Result = new ForbidResult();
}
else
{
if (!(await menuSiteMap.PermissionNames.AnyAsync(async x =>
await _permissionService.Authorize(x, _workContext.CurrentCustomer))))
- filterContext.Result = new RedirectToRouteResult("AdminLogin", new RouteValueDictionary());
+ filterContext.Result = new ForbidResult();
}
}
}