Open-source eCommerce platform for C# and ASP.NET Core 10 with MongoDB. Build multi-store shops and multi-vendor marketplaces with B2B/B2C, REST API, plugins, Vue 3 and Docker.
C# aspnet-corecsharpdockerdotnetecommerceecommerce-platformmongodbmulti-storemulti-vendornosqlonline-shopshoppingcart
Encode thumbnails at quality 80 instead of 100 (#855)
Krzysztof Pajak37d66575e4b5
diff --git a/src/Core/Grand.Domain/Media/MediaSettings.cs b/src/Core/Grand.Domain/Media/MediaSettings.csindex 015ff76f7..5b166ebe1 100644--- a/src/Core/Grand.Domain/Media/MediaSettings.cs+++ b/src/Core/Grand.Domain/Media/MediaSettings.cs@@ -28,7 +28,12 @@ public class MediaSettings : ISettingspublic int MaximumImageSize { get; set; }- public int ImageQuality { get; set; } = 100;+ /// <summary>+ /// Encoder quality for resized pictures and WebP conversion; lossy formats only (JPEG, WebP),+ /// PNG ignores it. 80 is visually indistinguishable from 100 at thumbnail sizes and makes+ /// the files three to four times smaller.+ /// </summary>+ public int ImageQuality { get; set; } = 80;public string AllowedFileTypes { get; set; }diff --git a/src/Modules/Grand.Module.Installer/Services/InstallDataSettings.cs b/src/Modules/Grand.Module.Installer/Services/InstallDataSettings.csindex 5584e1314..0aa0e11b0 100644--- a/src/Modules/Grand.Module.Installer/Services/InstallDataSettings.cs+++ b/src/Modules/Grand.Module.Installer/Services/InstallDataSettings.cs@@ -80,7 +80,7 @@ public partial class InstallationServiceAutoCompleteSearchThumbPictureSize = 50,ImageSquarePictureSize = 32,MaximumImageSize = 1980,- ImageQuality = 100,+ ImageQuality = 80,DefaultPictureZoomEnabled = true,AllowedFileTypes = ".gif, .jpg, .jpeg, .png, .bmp, .webp"});diff --git a/src/Tests/Grand.Domain.Tests/Media/MediaSettingsTests.cs b/src/Tests/Grand.Domain.Tests/Media/MediaSettingsTests.csnew file mode 100644index 000000000..848128afb--- /dev/null+++ b/src/Tests/Grand.Domain.Tests/Media/MediaSettingsTests.cs@@ -0,0 +1,16 @@+using Grand.Domain.Media;+using Microsoft.VisualStudio.TestTools.UnitTesting;++namespace Grand.Domain.Tests.Media;++[TestClass]+public class MediaSettingsTests+{+ [TestMethod]+ public void ImageQuality_DefaultsTo80()+ {+ //thumbnails are encoded with this JPEG quality; 100 made a 450 px thumbnail 120-200 KB+ //against 30-70 KB at 80, with no visible difference+ Assert.AreEqual(80, new MediaSettings().ImageQuality);+ }+}diff --git a/src/Tests/Grand.Mapping.Tests/AdminShared/SettingsMappingTests.MediaSettings_ToModel.verified.txt b/src/Tests/Grand.Mapping.Tests/AdminShared/SettingsMappingTests.MediaSettings_ToModel.verified.txtindex 1af9b11e2..3e8f69f85 100644--- a/src/Tests/Grand.Mapping.Tests/AdminShared/SettingsMappingTests.MediaSettings_ToModel.verified.txt+++ b/src/Tests/Grand.Mapping.Tests/AdminShared/SettingsMappingTests.MediaSettings_ToModel.verified.txt@@ -9,7 +9,7 @@VendorThumbPictureSize: 450,CartThumbPictureSize: 80,MaximumImageSize: 1980,- ImageQuality: 100,+ ImageQuality: 80,DefaultPictureZoomEnabled: false,AutoCompleteSearchThumbPictureSize: 20,FileManagerEnabledCommands: abort,open,file,mkdir,mkfile,parents,tmb,dim,paste,duplicate,get,rm,ls,put,size,rename,tree,resize,search,upload,diff --git a/src/Tests/Grand.Modules.Tests/Installer/MediaSettingsSeedTests.cs b/src/Tests/Grand.Modules.Tests/Installer/MediaSettingsSeedTests.csnew file mode 100644index 000000000..b13c0e0e2--- /dev/null+++ b/src/Tests/Grand.Modules.Tests/Installer/MediaSettingsSeedTests.cs@@ -0,0 +1,22 @@+using System.Text.RegularExpressions;+using Microsoft.VisualStudio.TestTools.UnitTesting;++namespace Grand.Modules.Tests.Installer;++/// <summary>+/// New installations encode thumbnails at JPEG quality 80, not 100. Read from the installer+/// source, like the other seed guards in this folder.+/// </summary>+[TestClass]+public class MediaSettingsSeedTests+{+ [TestMethod]+ public void InstallSettings_SeedsImageQuality80()+ {+ var source = File.ReadAllText(Path.Combine(RepositoryPaths.InstallerServices, "InstallDataSettings.cs"));+ var seed = Regex.Match(source, @"new MediaSettings\s*\{(?<body>.*?)\}\);", RegexOptions.Singleline);++ Assert.IsTrue(seed.Success, "MediaSettings seed not found in InstallDataSettings.cs");+ StringAssert.Matches(seed.Groups["body"].Value, new Regex(@"ImageQuality\s*=\s*80\b"));+ }+}