Skip to content

Open-source eCommerce platform for C# and ASP.NET Core 10 with MongoDB. Build multi-store shops and multi-vendor marketplaces with B2B/B2C, REST API, plugins, Vue 3 and Docker.

fix(plugins): validate antiforgery token on admin POST actions (#754)

Krzysztof Pajak651d79a79312
diff --git a/src/Plugins/Authentication.Facebook/Areas/Admin/Controllers/FacebookAuthenticationSettingsController.cs b/src/Plugins/Authentication.Facebook/Areas/Admin/Controllers/FacebookAuthenticationSettingsController.cs
index 374fd3165..92559b0e9 100644
--- a/src/Plugins/Authentication.Facebook/Areas/Admin/Controllers/FacebookAuthenticationSettingsController.cs
+++ b/src/Plugins/Authentication.Facebook/Areas/Admin/Controllers/FacebookAuthenticationSettingsController.cs
@@ -61,6 +61,7 @@ public class FacebookAuthenticationSettingsController : BasePluginController
}
[HttpPost]
+ [AutoValidateAntiforgeryToken]
public async Task<IActionResult> Configure(ConfigurationModel model)
{
if (!await _permissionService.Authorize(StandardPermission.ManageExternalAuthenticationMethods))
diff --git a/src/Plugins/Authentication.Google/Areas/Admin/Controllers/GoogleAuthenticationSettingsController.cs b/src/Plugins/Authentication.Google/Areas/Admin/Controllers/GoogleAuthenticationSettingsController.cs
index e834e3644..7d362d6b2 100644
--- a/src/Plugins/Authentication.Google/Areas/Admin/Controllers/GoogleAuthenticationSettingsController.cs
+++ b/src/Plugins/Authentication.Google/Areas/Admin/Controllers/GoogleAuthenticationSettingsController.cs
@@ -58,6 +58,7 @@ public class GoogleAuthenticationSettingsController : BaseAdminPluginController
}
[HttpPost]
+ [AutoValidateAntiforgeryToken]
public async Task<IActionResult> Configure(ConfigurationModel model)
{
if (!await _permissionService.Authorize(StandardPermission.ManageExternalAuthenticationMethods))
diff --git a/src/Plugins/Payments.BrainTree/Areas/Admin/Controllers/PaymentBrainTreeController.cs b/src/Plugins/Payments.BrainTree/Areas/Admin/Controllers/PaymentBrainTreeController.cs
index 8f41dd8c1..5fa806997 100644
--- a/src/Plugins/Payments.BrainTree/Areas/Admin/Controllers/PaymentBrainTreeController.cs
+++ b/src/Plugins/Payments.BrainTree/Areas/Admin/Controllers/PaymentBrainTreeController.cs
@@ -54,6 +54,7 @@ public class PaymentBrainTreeController : BasePaymentController
}
[HttpPost]
+ [AutoValidateAntiforgeryToken]
public async Task<IActionResult> Configure(ConfigurationModel model)
{
if (!ModelState.IsValid)
diff --git a/src/Plugins/Payments.CashOnDelivery/Areas/Admin/Controllers/PaymentCashOnDeliveryController.cs b/src/Plugins/Payments.CashOnDelivery/Areas/Admin/Controllers/PaymentCashOnDeliveryController.cs
index c14c995ca..dd3536d20 100644
--- a/src/Plugins/Payments.CashOnDelivery/Areas/Admin/Controllers/PaymentCashOnDeliveryController.cs
+++ b/src/Plugins/Payments.CashOnDelivery/Areas/Admin/Controllers/PaymentCashOnDeliveryController.cs
@@ -51,6 +51,7 @@ public class PaymentCashOnDeliveryController : BasePaymentController
}
[HttpPost]
+ [AutoValidateAntiforgeryToken]
public async Task<IActionResult> Configure(ConfigurationModel model)
{
if (!ModelState.IsValid)
diff --git a/src/Plugins/Payments.StripeCheckout/Areas/Admin/Controllers/StripeCheckoutController.cs b/src/Plugins/Payments.StripeCheckout/Areas/Admin/Controllers/StripeCheckoutController.cs
index b1e44a16a..cbe85c6a1 100644
--- a/src/Plugins/Payments.StripeCheckout/Areas/Admin/Controllers/StripeCheckoutController.cs
+++ b/src/Plugins/Payments.StripeCheckout/Areas/Admin/Controllers/StripeCheckoutController.cs
@@ -55,6 +55,7 @@ public class StripeCheckoutController : BasePaymentController
}
[HttpPost]
+ [AutoValidateAntiforgeryToken]
public async Task<IActionResult> Configure(ConfigurationModel model)
{
if (!await _permissionService.Authorize(StandardPermission.ManagePaymentMethods))
diff --git a/src/Plugins/Shipping.FixedRateShipping/Areas/Admin/Controllers/ShippingFixedRateController.cs b/src/Plugins/Shipping.FixedRateShipping/Areas/Admin/Controllers/ShippingFixedRateController.cs
index 0455f5af8..421375e39 100644
--- a/src/Plugins/Shipping.FixedRateShipping/Areas/Admin/Controllers/ShippingFixedRateController.cs
+++ b/src/Plugins/Shipping.FixedRateShipping/Areas/Admin/Controllers/ShippingFixedRateController.cs
@@ -34,6 +34,7 @@ public class ShippingFixedRateController : BaseShippingController
}
[HttpPost]
+ [AutoValidateAntiforgeryToken]
public async Task<IActionResult> Configure(DataSourceRequest command)
{
if (!await _permissionService.Authorize(StandardPermission.ManageShippingSettings))
diff --git a/src/Plugins/Shipping.ShippingPoint/Areas/Admin/Controllers/ShippingPointController.cs b/src/Plugins/Shipping.ShippingPoint/Areas/Admin/Controllers/ShippingPointController.cs
index fa0b1e38d..c6a0fcfa6 100644
--- a/src/Plugins/Shipping.ShippingPoint/Areas/Admin/Controllers/ShippingPointController.cs
+++ b/src/Plugins/Shipping.ShippingPoint/Areas/Admin/Controllers/ShippingPointController.cs
@@ -42,6 +42,7 @@ public class ShippingPointController : BaseShippingController
}
[HttpPost]
+ [AutoValidateAntiforgeryToken]
public async Task<IActionResult> List(DataSourceRequest command)
{
var shippingPoints = await _shippingPointService.GetAllStoreShippingPoint("",
@@ -90,6 +91,7 @@ public class ShippingPointController : BaseShippingController
}
[HttpPost]
+ [AutoValidateAntiforgeryToken]
public async Task<IActionResult> Create(ShippingPointModel model)
{
if (ModelState.IsValid)
@@ -115,6 +117,7 @@ public class ShippingPointController : BaseShippingController
}
[HttpPost]
+ [AutoValidateAntiforgeryToken]
public async Task<IActionResult> Edit(ShippingPointModel model)
{
if (ModelState.IsValid)
@@ -133,6 +136,7 @@ public class ShippingPointController : BaseShippingController
}
[HttpPost]
+ [AutoValidateAntiforgeryToken]
public async Task<IActionResult> Delete(string id)
{
var model = await _shippingPointService.GetStoreShippingPointById(id);
diff --git a/src/Plugins/Tax.FixedRate/Areas/Admin/Controllers/TaxFixedRateController.cs b/src/Plugins/Tax.FixedRate/Areas/Admin/Controllers/TaxFixedRateController.cs
index d3cc999c2..ef4a3f04c 100644
--- a/src/Plugins/Tax.FixedRate/Areas/Admin/Controllers/TaxFixedRateController.cs
+++ b/src/Plugins/Tax.FixedRate/Areas/Admin/Controllers/TaxFixedRateController.cs
@@ -28,6 +28,7 @@ public class TaxFixedRateController : BaseAdminPluginController
}
[HttpPost]
+ [AutoValidateAntiforgeryToken]
public async Task<IActionResult> Configure(DataSourceRequest command)
{
var taxRateModels = new List<FixedTaxRateModel>();
@@ -46,6 +47,7 @@ public class TaxFixedRateController : BaseAdminPluginController
}
[HttpPost]
+ [AutoValidateAntiforgeryToken]
public async Task<IActionResult> TaxRateUpdate(FixedTaxRateModel model)
{
var taxCategoryId = model.TaxCategoryId;
diff --git a/src/Plugins/Widgets.FacebookPixel/Areas/Admin/Controllers/WidgetsFacebookPixelController.cs b/src/Plugins/Widgets.FacebookPixel/Areas/Admin/Controllers/WidgetsFacebookPixelController.cs
index 722d7d169..1cf9b0528 100644
--- a/src/Plugins/Widgets.FacebookPixel/Areas/Admin/Controllers/WidgetsFacebookPixelController.cs
+++ b/src/Plugins/Widgets.FacebookPixel/Areas/Admin/Controllers/WidgetsFacebookPixelController.cs
@@ -48,6 +48,7 @@ public class WidgetsFacebookPixelController : BaseAdminPluginController
[HttpPost]
[AuthorizeAdmin]
+ [AutoValidateAntiforgeryToken]
public async Task<IActionResult> Configure(ConfigurationModel model)
{
//load settings for a chosen store scope
diff --git a/src/Plugins/Widgets.GoogleAnalytics/Areas/Admin/Controllers/WidgetsGoogleAnalyticsController.cs b/src/Plugins/Widgets.GoogleAnalytics/Areas/Admin/Controllers/WidgetsGoogleAnalyticsController.cs
index f079b4ecd..a76e25c02 100644
--- a/src/Plugins/Widgets.GoogleAnalytics/Areas/Admin/Controllers/WidgetsGoogleAnalyticsController.cs
+++ b/src/Plugins/Widgets.GoogleAnalytics/Areas/Admin/Controllers/WidgetsGoogleAnalyticsController.cs
@@ -48,6 +48,7 @@ public class WidgetsGoogleAnalyticsController : BaseAdminPluginController
}
[HttpPost]
+ [AutoValidateAntiforgeryToken]
public async Task<IActionResult> Configure(ConfigurationModel model)
{
//load settings for a chosen store scope
diff --git a/src/Plugins/Widgets.Slider/Areas/Admin/Controllers/WidgetsSliderController.cs b/src/Plugins/Widgets.Slider/Areas/Admin/Controllers/WidgetsSliderController.cs
index 502f0f02b..cab4a7947 100644
--- a/src/Plugins/Widgets.Slider/Areas/Admin/Controllers/WidgetsSliderController.cs
+++ b/src/Plugins/Widgets.Slider/Areas/Admin/Controllers/WidgetsSliderController.cs
@@ -54,6 +54,7 @@ public class WidgetsSliderController : BaseAdminPluginController
}
[HttpPost]
+ [AutoValidateAntiforgeryToken]
public IActionResult Configure(ConfigurationModel model)
{
_sliderWidgetSettings.DisplayOrder = model.DisplayOrder;
@@ -65,6 +66,7 @@ public class WidgetsSliderController : BaseAdminPluginController
}
[HttpPost]
+ [AutoValidateAntiforgeryToken]
public async Task<IActionResult> List(DataSourceRequest command)
{
var sliders = await _sliderService.GetPictureSliders();
@@ -95,6 +97,7 @@ public class WidgetsSliderController : BaseAdminPluginController
}
[HttpPost]
+ [AutoValidateAntiforgeryToken]
[ArgumentNameFilter(KeyName = "save-continue", Argument = "continueEditing")]
public async Task<IActionResult> Create(SlideModel model, bool continueEditing)
{
@@ -133,6 +136,7 @@ public class WidgetsSliderController : BaseAdminPluginController
}
[HttpPost]
+ [AutoValidateAntiforgeryToken]
[ArgumentNameFilter(KeyName = "save-continue", Argument = "continueEditing")]
public async Task<IActionResult> Edit(SlideModel model, bool continueEditing)
{
@@ -154,6 +158,8 @@ public class WidgetsSliderController : BaseAdminPluginController
return View(model);
}
+ [HttpPost]
+ [AutoValidateAntiforgeryToken]
public async Task<IActionResult> Delete(string id)
{
var pictureSlider = await _sliderService.GetById(id);
diff --git a/src/Plugins/Widgets.Slider/Areas/Admin/Views/WidgetsSlider/Configure.cshtml b/src/Plugins/Widgets.Slider/Areas/Admin/Views/WidgetsSlider/Configure.cshtml
index c82494ee2..2d067bbca 100644
--- a/src/Plugins/Widgets.Slider/Areas/Admin/Views/WidgetsSlider/Configure.cshtml
+++ b/src/Plugins/Widgets.Slider/Areas/Admin/Views/WidgetsSlider/Configure.cshtml
@@ -39,12 +39,14 @@
read: {
url: "@Html.Raw(Url.Action("List", "WidgetsSlider"))",
type: "POST",
- dataType: "json"
+ dataType: "json",
+ data: addAntiForgeryToken
},
destroy: {
url: "@Html.Raw(Url.Action("Delete", "WidgetsSlider"))",
type: "POST",
dataType: "json",
+ data: addAntiForgeryToken
}
},
schema: {
diff --git a/src/Plugins/Widgets.Slider/Areas/Admin/Views/WidgetsSlider/_Settings.cshtml b/src/Plugins/Widgets.Slider/Areas/Admin/Views/WidgetsSlider/_Settings.cshtml
index 492b755f9..b8a000da7 100644
--- a/src/Plugins/Widgets.Slider/Areas/Admin/Views/WidgetsSlider/_Settings.cshtml
+++ b/src/Plugins/Widgets.Slider/Areas/Admin/Views/WidgetsSlider/_Settings.cshtml
@@ -4,6 +4,7 @@
@inject SliderWidgetSettings setting
<form method="post" id="widget-settings-form">
+ @Html.AntiForgeryToken()
<div class="panel-group">
<div class="panel panel-default">
<div class="panel-body">
@@ -37,7 +38,6 @@
$('#savegeneralsettings').click(function () {
var postData = $(this.form).serialize();
- addAntiForgeryToken(postData);
$.ajax({
cache: false,